From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Vladimir Kazanov Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: ert-font-lock Date: Mon, 20 Nov 2023 18:27:01 +0000 Message-ID: References: <87v89zz4v4.fsf@posteo.net> <87v89zjmcx.fsf@yahoo.com> <83fs13mduq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4231"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Po Lu , philipk@posteo.net, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Nov 20 19:28:04 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r5907-0000m9-L5 for ged-emacs-devel@m.gmane-mx.org; Mon, 20 Nov 2023 19:28:03 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r58zP-0004x4-Pp; Mon, 20 Nov 2023 13:27:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r58zO-0004wg-GN for emacs-devel@gnu.org; Mon, 20 Nov 2023 13:27:18 -0500 Original-Received: from mail-lj1-x22d.google.com ([2a00:1450:4864:20::22d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r58zM-0001FZ-Oj; Mon, 20 Nov 2023 13:27:18 -0500 Original-Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2c87903d314so24128081fa.1; Mon, 20 Nov 2023 10:27:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700504834; x=1701109634; darn=gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=dbimKem/uErIlG4O+35fK+Z71hMPeSCCVWrLpOq8J1Q=; b=Tk1QcWteaSpxbhiw5llgCA7TWNcuzAAYN+rKB42vq6ehqbIohbBWl6CPDcldfUxEVg 2zEWD1oK280WYtXz/i6N+UNKLN82rqIZKRLBjPtazIhnSYTDQBfoNHMuWNA4nRNrIQlT WxdwQX11u6nTyV+KBpS2MCyl1f4/tL4W5rngUj/hRH9rrxxE1KfN+GbUksCHAxXCgZR2 SeP7bqQ2N9d52iA3bqbiiUEwSqaDsm4/peNqAlemwcovpfgCesUBVNhMEROuERcjX4Gs yQRxvN4s7XAV4xJsWqwuuUB1IEOd7Pvg8vZELvCRszFEeXWNOHhh/ug0BfNUddfWCwOe mD7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700504834; x=1701109634; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dbimKem/uErIlG4O+35fK+Z71hMPeSCCVWrLpOq8J1Q=; b=Ak3pNUHDa8YWifHcBjwImG/lx+DFyO1PpsGloqHjtXfo0mIFkDQkpIC0X+N/KlLiLl efmxX+uve/MIti8RtKJWZA+5cjzNwNExTxmMrhatkmY4AWcJlCc4gC+D9k20P42l+406 pN1LnKefQ1KtNg7/NmmoakqDioDokm7yZIGtX3jvXsLU32uSFwtD6PkBadyoBc6OVHgQ 8qipPmdgguTwklu3Sq/ieFdPOpBanmD4YjUPu+JCdJRp2g5gKURplgVm64bFiOdkJKkT KICEMvT79Dpqa5HGuVeowUr4TKwcuAaySYo9igPTKLSBtLeBEnxnhXZ1Qp/b3sI4Acob JrCg== X-Gm-Message-State: AOJu0YyPhX+Z73blSLawGmC1Uq8IcL7tsKRxQz+j6D0CWTeKziDD+mmV 8sSkPZz6oJEEVqn6KqmNkkmK5bKquRfoFy6ZvRYoNzo= X-Google-Smtp-Source: AGHT+IFl/9E+fSwbiHJfzQ2SyIQbd4teGhn7zepAsw+AcfxEHMyoEE7PkxYYQLjB4GOOWxZ3pR+Gi7/SGPHQEfx5msA= X-Received: by 2002:a05:651c:1075:b0:2c0:2583:520e with SMTP id y21-20020a05651c107500b002c02583520emr4652457ljm.41.1700504833450; Mon, 20 Nov 2023 10:27:13 -0800 (PST) In-Reply-To: Received-SPF: pass client-ip=2a00:1450:4864:20::22d; envelope-from=vekazanov@gmail.com; helo=mail-lj1-x22d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:313066 Archived-At: Hi everyone, Just bumping this thread for visibility. I've made most of the changes that were suggested earlier and clarified how my package differs from faceup.el. I'm also considering if it's feasible to lower the Emacs version requirement to 27.1 and planning to run some more tests for edge cases. Other than that, the tool is pretty much set and shouldn't see major changes. Could you let me know what I should do next to move forward with adding the package to ELPA (or Emacs itself if Eli doesn't mind)? Thanks a lot for your help! On Sun, 19 Nov 2023 at 10:08, Vladimir Kazanov wrote: > > > I won't object to including this, FWIW. > > Would this require any additional changes to the way the code is structured? > > There were also some questions around ert-font-lock.el being similar > to faceup.el. I covered these elsewhere. > > On Sat, 18 Nov 2023 at 12:43, Eli Zaretskii wrote: > > > > > From: Po Lu > > > Cc: Vladimir Kazanov , emacs-devel@gnu.org > > > Date: Sat, 18 Nov 2023 20:07:42 +0800 > > > > > > Philip Kaludercic writes: > > > > > > > ELPA shouls be fine. > > > > > > Since this is an adjunct to ERT, which is plausibly useful for the unit > > > testing of Emacs fontification code itself, I think such code should be > > > part of Emacs proper. > > > > I won't object to including this, FWIW. > > > > > BTW, this code requires cl-lib for a meager one macro. Please replace > > > > > > (cl-incf curline) > > > > > > with > > > > > > (setq curline (1+ curline)) > > > > > > that cl-lib might not be loaded either at compile-time or runtime. > > > There is no rationale for requiring cl-lib so as to employ a single > > > macro once. > > > > Doesn't this library require ert? if it does, cl-lib is already > > loaded by ert. > > > > But if people like cl-incf so much, we could just add incf to subr.el > > or something. > > > > -- > Regards, > > Vladimir Kazanov -- Regards, Vladimir Kazanov