From: "Milan Stanojević" <mstanojevic@janestreet.com>
To: emacs-devel@gnu.org
Subject: Re: emacs modules memory leak in 27
Date: Wed, 22 Jul 2020 19:37:50 -0400 [thread overview]
Message-ID: <CAArdBwO+ccCTqwvFrO3pz6=xC3pEPyfQyPo3q05zxuc2TJrH8g@mail.gmail.com> (raw)
In-Reply-To: <CAArdBwMY_yug89Bm5BwZ3u6V5shE5BGfm6uhvRVVrrYf1xCODA@mail.gmail.com>
I submitted the bug report.
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=42482
I wonder if some kind of hybrid approach would work. Use the same
representation like emacs-26 (emacs_value is Lisp_Object) but also
have an array of emacs_values created in the environment (like in
emacs-27) that can be used to mark them for garbage collection. Global
storage wouldn't be necessary.
On Mon, Jul 20, 2020 at 12:41 PM Milan Stanojević
<mstanojevic@janestreet.com> wrote:
>
> This is on emacs-27 branch.
>
> env-make_global_ref will add a reference to the underlying Lisp_Object
> and allocate emacs_value from the global storage. env->free_global_ref
> on the other hand will only remove a reference to the underlying
> Lisp_Object and not free the emacs_value.
>
> The global storage of emacs_values seems to be only growing and is
> never collected (and I think with the current array implementation it
> is probably not possible to collect).
>
> This leak is not present in 26 and I think the leak was introduced
> with the change in the underlying representation of emacs_value. (If
> I'm reading git history right, since 26 this was changed and then
> reverted and then changed again).
prev parent reply other threads:[~2020-07-22 23:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 16:41 emacs modules memory leak in 27 Milan Stanojević
2020-07-22 23:37 ` Milan Stanojević [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAArdBwO+ccCTqwvFrO3pz6=xC3pEPyfQyPo3q05zxuc2TJrH8g@mail.gmail.com' \
--to=mstanojevic@janestreet.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).