From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: emacs | Pipeline #8399 has failed for master | ee0e259e Date: Tue, 5 Jan 2021 14:44:56 +0100 Message-ID: References: <5feaf98365b55_3f903d428113941@emba.gnu.org.mail> <87o8ica9xp.fsf@gmx.de> <87pn2s35a2.fsf@gmail.com> <87ft3oa4pz.fsf@gmx.de> <8735zo9ui7.fsf@gmx.de> <87h7nw39gg.fsf@gmail.com> <87im8b3jo6.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17307"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Emacs developers To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jan 05 14:46:25 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kwmfI-0004N0-CP for ged-emacs-devel@m.gmane-mx.org; Tue, 05 Jan 2021 14:46:24 +0100 Original-Received: from localhost ([::1]:35700 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kwmfH-0004iH-Dm for ged-emacs-devel@m.gmane-mx.org; Tue, 05 Jan 2021 08:46:23 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40894) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwme6-0004As-46 for emacs-devel@gnu.org; Tue, 05 Jan 2021 08:45:10 -0500 Original-Received: from mail-oi1-x233.google.com ([2607:f8b0:4864:20::233]:34524) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kwme4-0002zS-Ft for emacs-devel@gnu.org; Tue, 05 Jan 2021 08:45:09 -0500 Original-Received: by mail-oi1-x233.google.com with SMTP id s75so36015354oih.1 for ; Tue, 05 Jan 2021 05:45:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eas5PllHSZH/fgHdyRjaafA2ph0KkWdLjGybNfXmDDs=; b=jlU0JVZUKdAo2WuaAC+MOIdk23DCRylLWN7zCnHi85muckP/KF3U2FhUhoaKi55Ijc c8pdTvVB1EXpLfI1btCrKLTWPpz5/Lp4Z5h2Zv3iOSEFYXm14X0ZHxA9V2jE27Arkca7 QtBgyYDMUd5BR4LEi7LeCP9+oP6JrbdDsjihzpBcW9exJia/4xvAPD87BufTj+ZbuEyk pPbhJzLc346Cdf4kjXItVpBkW92SNMbm82pN5Igyv3X8qW/RiCSctagKJcyOXDxTgeSJ N1/0HgdBGp9zuPR93htJrq7sWwKZ6UuarjivfxrQxVWz5yMVEF8N6MsErcUAEGYWv7zB 91eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eas5PllHSZH/fgHdyRjaafA2ph0KkWdLjGybNfXmDDs=; b=cnufX4FcTvf9/laTvMwzG8wOkagvSKOYR8Zqe2W50hjadgxvMfQiP04l9tCyi2vP4v riZhUR2en4fiqdg6GxSGAj2jWkjBJZwxhn4j+oEux0NggK8OogNFLzPIIE961lfo/pEK fayx7h5dona39hYeJfpZFV84UGupzcxeCH12IjMm0CYOk40z2qzrxEbusdwtJgpVkkTS 3nCgFtfShfo/EJn7XVzTVgt8QgFkSOR3HcsB7a06Zg+BXrWRc9Q6M2ZiUs2vrysKFdvW VmSKNCB0q+q+bSpE86ovrIM22eEuYlSd3RBRntGZtVAZwDrE7/mtBdvD4I/wFQEuhmeE Pgkg== X-Gm-Message-State: AOAM530Fyaq6Pjbml1lNjnH1VoreLVwwhrEpImgBGNYV4trJSvD9MBMs /0URFkxFOTgfIkeA2EcUQGNNW/76+xgxmnvIzhU= X-Google-Smtp-Source: ABdhPJy9OqCYG+CBVcP2gjPhnetkDr8saNoh59fVStojMEZoakwB8v63DeFJ7FPqPCx49fKyKBRmwVWMATOMZdsPUJg= X-Received: by 2002:aca:3784:: with SMTP id e126mr2604932oia.170.1609854307225; Tue, 05 Jan 2021 05:45:07 -0800 (PST) In-Reply-To: <87im8b3jo6.fsf@gmx.de> Received-SPF: pass client-ip=2607:f8b0:4864:20::233; envelope-from=p.stephani2@gmail.com; helo=mail-oi1-x233.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:262516 Archived-At: Am Di., 5. Jan. 2021 um 08:52 Uhr schrieb Michael Albinus : > > Philipp Stephani writes: > > >> process-test-sentinel-wait-function-working-p which is used by > >> process-test-sentinel-sit-for looks racy. Just because the process > >> sentinel has been called is no guarantee that the process has exited > >> and had its process-status set correctly, perhaps it should loop on > >> 'process-live-p' > > > > AFAIK the only correct way to wait for a process to exit is (while > > (accept-process-output PROC)). > > I vaguely remember that Stefan did propose (while (accept-process-output > PROC 0)). I guess that would work as well, but wouldn't it result in a busy wait? OTOH, accept-process-output with an infinite timeout should return immediately if the process has terminated (i.e. Emacs has processed the SIGCHLD signal).