From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 61f8c23 1/2: Minor advice.el fix Date: Sun, 18 Dec 2016 19:43:54 +0000 Message-ID: References: <20161212202151.21054.37035@vcs.savannah.gnu.org> <20161212202152.428192201BB@vcs.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a11444cc49338550543f406aa X-Trace: blaine.gmane.org 1482090263 27416 195.159.176.226 (18 Dec 2016 19:44:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 18 Dec 2016 19:44:23 +0000 (UTC) To: Stefan Monnier , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Dec 18 20:44:19 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cIhNW-0005iU-9M for ged-emacs-devel@m.gmane.org; Sun, 18 Dec 2016 20:44:14 +0100 Original-Received: from localhost ([::1]:41921 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cIhNY-0008VQ-Q6 for ged-emacs-devel@m.gmane.org; Sun, 18 Dec 2016 14:44:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42045) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cIhNP-0008U7-8Q for emacs-devel@gnu.org; Sun, 18 Dec 2016 14:44:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cIhNO-0006n6-8l for emacs-devel@gnu.org; Sun, 18 Dec 2016 14:44:07 -0500 Original-Received: from mail-wm0-x22a.google.com ([2a00:1450:400c:c09::22a]:36709) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cIhNO-0006mo-23 for emacs-devel@gnu.org; Sun, 18 Dec 2016 14:44:06 -0500 Original-Received: by mail-wm0-x22a.google.com with SMTP id g23so77579542wme.1 for ; Sun, 18 Dec 2016 11:44:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=tcqm80lCa45zs40NLzoZSmYPhtvFe7t22G76brHdO+k=; b=jUdOiQYAM/EM6S5H434bJP/J7OkvnNXQz/25PuCSseQTRX4sB6dw0ZTzcvBcrG07Xm foYCeLv+z719jPV6Kt4bqw/TF4aTcKU/d+6LtcTQLy/t6Ml18N/VnmphDwVZEwHYtQHz eB7Kb2IGD7nHxdLUTt1LnjqTzEKN08RQ+Q//lZjChcNEcomdstTfBKBkY+4G5PXDYLcw aLFPHQuv5LfwZjA9uLzK4Cu/1mUSyd/MY7ktxUO7iHMoJ37lWgvo6GUHeD1A7wPFFnG2 76YNbJvp5kvQuHKA2avCEfIrmJoita76JQOo0YB7XaEfOm0lhnQ3PZzWc1i3+pHEZYgJ 81qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=tcqm80lCa45zs40NLzoZSmYPhtvFe7t22G76brHdO+k=; b=jy0YRUHcT8vHolhNThRWNLmSfVTl+aColbuYCsa6OOW0KXGwHztcsHOwOyJdaIjMv4 2l00Wg5/Wpw4ApWJ8XJznTcrkXXwT/2C/TYpKFfN9hadlyYlbFzfms/iu7HhuafuUarg hMNMnoIKkYFQ8++YTti/HzV05kAZSYB8KmSdyivnarDwUhDuIdOVsioISPsRvtVaEoIq zWIoSzKyOprxUu/x92n3qjLbKPnB83pRBW2TIiW7Y7hOf3ztMvA8oP3WRG/3yPH+xsg5 ZDRlyYdREU2CeCFvWdSzvGqM+ZE0du+as1jaqZ1mhNPBgqmj2EmtkOuAbHo+GdBfhM6A 1FLA== X-Gm-Message-State: AIkVDXIAEzNISKBhAxYJe/ak58vpXjqwv+msL3yhddgj99khq/Tl93I7bhAQnTTRxmLd7Ls1xqxAKDoRFUejYQ== X-Received: by 10.28.87.84 with SMTP id l81mr11697276wmb.48.1482090244943; Sun, 18 Dec 2016 11:44:04 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::22a X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:210606 Archived-At: --001a11444cc49338550543f406aa Content-Type: text/plain; charset=UTF-8 Stefan Monnier schrieb am Sa., 17. Dez. 2016 um 23:09 Uhr: > > Yes, fset for most primitives should be forbidden. > > Define "most". > > That would mean we can't use advise, trace-function, debug-on-entry, or > elp on them. There are very legitimate reasons to fset them. > > For some of them definitely. I'd draw the line between pure functions like car and eq, where those facilities never make sense and would be ineffective anyway as the functions are compiled away or called directly, and impure functions like call-process, where fset is necessary for mocking. As a rule of thumb, I'd suggest to ban fset on all symbols that have a byte-code equivalent, and on constant symbols. --001a11444cc49338550543f406aa Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


Stefan= Monnier <monnier@iro.umontr= eal.ca> schrieb am Sa., 17. Dez. 2016 um 23:09=C2=A0Uhr:
> Yes, fset for most primitives should be f= orbidden.

Define "most".

That would mean we can't use advise, trace-function, debug-on-entry, or=
elp on them.=C2=A0 There are very legitimate reasons to fset them.


For some of them definitely. I'd draw = the line between pure functions like car and eq, where those facilities nev= er make sense and would be ineffective anyway as the functions are compiled= away or called directly, and impure functions like call-process, where fse= t is necessary for mocking. As a rule of thumb, I'd suggest to ban fset= on all symbols that have a byte-code equivalent, and on constant symbols.= =C2=A0
--001a11444cc49338550543f406aa--