From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Allow inhibiting 'auto-save-visited-mode' on a per-buffer basis. Date: Sun, 5 Apr 2020 11:50:18 +0200 Message-ID: References: <20200401175736.203124-1-phst@google.com> <83wo6yxb0s.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="5041"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Philipp Stephani , Eli Zaretskii , Emacs developers To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Apr 05 11:51:09 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jL1vp-0001D1-1o for ged-emacs-devel@m.gmane-mx.org; Sun, 05 Apr 2020 11:51:09 +0200 Original-Received: from localhost ([::1]:46392 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jL1vo-00077p-5s for ged-emacs-devel@m.gmane-mx.org; Sun, 05 Apr 2020 05:51:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35947) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jL1vI-0006cg-KX for emacs-devel@gnu.org; Sun, 05 Apr 2020 05:50:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jL1vH-000452-Jr for emacs-devel@gnu.org; Sun, 05 Apr 2020 05:50:36 -0400 Original-Received: from mail-oi1-x241.google.com ([2607:f8b0:4864:20::241]:36544) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jL1vC-00041j-S3; Sun, 05 Apr 2020 05:50:30 -0400 Original-Received: by mail-oi1-x241.google.com with SMTP id k18so10460562oib.3; Sun, 05 Apr 2020 02:50:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EtBVbZFmhbSltX61gD6yFkntUF4CNeTPnEf34RLQToY=; b=vJRQn3uGa9IA/CsXPn1z2VZ40XBk0VNXOktHfIwfANmKqZSSO1dHgt35VImpzLofN4 baHjIgZ0VyVQYH4YUcZAQ4Qag9OQ8vH/8R5W5c3Nttsgd+6QhbluXwUcBAHtgNQgv+S/ hG/aBakhe7UVcCQYfz7Rz3M+ZBPpunYQdODMtyx2qJGjOZ4AOdX5OTv7LchLZ0kuQ4ma JHOWrNmpx9RO5+dfYfqrCCZKOfSA3T2tM5prEfuBnwj5wUnD5uwX6Y26iJPeWW2pUya1 5Hl91mN5qk9y07xGUXwrojsQyvxIdJLnF+F5uyfXAh50fsYAZg4YUvtBtZaN/SUWwsBz WQSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EtBVbZFmhbSltX61gD6yFkntUF4CNeTPnEf34RLQToY=; b=htfn8gt9Oh/ZKT+AMBOkP8LZ/YTMtsURkTtTCInE86NcAKW8eT6JvkYmEnVAlWAbcY JT5zCoWNkL26EUPO6lYnzIb+LJfyYn1exXrasnd9E8A5lU/dL9m9yLFG9aPGAepankFf bMfAmftvyDNSsF17OisMm+M3ZirOl2hdHzr/bkIh+1flRq4Bqg6lwgvBhLVkbDIKU//P yEIEJTMvS5SIV4C/hCDwzegeIu7E4q+JORstn9DGP3jZVf5xWsV8VdDnu7ultxVJK7XZ RL5INfyyeHTYdFSgGyjjxWqmaKDNoRjKpZ7gWMoL6BXn+QdNsXYPziI0xwj0paux4AKI ygpA== X-Gm-Message-State: AGi0PuYx16V4SBvKNjDFgJIVRjIDt5JVAYE3ZY8kelj+mbKodkuKidCz L5e4ny1xFp3WjA+w5gnlbc7sBxl3jMWl32TNGrM= X-Google-Smtp-Source: APiQypKToaCOyjjVLrur/nlw/p9gw8i9s4kOt89E3xxTsOA7ewmWeoj0D8Ia7YlIEjdWAPCdI+EA3P+IOcUG5tac0Zg= X-Received: by 2002:aca:4bc5:: with SMTP id y188mr9346611oia.9.1586080229967; Sun, 05 Apr 2020 02:50:29 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::241 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:246443 Archived-At: Am Do., 2. Apr. 2020 um 17:22 Uhr schrieb Stefan Monnier : > > > Wouldn't it be better to have a local minor mode and a globalized > > minor mode, like we do in other cases? > > We could start with the patch below (which allows disabling the mode in > specific buffers, but lacks the rest of the code which would allow > *enabling* the mode in specific buffers). > > > Stefan > > > diff --git a/lisp/files.el b/lisp/files.el > index 55a0958f54..5132aa456a 100644 > --- a/lisp/files.el > +++ b/lisp/files.el > @@ -441,6 +441,7 @@ auto-save-visited-mode > #'save-some-buffers :no-prompt > (lambda () > (and buffer-file-name > + auto-save-visited-mode > (not (and buffer-auto-save-file-name > auto-save-visited-file-name)))))))) > Is this really OK? All minor mode variables, including auto-save-visited-mode, by default get the "Setting this variable directly does not take effect" documentation string, because we want to use minor mode variables only for checking a mode's state and always want users to call the mode function.