From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 1/3] Document that 'make-process' mixes the output streams Date: Sat, 07 Apr 2018 20:18:19 +0000 Message-ID: References: <20180404120218.257212-1-phst@google.com> <8360573yke.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000005324bc056947e0f1" X-Trace: blaine.gmane.org 1523132234 6748 195.159.176.226 (7 Apr 2018 20:17:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 7 Apr 2018 20:17:14 +0000 (UTC) Cc: phst@google.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 07 22:17:08 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f4uGp-0001dT-2J for ged-emacs-devel@m.gmane.org; Sat, 07 Apr 2018 22:17:08 +0200 Original-Received: from localhost ([::1]:50658 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f4uIu-00041S-Go for ged-emacs-devel@m.gmane.org; Sat, 07 Apr 2018 16:19:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34178) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f4uIF-000403-73 for emacs-devel@gnu.org; Sat, 07 Apr 2018 16:18:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f4uIE-0005YF-34 for emacs-devel@gnu.org; Sat, 07 Apr 2018 16:18:35 -0400 Original-Received: from mail-lf0-x22b.google.com ([2a00:1450:4010:c07::22b]:40876) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f4uIC-0005Wx-JJ; Sat, 07 Apr 2018 16:18:32 -0400 Original-Received: by mail-lf0-x22b.google.com with SMTP id e5-v6so4902445lfb.7; Sat, 07 Apr 2018 13:18:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ts1YG8IjRR8Kwn+546244pVxjCT0FPuuyVthPFPiHpQ=; b=Zgux0ygvqiDJo448aWiiGlMuS2QaRSOffuc1PerWnVeA3t6SkV9dUcIqg8yi+I2wJJ k+S2yc7320clAG0iGiutzM64ZVfDZ7psPs0fJNB0eUaI44AWy/b2UiwZSgYSxKjfcHbG Ow8lKJONa3b0Vrnq5l6TDlaO5plrGN1+OhNZnM8kHfgUi1qZG5eIEn0+6TO3z6h+5bSp 7rJ4sMEWFu2YnIq/ajUTjwBTHsTePEezd2fAx3InRwjXVuFv+3OnRXafa0OslFUjtniC PTS9plbwL4beZ7f3HXmnzDVKSGXwt/pa/79+wiXh4BERWrMq87Javsh29Fric5236qqn /LVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ts1YG8IjRR8Kwn+546244pVxjCT0FPuuyVthPFPiHpQ=; b=JzBEqe6fXrTofWk5v/bufNzfL5BcF96J0envEEMGEsY7/Ib4WSLxVY+tSJB2UC+Uni 7cYQb3xGccJqCstfYLbyYRWQMJmnjjrp1sO+NsohtfjZaNJZxe9T35rtt0qdT3rCyM5w XTIffY0DLlRZF6DFX45r1S/QvhYkJBumE9xJfcLvXBYRpG9/GfsnOYg3LWFG8QI6L9zF SCOToJDWXDwgGFTQyULi3O6y4ADpiJ5N+ldg8aomMPEkRAKpYmuuWhD8IfM1P90/in6U DzLwxLlYM3oj3AVcAbSTHSyMgHhYNBb59EVsT3di+lUBdL2tYgCkiVxx7n/9RSI4Yhye bAZg== X-Gm-Message-State: ALQs6tA6EBln0wsE6+jxVr0uZ5fH4SPAW3miRQMDsmIns4TviP9w5zk1 XQulLW2RUs0SHbmoYF0fnK4gg8mh3+7WRWsgaEdxFw== X-Google-Smtp-Source: AIpwx4+CriO+VpRW1xFMp2Q/ZUfSUMWk9pMZJcF2jlZsmfoLqzDT9YzVpa+E7mbVU7S355GfoUWvC3xD1dUSZyeif8A= X-Received: by 2002:a19:c987:: with SMTP id z129-v6mr18728017lff.74.1523132310691; Sat, 07 Apr 2018 13:18:30 -0700 (PDT) In-Reply-To: <8360573yke.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::22b X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:224417 Archived-At: --0000000000005324bc056947e0f1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Eli Zaretskii schrieb am Mi., 4. Apr. 2018 um 15:12 Uhr: > > From: Philipp Stephani > > Date: Wed, 4 Apr 2018 14:02:16 +0200 > > Cc: Philipp Stephani > > > > * doc/lispref/processes.texi (Asynchronous Processes): > > * src/process.c (Fmake_process): Document that standard error is mixed > > with standard output if STDERR is nil. > > Thanks. > > > +(ert-deftest make-process/mix-stderr () > > + "Check that =E2=80=98make-process=E2=80=99 mixes the output streams = if STDERR is nil." > > + (skip-unless (executable-find shell-file-name)) > > + (with-temp-buffer > > + (let ((process (make-process > > + :name "mix-stderr" > > + :command (list shell-file-name shell-command-switc= h > > + "echo stdout; echo stderr >&2") > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > This shell command is non-portable: on Windows you have to use "&" > instead of ";" to chain commands. You could use "&&", which in this > case will do the same on both Posix and Windows systems. > Done and pushed to master. --0000000000005324bc056947e0f1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Eli Za= retskii <eliz@gnu.org> schrieb am= Mi., 4. Apr. 2018 um 15:12=C2=A0Uhr:
> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Wed,=C2=A0 4 Apr 2018 14:02:16 +0200
> Cc: Philipp Stephani <phst@google.com>
>
> * doc/lispref/processes.texi (Asynchronous Processes):
> * src/process.c (Fmake_process): Document that standard error is mixed=
> with standard output if STDERR is nil.

Thanks.

> +(ert-deftest make-process/mix-stderr ()
> +=C2=A0 "Check that =E2=80=98make-process=E2=80=99 mixes the outp= ut streams if STDERR is nil."
> +=C2=A0 (skip-unless (executable-find shell-file-name))
> +=C2=A0 (with-temp-buffer
> +=C2=A0 =C2=A0 (let ((process (make-process
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= :name "mix-stderr"
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= :command (list shell-file-name shell-command-switch
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"echo stdout; = echo stderr >&2")
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^^^^^^^^^^^^^^^= ^^^^^^^^^^^^^^^
This shell command is non-portable: on Windows you have to use "&&= quot;
instead of ";" to chain commands.=C2=A0 You could use "&= &", which in this
case will do the same on both Posix and Windows systems.

Done and pushed to master.=C2=A0
--0000000000005324bc056947e0f1--