From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 2/3] Don't print "process finished" into the stderr buffer. Date: Sun, 21 Apr 2019 15:55:54 +0200 Message-ID: References: <20180404120218.257212-1-phst@google.com> <20180404120218.257212-2-phst@google.com> <834lkr3ygo.fsf@gnu.org> <83lgdxzvs2.fsf@gnu.org> <83imv9b0b0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="54847"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Philipp Stephani , Emacs developers To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 21 15:56:59 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hICxm-000E9Z-QT for ged-emacs-devel@m.gmane.org; Sun, 21 Apr 2019 15:56:58 +0200 Original-Received: from localhost ([127.0.0.1]:53485 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hICxl-00010N-NW for ged-emacs-devel@m.gmane.org; Sun, 21 Apr 2019 09:56:57 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60932) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hICxC-00010G-Jf for emacs-devel@gnu.org; Sun, 21 Apr 2019 09:56:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hICxB-0004XL-JY for emacs-devel@gnu.org; Sun, 21 Apr 2019 09:56:22 -0400 Original-Received: from mail-ot1-x341.google.com ([2607:f8b0:4864:20::341]:43825) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hICwx-0004NX-Tt; Sun, 21 Apr 2019 09:56:08 -0400 Original-Received: by mail-ot1-x341.google.com with SMTP id u15so7685185otq.10; Sun, 21 Apr 2019 06:56:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=jjmoIwihzKd6zHYdO03ZBQ06jQZ+1r0a3JGwsMrC408=; b=avYiKasIEXieKD5DM++9sgGHm2GKXKBD80SyHv/1FFjmp8sHXhSyxZlRjmwaYYECMd 9JYeDU3rF7E4fUrXjyrjPZvnItLJlnx1PHyPYPain6w9/jXTacLZeihW2Sf3dfxP+mnE 1gD4m3SETrFZkebhT+ZRot2sF0FLurW4z7QuPIvQbgGjiqH8FxUR0J3velBkKciKuuYr cJaLc4ychJMEieT0PkMjfu3fweKwwnJLkSgsVrGWshVmwxcRQ7/KYjDwCnbNjjugS+5T +pcBncvVVOl9gIAUHQkAmtQambHPCwuITiOQdQvKuH1Olx9Q3KEvWvoVNjl5T6azJcmu hczA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=jjmoIwihzKd6zHYdO03ZBQ06jQZ+1r0a3JGwsMrC408=; b=Kr9c2IaEf7wjEYFvBHd9Wp910Kp9PeP4jZBh9ZzjVnCpK15nWTEaAKYlfbeO3Ug0GJ fQMYTAl1eKMRVe41AH3mPZJ2P+myQe6yzcsbkttq2KPhA9BX92pFtd+ihwmGV3s1yufi xoPW/+GZx5e/xPaFSSokTdJUU+5iqbDRhfSSYY2apRyE+j1lTXSxfmQR7y0V52QYgyv/ J5l6DHL5Id+UBQOqA9Cwrjen5ABszcUaFmF/8AhuBGTjR4YoOV4kz3XSC3CxaTxROmQo xZKmGXJ8oel6h+2lp2prMK2atXVtN/qv+ZFR2iBnS1hYxN9y+BnVXBbzwcupzcdtmlc4 cSBQ== X-Gm-Message-State: APjAAAUxXF8CyR9Ig0jPCuH/Wd/mY6fETMcHKq8E9UZM6+q0tNy2l13c Jx418HELxr1sXBw/7zFoBuU71Yr5kw1X831zRcE27w== X-Google-Smtp-Source: APXvYqwclvNKCMNj0zgcfK1NMoPdJ7FVhcyEJaufltdMNo9hjVp2g8XE6gM/zlNumh2zhPDnhTEBtjso9uOE1tVCxBo= X-Received: by 2002:a9d:62c8:: with SMTP id z8mr8259771otk.144.1555854965365; Sun, 21 Apr 2019 06:56:05 -0700 (PDT) In-Reply-To: <83imv9b0b0.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::341 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235730 Archived-At: Am Sa., 20. Apr. 2019 um 09:31 Uhr schrieb Eli Zaretskii : > > > From: Philipp Stephani > > Date: Fri, 19 Apr 2019 21:28:32 +0200 > > Cc: Emacs developers , Philipp Stephani > > > > > But I'm guessing that the current behavior was unexpected for some > > > reason, and that's why you looked in the documentation. If the guess > > > is correct, could you describe why it was unexpected/unwanted? > > > > It's unexpected that Emacs writes something. This is an instance of > > the general case that by default you expect nothing to happen instead > > of something, unless you request the "something". For example, after > > $ echo foo > bar > > would you expect that the file "bar" contains content other than > > "foo\n" because the shell decides to write additional text before > > closing redirections? This is the same thing. > > But Emacs does that for ages, so in Emacs this is veteran behavior of > the default sentinel function. Sure, but the documentation doesn't state clearly that Emacs creates a pipe process with the default sentinel if the caller passes a buffer, so it's unexpected that the default sentinel runs. > > > The documentation for make-process doesn't state that if :stderr is a > > buffer, make-process creates a pipe process with the default sentinel; > > Actually, it does, albeit in the parent section: > > Alternatively, you could use the =E2=80=98:stderr=E2=80=99 parameter= with a non-=E2=80=98nil=E2=80=99 > value in a call to =E2=80=98make-process=E2=80=99 (*note make-process: = Asynchronous > Processes.) to make the destination of the error output separate from > the standard output; in that case, Emacs will use pipes for > communicating with the subprocess. That seems rather subtle and even unrelated. The "pipe" here refers to Unix pipes, not to Emacs pipe processes. If you don't want to change the behavior, how about at least clarifying the documentation? I can install a patch for that.