From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: master 64109fcae7 2/3: indent-for-tab-command: Deal with large point or modiff values. Date: Mon, 17 Jan 2022 18:23:07 +0100 Message-ID: References: <164219059635.16941.2631797019964844711@vcs2.savannah.gnu.org> <20220114200316.CB79BC0DA30@vcs2.savannah.gnu.org> <87h7a2qy73.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3096"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Philipp Stephani , Emacs developers To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jan 17 18:25:37 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n9VlB-0000a5-EC for ged-emacs-devel@m.gmane-mx.org; Mon, 17 Jan 2022 18:25:37 +0100 Original-Received: from localhost ([::1]:54460 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n9Vl9-0006Nz-Tx for ged-emacs-devel@m.gmane-mx.org; Mon, 17 Jan 2022 12:25:35 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45016) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n9Viz-0004zt-PK for emacs-devel@gnu.org; Mon, 17 Jan 2022 12:23:22 -0500 Original-Received: from [2607:f8b0:4864:20::331] (port=45054 helo=mail-ot1-x331.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n9Vix-00013W-Bg for emacs-devel@gnu.org; Mon, 17 Jan 2022 12:23:21 -0500 Original-Received: by mail-ot1-x331.google.com with SMTP id a10-20020a9d260a000000b005991bd6ae3eso7106032otb.11 for ; Mon, 17 Jan 2022 09:23:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QEdAn0sFp3qnFnaW0dRlfXG3ID8x1A9i5R729lBbmQA=; b=on+YAGwZiG6xlzVXtPDjJOo3Bkn5aVlsp1k8jWRL3+GulJ947lWbvQKIzegXSdf3+/ HGP6AQnD3nhfUwIZCotmRlCgC4i4guNdhIjj7oXSAW3kOrsasDzhWE7X4RMna91nFv5w UbO/DY47M6P18AMParEkVYCNUoVgRN0ZoUnSb1r25OZLAnj9J0zfNaXkZIJ7f6apLcu+ N4V4GaPJVcE7/rS2fs3+HIj9LN/yMDVf/A+GXFSVc6zBezySjwZyngfUSWSVwwYnAW7r EmZKaAv0DqqHxm0EHeCKa6t8DvspQao57xoiuEpShZg0iH5XFwY7n9HvMwXZ6oa7Noxc RsSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QEdAn0sFp3qnFnaW0dRlfXG3ID8x1A9i5R729lBbmQA=; b=JDCjCDJsjwCqINkQtIIDPf7vawZgLhUGweTrG0xg6tKvZJuzSRJd7KXgDCziBjSYPz 89JzHPhLo5AZbTWsBL5uRv25YZ2TjrmsKBQKmPV/7MZokwIQJilMDTahhG6uVv9yyRLW NZZG63rSZs25CcArVJbDDwutcfe5j7GwmGbXMSjGTq6WW42ILKDz441966uiz46WFG0S iAy3jiWeXnjc132/53J/wnLEIA0paVxxeWzzjkrX3FlGuwwS0gXHOXLtiEmZWjip+9cP kDJAWXFtsJPZhZjeyy5Ty54zQiJJaepQl2ZM6Mp8TpunOaV4W0F69AgtB6ZuSKhaFK2I ze+A== X-Gm-Message-State: AOAM5338ZutZ3fFoTjaOIc0hP3gGxhPRfkE9TpaBYZctdGh5+LiqiL/w k1HhxgfhDJRJKENb3rLIFyMEpWrLtYNkDQqAr5Y= X-Google-Smtp-Source: ABdhPJxz/b5NRn2JN5l4eCtBt7HOfyqOwkz/hIJTV2WLYLJLKJLU/NpuWp+j+yh14BdVR7dPXBeqm+8bRzolWLA0ESA= X-Received: by 2002:a9d:53c6:: with SMTP id i6mr17307532oth.96.1642440198223; Mon, 17 Jan 2022 09:23:18 -0800 (PST) In-Reply-To: <87h7a2qy73.fsf@gmail.com> X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::331 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::331; envelope-from=p.stephani2@gmail.com; helo=mail-ot1-x331.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284885 Archived-At: Am Mo., 17. Jan. 2022 um 15:27 Uhr schrieb Robert Pluim : > > >>>>> On Fri, 14 Jan 2022 15:03:16 -0500 (EST), Philipp Stephani said: > > Philipp> branch: master > Philipp> commit 64109fcae710a372bf7690e2da461ab71ca78dcd > Philipp> Author: Philipp Stephani > Philipp> Commit: Philipp Stephani > > Philipp> indent-for-tab-command: Deal with large point or modiff values. > > Philipp> * lisp/indent.el (indent-for-tab-command): Don't use 'eq' to compare > Philipp> integers that aren't guaranteed to be fixnums. > Philipp> --- > Philipp> lisp/indent.el | 4 ++-- > Philipp> 1 file changed, 2 insertions(+), 2 deletions(-) > > Philipp> diff --git a/lisp/indent.el b/lisp/indent.el > Philipp> index 8dc4c31f13..ad6fd899c5 100644 > Philipp> --- a/lisp/indent.el > Philipp> +++ b/lisp/indent.el > Philipp> @@ -182,8 +182,8 @@ prefix argument is ignored." > Philipp> (cond > Philipp> ;; If the text was already indented right, try completion. > Philipp> ((and (eq tab-always-indent 'complete) > Philipp> - (eq old-point (point)) > Philipp> - (eq old-tick (buffer-chars-modified-tick)) > Philipp> + (eql old-point (point)) > Philipp> + (eql old-tick (buffer-chars-modified-tick)) > Philipp> (or (null tab-first-completion) > Philipp> (eq last-command this-command) > Philipp> (and (equal tab-first-completion 'eol) > > You could use '=' here, no, just to emphasise the point that these are integers? Yeah, they have identical semantics for integers. I tend to prefer eql since its overall semantics are simpler (but the manual disagrees and says that = should be preferred).