From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: Dynamic loading progress Date: Fri, 20 Nov 2015 22:46:31 +0000 Message-ID: References: <8737wgw7kf.fsf@lifelogs.com> <87io5bv1it.fsf@lifelogs.com> <87egfzuwca.fsf@lifelogs.com> <876118u6f2.fsf@lifelogs.com> <8737w3qero.fsf@lifelogs.com> <831tbn9g9j.fsf@gnu.org> <878u5upw7o.fsf@lifelogs.com> <83ziya8xph.fsf@gnu.org> <83y4du80xo.fsf@gnu.org> <837fld6lps.fsf@gnu.org> <83r3jk6fw6.fsf@gnu.org> <83k2pc6537.fsf@gnu.org> <564F84E5.2050801@cs.ucla.edu> <837flc5ptb.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a1148eec6237ce4052500a69d X-Trace: ger.gmane.org 1448059627 1277 80.91.229.3 (20 Nov 2015 22:47:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 20 Nov 2015 22:47:07 +0000 (UTC) Cc: aurelien.aptel+emacs@gmail.com, tzz@lifelogs.com, emacs-devel@gnu.org To: Eli Zaretskii , Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 20 23:47:06 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZzuSN-0000mf-PS for ged-emacs-devel@m.gmane.org; Fri, 20 Nov 2015 23:47:04 +0100 Original-Received: from localhost ([::1]:50225 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzuSN-0002BH-8l for ged-emacs-devel@m.gmane.org; Fri, 20 Nov 2015 17:47:03 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37484) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzuS4-0002AY-WD for emacs-devel@gnu.org; Fri, 20 Nov 2015 17:46:46 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZzuS3-0007Ui-PK for emacs-devel@gnu.org; Fri, 20 Nov 2015 17:46:44 -0500 Original-Received: from mail-wm0-x22e.google.com ([2a00:1450:400c:c09::22e]:33558) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzuS1-0007UP-Ka; Fri, 20 Nov 2015 17:46:41 -0500 Original-Received: by wmec201 with SMTP id c201so91448970wme.0; Fri, 20 Nov 2015 14:46:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-type; bh=QMWG5/oVxweFtl7GsgMDFF3ob+S9DTB13rzSZ61FWPg=; b=dIJi9WKwIrEHB/ERAwRoA9/E4Xd5+lfcVC1hq8QPAPz10eCqKSKiNFCfYdKTv4/jp+ ZJ7jY2Qa5OLIz33QE/jn65irti2CUsosHJDGi8srAQYMg0NMitsfMTs/SSg3kjOYTYlN mtcancFCRjQe47z8TCY5r7vVXimFfq1QCFWLvOTe9ltQ7c8bD2+sSnVCxVcyGfPuCyP0 uIWRmcY17ZNpRR/3TJ0GRwNvJslwv67fZGG7Fu9WbKVIOJDqaj7VIhYo55nfZZD/P1TG Zsj5QHi2zTccUgAnOQgfYCds0vTDwNoEgwu54RIg4eSegwLsqUgZlxcCppzfaT6kUW5q h5rw== X-Received: by 10.28.97.197 with SMTP id v188mr5175322wmb.63.1448059601122; Fri, 20 Nov 2015 14:46:41 -0800 (PST) In-Reply-To: <837flc5ptb.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c09::22e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:194909 Archived-At: --001a1148eec6237ce4052500a69d Content-Type: text/plain; charset=UTF-8 Eli Zaretskii schrieb am Fr., 20. Nov. 2015 um 22:22 Uhr: > > Cc: p.stephani2@gmail.com, aurelien.aptel+emacs@gmail.com, > tzz@lifelogs.com, > > emacs-devel@gnu.org > > From: Paul Eggert > > Date: Fri, 20 Nov 2015 12:39:01 -0800 > > > > Eli Zaretskii wrote: > > > I suspect the push_handlers changes in aa7dac8. > > > > No, it was the reindenting change! I got confused by the do-while > indenting in a > > complicated macro. Fixed in commit > 95f69f2c5999be4b9444861b6d4ae1bd3ab87f83. > > Thanks, the tests now pass here as well. > > > I didn't notice all these problems because I wasn't running that test. > I was > > just doing 'make check'. Philipp, shouldn't mod-test.c part of 'make > check', > > when Emacs is configured --with-modules? Also, shouldn't the mod-test.c > Makefile > > use the same GCC warning flags etc. that everyone else does? That would > help > > catch these bugs better. > > Yes, on both counts. It's a matter of time to settle all that, > though. > Absolutely! The tests should be no different from any other tests. There is https://github.com/aaptel/emacs-dynamic-module/issues/34, but we haven't gotten around to it yet. --001a1148eec6237ce4052500a69d Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


Eli Za= retskii <eliz@gnu.org> schrieb am= Fr., 20. Nov. 2015 um 22:22=C2=A0Uhr:
> Cc: p.s= tephani2@gmail.com, aurelien.aptel+emacs@gmail.com, tzz@lifelogs.com,
>=C2=A0 emacs-d= evel@gnu.org
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Fri, 20 Nov 2015 12:39:01 -0800
>
> Eli Zaretskii wrote:
> > I suspect the push_handlers changes in aa7dac8.
>
> No, it was the reindenting change! I got confused by the do-while inde= nting in a
> complicated macro. Fixed in commit 95f69f2c5999be4b9444861b6d4ae1bd3ab= 87f83.

Thanks, the tests now pass here as well.

> I didn't notice all these problems because I wasn't running th= at test.=C2=A0 I was
> just doing 'make check'. Philipp, shouldn't mod-test.c par= t of 'make check',
> when Emacs is configured --with-modules? Also, shouldn't the mod-t= est.c Makefile
> use the same GCC warning flags etc. that everyone else does?=C2=A0 Tha= t would help
> catch these bugs better.

Yes, on both counts.=C2=A0 It's a matter of time to settle all that, though.

Absolutely! The tests should be= no different from any other tests. There is https://github.com/aaptel/emacs-dyna= mic-module/issues/34, but we haven't gotten around to it yet.=C2=A0=
--001a1148eec6237ce4052500a69d--