Eli Zaretskii schrieb am Fr., 20. Nov. 2015 um 22:22 Uhr: > > Cc: p.stephani2@gmail.com, aurelien.aptel+emacs@gmail.com, > tzz@lifelogs.com, > > emacs-devel@gnu.org > > From: Paul Eggert > > Date: Fri, 20 Nov 2015 12:39:01 -0800 > > > > Eli Zaretskii wrote: > > > I suspect the push_handlers changes in aa7dac8. > > > > No, it was the reindenting change! I got confused by the do-while > indenting in a > > complicated macro. Fixed in commit > 95f69f2c5999be4b9444861b6d4ae1bd3ab87f83. > > Thanks, the tests now pass here as well. > > > I didn't notice all these problems because I wasn't running that test. > I was > > just doing 'make check'. Philipp, shouldn't mod-test.c part of 'make > check', > > when Emacs is configured --with-modules? Also, shouldn't the mod-test.c > Makefile > > use the same GCC warning flags etc. that everyone else does? That would > help > > catch these bugs better. > > Yes, on both counts. It's a matter of time to settle all that, > though. > Absolutely! The tests should be no different from any other tests. There is https://github.com/aaptel/emacs-dynamic-module/issues/34, but we haven't gotten around to it yet.