From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: JSON/YAML/TOML/etc. parsing performance Date: Tue, 03 Oct 2017 12:12:05 +0000 Message-ID: References: <87poaqhc63.fsf@lifelogs.com> <8360ceh5f1.fsf@gnu.org> <83h8vl5lf9.fsf@gnu.org> <83mv5a3e91.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a11448750ebec9e055aa366bb" X-Trace: blaine.gmane.org 1507032800 931 195.159.176.226 (3 Oct 2017 12:13:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 3 Oct 2017 12:13:20 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 03 14:12:59 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzM4H-0006lN-Ct for ged-emacs-devel@m.gmane.org; Tue, 03 Oct 2017 14:12:57 +0200 Original-Received: from localhost ([::1]:58288 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dzM4L-0000bK-GF for ged-emacs-devel@m.gmane.org; Tue, 03 Oct 2017 08:13:01 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41045) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dzM3g-0000ZZ-K0 for emacs-devel@gnu.org; Tue, 03 Oct 2017 08:12:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dzM3f-0000x0-Ao for emacs-devel@gnu.org; Tue, 03 Oct 2017 08:12:20 -0400 Original-Received: from mail-oi0-x230.google.com ([2607:f8b0:4003:c06::230]:54958) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dzM3d-0000uq-Ox; Tue, 03 Oct 2017 08:12:17 -0400 Original-Received: by mail-oi0-x230.google.com with SMTP id u130so13870369oib.11; Tue, 03 Oct 2017 05:12:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5CUps83/LUOdPPm3RAfsCCftu36l/QRxbh1I6NzCMWI=; b=NnJIiIqvfULWIy0kIlnz0ZKbenwhYLS4VvAWEDVYW621/OTOK3obRkhFyhqMpRbLMP pWsk1vQv0PH9v6Ka393F4qu7QMa+qRyLwKcXBvQjuQpCLXBLAOPc4tnBDmgmRKX5jH4b lMQT158ksRIUMc3Qrvuho3P+k5RLTGOzE8LoJIWwAh9eKjwzGS4iNq/iJUAUZsSRkhdn uljdXqdQp0aiPpVGLsVP1iSwgpEFFjk7fwgcMTPZV/w/5egdmBUulkwsBYodo9TaYE4U r9w55wwE8YVL7XuPfJyVPiW8r4THj5YuJhvsg5z9DOhM+924agh2KR748Ci+Z1T1qHrA 24Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5CUps83/LUOdPPm3RAfsCCftu36l/QRxbh1I6NzCMWI=; b=ljdyMxjC+K+IZBUCQBnfk0Db/WukbPwIQZP2spjpJw2HW3n1NnCXeoFyoDSMHI+W10 vDIgROCticFH4qHWAMpZ/9HgwW2PkGIRlZIHoGNcvlD53OXSbmzl7VxFmBGZbmC5gGGi osoq5wXQ6Qa8rizHP8SPKVO+HiPhpEcqUdEikVL+XDudg8ej2SB7egO2nxLMovVQsnvO T7mSkVeFf6RidFCLiOk3OO6dV2AGzl+re1am7Q8yeyUyT5buPYlMa1UH4wLoXSZ7SSLG 2hx2nDtVoii9W9a5MMMa9/3k3dy0RJipYfl3/kH8Yly8wj1ag8z6+6TECcaj8O/pEFum NyEw== X-Gm-Message-State: AMCzsaWGSg8fYyqzWxz5JJ92PEgdK1MVMesVQRvY5/Npf7X+PiJVeW3m bSzuNmnVYjb0R5CSTf1XURQCw0gFATIEHo8N69JHsw== X-Google-Smtp-Source: AOwi7QAOhBiHAM4xKlgsf/vifUvGWTRlyk+mTfUcCMOuLB8S4DkbWst+gdHmxgyY2uiNC/sW8+hD0+JgZ065xxkQvgY= X-Received: by 10.202.208.193 with SMTP id j62mr1126507oiy.268.1507032736458; Tue, 03 Oct 2017 05:12:16 -0700 (PDT) In-Reply-To: <83mv5a3e91.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c06::230 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:219027 Archived-At: --001a11448750ebec9e055aa366bb Content-Type: text/plain; charset="UTF-8" Eli Zaretskii schrieb am So., 1. Okt. 2017 um 20:38 Uhr: > > From: Philipp Stephani > > Date: Sat, 30 Sep 2017 22:02:55 +0000 > > Cc: emacs-devel@gnu.org > > One more comment: > > > +static Lisp_Object > > +json_insert (void *data) > > +{ > > + const struct json_buffer_and_size *buffer_and_size = data; > > + if (buffer_and_size->size > PTRDIFF_MAX) > > + xsignal1 (Qoverflow_error, build_string ("buffer too large")); > > + insert (buffer_and_size->buffer, buffer_and_size->size); > > + return Qnil; > > Shouldn't we follow the call to 'insert' with decode_from_gap, or do > it before json_insert_callback returns? Or do we trust Jansson to > produce 100% valid UTF-8? > > What's decode_from_gap? It doesn't seem to be defined in the Emacs code base. --001a11448750ebec9e055aa366bb Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Eli Za= retskii <eliz@gnu.org> schrieb am= So., 1. Okt. 2017 um 20:38=C2=A0Uhr:
> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Sat, 30 Sep 2017 22:02:55 +0000
> Cc: emacs-dev= el@gnu.org

One more comment:

> +static Lisp_Object
> +json_insert (void *data)
> +{
> +=C2=A0 const struct json_buffer_and_size *buffer_and_size =3D data; > +=C2=A0 if (buffer_and_size->size > PTRDIFF_MAX)
> +=C2=A0 =C2=A0 xsignal1 (Qoverflow_error, build_string ("buffer t= oo large"));
> +=C2=A0 insert (buffer_and_size->buffer, buffer_and_size->size);=
> +=C2=A0 return Qnil;

Shouldn't we follow the call to 'insert' with decode_from_gap, = or do
it before json_insert_callback returns?=C2=A0 Or do we trust Jansson to
produce 100% valid UTF-8?


What's decode_from_gap? It doesn&#= 39;t seem to be defined in the Emacs code base.=C2=A0
--001a11448750ebec9e055aa366bb--