From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: san_ignore_object not found at link time Date: Sat, 1 Aug 2020 21:40:02 +0200 Message-ID: References: <20200801141014.51E78C21C82@raman-glaptop.localdomain> <83wo2ictyz.fsf@gnu.org> <83tuxmctmo.fsf@gnu.org> <20200801153823.GA55369@breton.holly.idiocy.org> <83k0yicl01.fsf@gnu.org> <83h7tmcj45.fsf@gnu.org> <83eeoqcguj.fsf@gnu.org> <83d04acgmj.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10634"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Alan Third , raman , Emacs developers To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Aug 01 21:40:51 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k1xNC-0002hB-Ow for ged-emacs-devel@m.gmane-mx.org; Sat, 01 Aug 2020 21:40:50 +0200 Original-Received: from localhost ([::1]:34622 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k1xNB-0005zx-QV for ged-emacs-devel@m.gmane-mx.org; Sat, 01 Aug 2020 15:40:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54662) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k1xMf-0005Ur-Le for emacs-devel@gnu.org; Sat, 01 Aug 2020 15:40:18 -0400 Original-Received: from mail-oi1-x22c.google.com ([2607:f8b0:4864:20::22c]:36644) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k1xMd-0007wC-SP; Sat, 01 Aug 2020 15:40:17 -0400 Original-Received: by mail-oi1-x22c.google.com with SMTP id l204so1078310oib.3; Sat, 01 Aug 2020 12:40:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=03RwTqUKW4QGpysgwsFoRKWUltlK2AUGlowfE3CpUYE=; b=VitvF2mJKN4qN6NPo4WzzabavvnRCDEkFaAm7I6qqfqj73wAirV+yndOL2PgYmsECq du3ZFCIiihU+o0pNtZOBR9jm+AWxTYX73gArwrDeoMyZ2Cswb6keuHLzmxxJ3f2QMVSZ H7+rsj3/5/s+NMZ39XeBPFnnIeJNFjF6ssEGQ/rjQFU+OjW4aeW3FGR1JHBQbU2PLWu1 F1gDLeKi+iyenKicCkD9rG1GJaJ2mGyS9uCeJxkQ7Kj0tgbHFF7omaEQQCzcglsCUnnr PTpMAnUb1QIx3tLs0JcF1orL+dnFk735cZI8fc+tP73M1uRzpzgGFi1ldwXOpnalbA55 6Hhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=03RwTqUKW4QGpysgwsFoRKWUltlK2AUGlowfE3CpUYE=; b=UW/Ivn4et42bi40Gjo6IUqlg719PMHu/bbaaXVklXfJoCuPtQXIbppBr3nApTNPiMY qifSsvNKZE1JulbpCrlzesVww6uEsps0qo9vIHD2Hq+35iRRzgC7OnXOZ5L8Hqkd3DRr YjnepeLLhHcpFsVCzvwMYeTwDpvl3UMrqcBjvrbaFCWSKHNl7KcPTNoYiXJnIJzrllQI GcyRlVVWggIb9ILxwgk2ZJgl3+cOUDLjSsFSYQvk4Kkn8CuVqG9aoKlmnB0dIfG1V8Xq GxcI9Qzugetqoc0jU/iWnlCx0VK9m3ErEicReSlC4PRg7tUonJq8WoBFIIv+TaXWgoQ5 l0Jw== X-Gm-Message-State: AOAM5324C9uLPMOjmcY19zb6b7m1vtyV/KbIi7Yyc4BlJ4EPLWI8mi8U fbHVqMh9yhYtY7Ue8cNG+AXWR8ktXTqnkrSLJkz+vg== X-Google-Smtp-Source: ABdhPJx9qihpYtOkODGg/9K9uawnS/dC2B2PfoGsEtBHUy0vUKpzbpiY11lYP1h5evdK9ExMUoK/6uVK/pWrjNvvBCY= X-Received: by 2002:aca:2101:: with SMTP id 1mr7651426oiz.170.1596310813524; Sat, 01 Aug 2020 12:40:13 -0700 (PDT) In-Reply-To: <83d04acgmj.fsf@gnu.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::22c; envelope-from=p.stephani2@gmail.com; helo=mail-oi1-x22c.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:253397 Archived-At: Am Sa., 1. Aug. 2020 um 21:26 Uhr schrieb Eli Zaretskii : > > > Date: Sat, 01 Aug 2020 22:21:24 +0300 > > From: Eli Zaretskii > > Cc: alan@idiocy.org, emacs-devel@gnu.org, raman@google.com > > > > > From: Philipp Stephani > > > Date: Sat, 1 Aug 2020 21:17:05 +0200 > > > Cc: Alan Third , raman , > > > Emacs developers > > > > > > I've now used INT_SUBTRACT_WRAPV, which should guarantee that the > > > offset is defined and fits within an intptr_t. > > > > Thanks, the warning is gone now. Though I still don't like the code > > there, it feels wrong even if it isn't. > > I spoke too soon: it compiles, but that hits assertion violation while > loading: Yeah, that's what I feared. I've now made the assertion conditional. It might be cleaner to rewrite that function to explicitly check for all known tag types: void *po; switch (type_tag) { case Lisp_Symbol: po = XSYMBOL (obj); break; ... } That way, the pointer arithmetic would be centralized in XUNTAG and XSYMBOL.