From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: Dynamic loading progress Date: Sun, 22 Nov 2015 17:27:11 +0000 Message-ID: References: <876118u6f2.fsf@lifelogs.com> <8737w3qero.fsf@lifelogs.com> <831tbn9g9j.fsf@gnu.org> <878u5upw7o.fsf@lifelogs.com> <83ziya8xph.fsf@gnu.org> <83y4du80xo.fsf@gnu.org> <837fld6lps.fsf@gnu.org> <83610w5o97.fsf@gnu.org> <564FACF5.2080601@cs.ucla.edu> <564FBAA7.5030306@cs.ucla.edu> <5650F9CD.9030707@cs.ucla.edu> <83oaem2ebu.fsf@gnu.org> <83mvu62cst.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a114450c8d88d9c0525246bc7 X-Trace: ger.gmane.org 1448213267 13484 80.91.229.3 (22 Nov 2015 17:27:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 22 Nov 2015 17:27:47 +0000 (UTC) Cc: aurelien.aptel+emacs@gmail.com, tzz@lifelogs.com, eggert@cs.ucla.edu, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 22 18:27:41 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a0YQF-0002fQ-8v for ged-emacs-devel@m.gmane.org; Sun, 22 Nov 2015 18:27:31 +0100 Original-Received: from localhost ([::1]:56879 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0YQF-0006HI-4a for ged-emacs-devel@m.gmane.org; Sun, 22 Nov 2015 12:27:31 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38395) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0YQ9-0006GW-ID for emacs-devel@gnu.org; Sun, 22 Nov 2015 12:27:26 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a0YQ8-0005e8-N8 for emacs-devel@gnu.org; Sun, 22 Nov 2015 12:27:25 -0500 Original-Received: from mail-wm0-x22b.google.com ([2a00:1450:400c:c09::22b]:36910) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0YQ6-0005dc-D5; Sun, 22 Nov 2015 12:27:22 -0500 Original-Received: by wmww144 with SMTP id w144so78026547wmw.0; Sun, 22 Nov 2015 09:27:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-type; bh=KcsTyhZucqu5hUFZ06ERmHfQwD91rXCMpz8XLsJqWGo=; b=oW5GT9N64wotMECTnuBINPadZw8PFIdMvPkfm7sXz+Fu0SCAsM6g2J5hsqdCYkxnQf OopE1kplWGNfPtm4D8l1mal4OH0o36GYKJiUHvY+I7GHumU+mOW3o7KKzarV0rwvrJRJ TKHxD+hNGHy8SEkqN8rNvtza5XEIuPg42Cpl7y3dvRyvYrf/dvky2wlZteLXbE4Uos9q Ah6wtTeQqfrMZtpMDjG6LoFBnK1AA93BWHVZm1RjaAeaSaMTFljUXoGwC5TZ2sHCMoBz e+AaJxE8ijt4WOW9KVGE0hZGCCuadj90/M/MISHs5mMW8Q/YvJGEJuKAhd9pAiQc0R/w sZxw== X-Received: by 10.28.7.8 with SMTP id 8mr13391775wmh.45.1448213241807; Sun, 22 Nov 2015 09:27:21 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c09::22b X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:195042 Archived-At: --001a114450c8d88d9c0525246bc7 Content-Type: multipart/alternative; boundary=001a114450c8d88d980525246bc5 --001a114450c8d88d980525246bc5 Content-Type: text/plain; charset=UTF-8 Another one containing changelog entries. Philipp Stephani schrieb am So., 22. Nov. 2015 um 18:18 Uhr: > Eli Zaretskii schrieb am So., 22. Nov. 2015 um 17:56 Uhr: > >> > From: Philipp Stephani >> > Date: Sun, 22 Nov 2015 16:27:19 +0000 >> > Cc: eggert@cs.ucla.edu, aurelien.aptel+emacs@gmail.com, >> tzz@lifelogs.com, >> > emacs-devel@gnu.org >> > >> > Eli Zaretskii schrieb am So., 22. Nov. 2015 um 17:23 >> Uhr: >> > >> > I don't understand: we already have in emacs-module.c machinery that >> > handles non-local exits. Why cannot xmalloc do the same when it's >> > called from emacs-module.c? >> > >> > My impression was that Paul talked about code in modules, not code in >> > emacs-module.c. The latter can use xmalloc just fine, if appropriate >> protection >> > is installed first. >> >> I'll let Paul explain what he was worried about. What I was worried >> about is that memory allocation done by emacs-module.c on behalf of >> modules doesn't behave like xmalloc does, doesn't comply to the >> MALLOC_BLOCK_INPUT protocol, and cannot be probed by MALLOC_PROBE. I >> think this should be easy to fix. >> >> > Yes, I've attached a patch. > --001a114450c8d88d980525246bc5 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Another one containing changelog entries.

Philipp Stephani <p.stephani2@gmail.com> schrieb am So., 22. Nov= . 2015 um 18:18=C2=A0Uhr:
Eli Zaretskii <eliz@gnu.org> schrieb = am So., 22. Nov. 2015 um 17:56=C2=A0Uhr:
> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Sun, 22 Nov 2015 16:27:19 +0000
> Cc: eggert@cs.= ucla.edu, aurelien.aptel+emacs@gmail.com, tzz@lifelogs.com,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0emacs-devel@gnu.org
>
> Eli Zaretskii <el= iz@gnu.org> schrieb am So., 22. Nov. 2015 um 17:23 Uhr:
>
>=C2=A0 =C2=A0 =C2=A0I don't understand: we already have in emacs-mo= dule.c machinery that
>=C2=A0 =C2=A0 =C2=A0handles non-local exits. Why cannot xmalloc do the = same when it's
>=C2=A0 =C2=A0 =C2=A0called from emacs-module.c?
>
> My impression was that Paul talked about code in modules, not code in<= br> > emacs-module.c. The latter can use xmalloc just fine, if appropriate p= rotection
> is installed first.

I'll let Paul explain what he was worried about.=C2=A0 What I was worri= ed
about is that memory allocation done by emacs-module.c on behalf of
modules doesn't behave like xmalloc does, doesn't comply to the
MALLOC_BLOCK_INPUT protocol, and cannot be probed by MALLOC_PROBE.=C2=A0 I<= br> think this should be easy to fix.


Yes, I've attached a patch.=C2=A0
--001a114450c8d88d980525246bc5-- --001a114450c8d88d9c0525246bc7 Content-Type: application/octet-stream; name="0001-Use-xmalloc-in-module-code.patch" Content-Disposition: attachment; filename="0001-Use-xmalloc-in-module-code.patch" Content-Transfer-Encoding: base64 Content-ID: <151303c2fb9fadbb99f1> X-Attachment-Id: 151303c2fb9fadbb99f1 RnJvbSA4MWI3MTFhYWYwZDk2N2Y3YzIwY2U4NDUzYWZiMGNmYmVmNWU1OGU1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwIFN0ZXBoYW5pIDxwaHN0QGdvb2dsZS5jb20+CkRh dGU6IFN1biwgMjIgTm92IDIwMTUgMTg6MTQ6MjIgKzAxMDAKU3ViamVjdDogW1BBVENIXSBVc2Ug eG1hbGxvYyBpbiBtb2R1bGUgY29kZQoKKiBlbWFjcy1tb2R1bGUuYyAoYWxsb2NhdGVfZW1hY3Nf dmFsdWUpOiBVc2UgeG1hbGxvYyBpbnN0ZWFkIG9mIG1hbGxvYy4KKG1vZHVsZV90eXBlX29mLCBt b2R1bGVfbWFrZV9pbnRlZ2VyKTogQ2F0Y2ggc2lnbmFscy4KKGxpc3BfdG9fdmFsdWUsIG1vZHVs ZV9tYWtlX2dsb2JhbF9yZWYpOiBBZGFwdCB0byBjaGFuZ2VkIGludGVyZmFjZS4KLS0tCiBzcmMv ZW1hY3MtbW9kdWxlLmMgfCAzMSArKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tCiAxIGZp bGUgY2hhbmdlZCwgMTYgaW5zZXJ0aW9ucygrKSwgMTUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0 IGEvc3JjL2VtYWNzLW1vZHVsZS5jIGIvc3JjL2VtYWNzLW1vZHVsZS5jCmluZGV4IDg0MDcyYjku Ljg3MDUyODAgMTAwNjQ0Ci0tLSBhL3NyYy9lbWFjcy1tb2R1bGUuYworKysgYi9zcmMvZW1hY3Mt bW9kdWxlLmMKQEAgLTEzNiw3ICsxMzYsNyBAQCBzdHJ1Y3QgbW9kdWxlX2Z1bl9lbnY7CiAKIHN0 YXRpYyBMaXNwX09iamVjdCBtb2R1bGVfZm9ybWF0X2Z1bl9lbnYgKGNvbnN0IHN0cnVjdCBtb2R1 bGVfZnVuX2VudiAqKTsKIHN0YXRpYyBMaXNwX09iamVjdCB2YWx1ZV90b19saXNwIChlbWFjc192 YWx1ZSk7Ci1zdGF0aWMgZW1hY3NfdmFsdWUgYWxsb2NhdGVfZW1hY3NfdmFsdWUgKGVtYWNzX2Vu diAqLCBzdHJ1Y3QgZW1hY3NfdmFsdWVfc3RvcmFnZSAqLCBMaXNwX09iamVjdCk7CitzdGF0aWMg ZW1hY3NfdmFsdWUgYWxsb2NhdGVfZW1hY3NfdmFsdWUgKHN0cnVjdCBlbWFjc192YWx1ZV9zdG9y YWdlICosIExpc3BfT2JqZWN0KTsKIHN0YXRpYyBlbWFjc192YWx1ZSBsaXNwX3RvX3ZhbHVlIChl bWFjc19lbnYgKiwgTGlzcF9PYmplY3QpOwogc3RhdGljIGVudW0gZW1hY3NfZnVuY2FsbF9leGl0 IG1vZHVsZV9ub25fbG9jYWxfZXhpdF9jaGVjayAoZW1hY3NfZW52ICopOwogc3RhdGljIHZvaWQg Y2hlY2tfbWFpbl90aHJlYWQgKHZvaWQpOwpAQCAtMjg0LDcgKzI4NCw3IEBAIG1vZHVsZV9tYWtl X2dsb2JhbF9yZWYgKGVtYWNzX2VudiAqZW52LCBlbWFjc192YWx1ZSByZWYpCiAgICAgICBoYXNo X3B1dCAoaCwgbmV3X29iaiwgbWFrZV9uYXRudW0gKDEpLCBoYXNoY29kZSk7CiAgICAgfQogCi0g IHJldHVybiBhbGxvY2F0ZV9lbWFjc192YWx1ZSAoZW52LCAmZ2xvYmFsX3N0b3JhZ2UsIG5ld19v YmopOworICByZXR1cm4gYWxsb2NhdGVfZW1hY3NfdmFsdWUgKCZnbG9iYWxfc3RvcmFnZSwgbmV3 X29iaik7CiB9CiAKIHN0YXRpYyB2b2lkCkBAIC00NDAsNiArNDQwLDcgQEAgbW9kdWxlX3R5cGVf b2YgKGVtYWNzX2VudiAqZW52LCBlbWFjc192YWx1ZSB2YWx1ZSkKIHsKICAgY2hlY2tfbWFpbl90 aHJlYWQgKCk7CiAgIGVhc3NlcnQgKG1vZHVsZV9ub25fbG9jYWxfZXhpdF9jaGVjayAoZW52KSA9 PSBlbWFjc19mdW5jYWxsX2V4aXRfcmV0dXJuKTsKKyAgTU9EVUxFX0hBTkRMRV9TSUdOQUxTOwog ICByZXR1cm4gbGlzcF90b192YWx1ZSAoZW52LCBGdHlwZV9vZiAodmFsdWVfdG9fbGlzcCAodmFs dWUpKSk7CiB9CiAKQEAgLTQ3OCw2ICs0NzksNyBAQCBtb2R1bGVfbWFrZV9pbnRlZ2VyIChlbWFj c19lbnYgKmVudiwgaW50bWF4X3QgbikKIHsKICAgY2hlY2tfbWFpbl90aHJlYWQgKCk7CiAgIGVh c3NlcnQgKG1vZHVsZV9ub25fbG9jYWxfZXhpdF9jaGVjayAoZW52KSA9PSBlbWFjc19mdW5jYWxs X2V4aXRfcmV0dXJuKTsKKyAgTU9EVUxFX0hBTkRMRV9TSUdOQUxTOwogICBpZiAoISAoTU9TVF9O RUdBVElWRV9GSVhOVU0gPD0gbiAmJiBuIDw9IE1PU1RfUE9TSVRJVkVfRklYTlVNKSkKICAgICB7 CiAgICAgICBtb2R1bGVfbm9uX2xvY2FsX2V4aXRfc2lnbmFsXzEgKGVudiwgUW92ZXJmbG93X2Vy cm9yLCBRbmlsKTsKQEAgLTg1MCwxOCArODUyLDIxIEBAIG1vZHVsZV9hcmdzX291dF9vZl9yYW5n ZSAoZW1hY3NfZW52ICplbnYsIExpc3BfT2JqZWN0IGExLCBMaXNwX09iamVjdCBhMikKIHN0YXRp YyBMaXNwX09iamVjdAogdmFsdWVfdG9fbGlzcCAoZW1hY3NfdmFsdWUgdikKIHsKKyAgZWFzc2Vy dCAodiAhPSBOVUxMKTsKICAgcmV0dXJuIHYtPnY7CiB9CiAKIC8qIENvbnZlcnQgYW4gaW50ZXJu YWwgb2JqZWN0IHRvIGFuIGBlbWFjc192YWx1ZScuICBBbGxvY2F0ZSBzdG9yYWdlCi0gICBmcm9t IHRoZSBlbnZpcm9ubWVudDsgcmV0dXJuIE5VTEwgaWYgYWxsb2NhdGlvbiBmYWlscy4gICovCisg ICBmcm9tIHRoZSBlbnZpcm9ubWVudDsgcmFpc2UgYSBzaWduYWwgaWYgYWxsb2NhdGlvbiBmYWls cy4gICovCiBzdGF0aWMgZW1hY3NfdmFsdWUKIGxpc3BfdG9fdmFsdWUgKGVtYWNzX2VudiAqZW52 LCBMaXNwX09iamVjdCBvKQogeworICBlYXNzZXJ0IChlbnYgIT0gTlVMTCk7CiAgIHN0cnVjdCBl bWFjc19lbnZfcHJpdmF0ZSAqcCA9IGVudi0+cHJpdmF0ZV9tZW1iZXJzOworICAvLyBUT0RPOiBS ZW1vdmUgdGhlIG5leHQgc3RhdGVtZW50LgogICBpZiAocC0+cGVuZGluZ19ub25fbG9jYWxfZXhp dCAhPSBlbWFjc19mdW5jYWxsX2V4aXRfcmV0dXJuKQogICAgIHJldHVybiBOVUxMOwotICByZXR1 cm4gYWxsb2NhdGVfZW1hY3NfdmFsdWUgKGVudiwgJnAtPnN0b3JhZ2UsIG8pOworICByZXR1cm4g YWxsb2NhdGVfZW1hY3NfdmFsdWUgKCZwLT5zdG9yYWdlLCBvKTsKIH0KIAogDApAQCAtODk4LDIz ICs5MDMsMTkgQEAgZmluYWxpemVfc3RvcmFnZSAoc3RydWN0IGVtYWNzX3ZhbHVlX3N0b3JhZ2Ug KnN0b3JhZ2UpCiAgICAgfQogfQogCi0vKiBBbGxvY2F0ZSBhIG5ldyB2YWx1ZSBmcm9tIFNUT1JB R0UgYW5kIHN0b3JlcyBPQkogaW4gaXQuICBSZXR1cm4KLSAgIE5VTEwgaWYgYWxsb2NhdGlvbnMg ZmFpbHMgYW5kIHVzZSBFTlYgZm9yIG5vbiBsb2NhbCBleGl0IHJlcG9ydGluZy4gICovCisvKiBB bGxvY2F0ZSBhIG5ldyB2YWx1ZSBmcm9tIFNUT1JBR0UgYW5kIHN0b3JlcyBPQkogaW4gaXQuICBT aWduYWwgYW4KKyAgIGVycm9yIGlmIGFsbG9jYXRpb24gZmFpbHMuICAqLwogc3RhdGljIGVtYWNz X3ZhbHVlCi1hbGxvY2F0ZV9lbWFjc192YWx1ZSAoZW1hY3NfZW52ICplbnYsIHN0cnVjdCBlbWFj c192YWx1ZV9zdG9yYWdlICpzdG9yYWdlLAorYWxsb2NhdGVfZW1hY3NfdmFsdWUgKHN0cnVjdCBl bWFjc192YWx1ZV9zdG9yYWdlICpzdG9yYWdlLAogCQkgICAgICBMaXNwX09iamVjdCBvYmopCiB7 Ci0gIGVhc3NlcnQgKHN0b3JhZ2UtPmN1cnJlbnQpOworICBlYXNzZXJ0IChzdG9yYWdlICE9IE5V TEwpOworICBlYXNzZXJ0IChzdG9yYWdlLT5jdXJyZW50ICE9IE5VTEwpOwogICBlYXNzZXJ0IChz dG9yYWdlLT5jdXJyZW50LT5vZmZzZXQgPCB2YWx1ZV9mcmFtZV9zaXplKTsKLSAgZWFzc2VydCAo ISBzdG9yYWdlLT5jdXJyZW50LT5uZXh0KTsKKyAgZWFzc2VydCAoc3RvcmFnZS0+Y3VycmVudC0+ bmV4dCA9PSBOVUxMKTsKICAgaWYgKHN0b3JhZ2UtPmN1cnJlbnQtPm9mZnNldCA9PSB2YWx1ZV9m cmFtZV9zaXplIC0gMSkKICAgICB7Ci0gICAgICBzdG9yYWdlLT5jdXJyZW50LT5uZXh0ID0gbWFs bG9jIChzaXplb2YgKnN0b3JhZ2UtPmN1cnJlbnQtPm5leHQpOwotICAgICAgaWYgKCEgc3RvcmFn ZS0+Y3VycmVudC0+bmV4dCkKLSAgICAgICAgewotICAgICAgICAgIG1vZHVsZV9vdXRfb2ZfbWVt b3J5IChlbnYpOwotICAgICAgICAgIHJldHVybiBOVUxMOwotICAgICAgICB9CisgICAgICBzdG9y YWdlLT5jdXJyZW50LT5uZXh0ID0geG1hbGxvYyAoc2l6ZW9mICpzdG9yYWdlLT5jdXJyZW50LT5u ZXh0KTsKICAgICAgIGluaXRpYWxpemVfZnJhbWUgKHN0b3JhZ2UtPmN1cnJlbnQtPm5leHQpOwog ICAgICAgc3RvcmFnZS0+Y3VycmVudCA9IHN0b3JhZ2UtPmN1cnJlbnQtPm5leHQ7CiAgICAgfQot LSAKMi42LjMKCg== --001a114450c8d88d9c0525246bc7--