From: Philipp Stephani <p.stephani2@gmail.com>
To: emacs-devel@gnu.org
Cc: Philipp Stephani <phst@google.com>
Subject: Re: [PATCH] Protect against an infloop in python-mode
Date: Thu, 23 Mar 2017 22:08:15 +0000 [thread overview]
Message-ID: <CAArVCkSt5GFttOb6q0=SsCwB7Fd2+DWk0veAv0dgh8t02BHaNA@mail.gmail.com> (raw)
In-Reply-To: <20170228213149.15842-1-phst@google.com>
[-- Attachment #1: Type: text/plain, Size: 968 bytes --]
Philipp Stephani <p.stephani2@gmail.com> schrieb am Di., 28. Feb. 2017 um
22:32 Uhr:
> There appears to be an edge case caused by using `syntax-ppss' in a
> narrowed buffer during JIT lock inside of Python triple-quote strings.
> Unfortunately it is impossible to reproduce without manually
> destroying the syntactic information in the Python buffer, but it has
> been observed in practice. In that case it can happen that the syntax
> caches get sufficiently out of whack so that there appear to be
> overlapping strings in the buffer. As Python has no nested strings,
> this situation is impossible and leads to an infloop in
> `python-nav-end-of-statement'. Protect against this by checking
> whether the search for the end of the current string makes progress.
>
> * python.el (python-nav-end-of-statement): Protect against infloop.
> * progmodes/python-tests.el
> (python-tests--python-nav-end-of-statement--infloop): Add unit test.
>
Pushed as 4fbd330fae.
[-- Attachment #2: Type: text/html, Size: 1560 bytes --]
next prev parent reply other threads:[~2017-03-23 22:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 21:31 [PATCH] Protect against an infloop in python-mode Philipp Stephani
2017-03-23 22:08 ` Philipp Stephani [this message]
2017-03-24 17:53 ` Alan Mackenzie
2017-03-26 18:49 ` Philipp Stephani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAArVCkSt5GFttOb6q0=SsCwB7Fd2+DWk0veAv0dgh8t02BHaNA@mail.gmail.com' \
--to=p.stephani2@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=phst@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).