unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Philipp Stephani <p.stephani2@gmail.com>
To: Emacs developers <emacs-devel@gnu.org>
Subject: Docstring of compare-buffer-substrings
Date: Sun, 02 Oct 2016 17:59:34 +0000	[thread overview]
Message-ID: <CAArVCkSnEGua6xpYUm-HbFwRdVLZvf768Vaks-Bbw9f1Tur+Sg@mail.gmail.com> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 149 bytes --]

Hi,

compare-buffer-substring allows all its arguments to be nil, but the
docstring doesn't say that. Attached is a patch that amends the docstring.

[-- Attachment #1.2: Type: text/html, Size: 198 bytes --]

[-- Attachment #2: 0001-Document-nil-args-of-compare-buffer-substrings.txt --]
[-- Type: text/plain, Size: 1237 bytes --]

From ab84e3ce5df8a648814e9b30fa10aa401e1feafb Mon Sep 17 00:00:00 2001
From: Philipp Stephani <phst@google.com>
Date: Sun, 2 Oct 2016 19:58:39 +0200
Subject: [PATCH] Document nil args of compare-buffer-substrings

* editfns.c (Fcompare_buffer_substrings): Document behavior when
the arguments are nil.
---
 src/editfns.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/editfns.c b/src/editfns.c
index 0bcc439..dcb1d8d 100644
--- a/src/editfns.c
+++ b/src/editfns.c
@@ -2936,6 +2936,10 @@ Return -N if first string is less after N-1 chars, +N if first string is
 greater after N-1 chars, or 0 if strings match.
 The first substring is in BUFFER1 from START1 to END1 and the second
 is in BUFFER2 from START2 to END2.
+All arguments may be nil.  If BUFFER1 or BUFFER2 is nil, the current
+buffer is used.  If START1 or START2 is nil, the value of `point-min'
+in the respective buffers is used.  If END1 or END2 is nil, the value
+of `point-max' in the respective buffers is used.
 The value of `case-fold-search' in the current buffer
 determines whether case is significant or ignored.  */)
   (Lisp_Object buffer1, Lisp_Object start1, Lisp_Object end1, Lisp_Object buffer2, Lisp_Object start2, Lisp_Object end2)
-- 
2.10.0


             reply	other threads:[~2016-10-02 17:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-02 17:59 Philipp Stephani [this message]
2016-10-03  7:13 ` Docstring of compare-buffer-substrings Eli Zaretskii
2016-10-03 10:12   ` Philipp Stephani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAArVCkSnEGua6xpYUm-HbFwRdVLZvf768Vaks-Bbw9f1Tur+Sg@mail.gmail.com \
    --to=p.stephani2@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).