unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Philipp Stephani <p.stephani2@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Philipp Stephani <phst@google.com>,
	Emacs developers <emacs-devel@gnu.org>
Subject: Re: master 8dcb19f 4/4: Add a unit test testing interaction between threads and processes.
Date: Sat, 23 Jan 2021 21:33:29 +0100	[thread overview]
Message-ID: <CAArVCkSkv--ae3Xtvpn+HEh69XiNM13Ytfz8xVS9K5MKtD-5FA@mail.gmail.com> (raw)
In-Reply-To: <83h7n74cwe.fsf@gnu.org>

Am Sa., 23. Jan. 2021 um 21:27 Uhr schrieb Eli Zaretskii <eliz@gnu.org>:
>
> > Date: Sat, 23 Jan 2021 21:49:18 +0200
> > From: Eli Zaretskii <eliz@gnu.org>
> > Cc: Philipp Stephani <phst@google.com>, emacs-devel@gnu.org
> >
> >   Test process-tests/multiple-threads-waiting condition:
> >       (ert-test-failed
> >        ((should
> >        (eql
> >         (process-exit-status process)
> >         0))
> >       :form
> >       (eql 1 0)
> >       :value nil))
> >      FAILED  21/26  process-tests/multiple-threads-waiting (8.859375 sec)
>
> And if I run just this one test (using SELECTOR=...), it hangs in the
> first call to thread-join.
>
> Can you describe the idea of the test,

This test essentially implements your request to verify the
interactions between the self-pipe for SIGCHLD and threads. Seems it
discovered some issues on Windows instead! The test works fine on
GNU/Linux and macOS.

> and in particular why did you
> expect the threads to start running?  IOW, which part of this test is
> supposed to force the main thread to yield so that one of the other
> threads starts running?

thread-join should yield.



  reply	other threads:[~2021-01-23 20:33 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-23 19:49 master 8dcb19f 4/4: Add a unit test testing interaction between threads and processes Eli Zaretskii
2021-01-23 20:27 ` Eli Zaretskii
2021-01-23 20:33   ` Philipp Stephani [this message]
2021-01-24  5:26     ` Eli Zaretskii
2021-01-24 13:22       ` Philipp Stephani
2021-01-24 15:30         ` Eli Zaretskii
2021-02-28 18:30           ` Philipp
2021-02-28 18:36             ` Stefan Monnier
2021-02-28 18:52               ` Philipp
2021-02-28 20:19             ` Eli Zaretskii
2021-03-18 12:51               ` Philipp
2021-03-18 15:39                 ` Eli Zaretskii
2021-03-21 12:00                   ` Philipp
2021-03-21 12:23                     ` Eli Zaretskii
2021-01-23 20:34 ` Philipp Stephani
2021-01-24  3:36   ` Eli Zaretskii
2021-01-24 14:43     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAArVCkSkv--ae3Xtvpn+HEh69XiNM13Ytfz8xVS9K5MKtD-5FA@mail.gmail.com \
    --to=p.stephani2@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=phst@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).