From: Philipp Stephani <p.stephani2@gmail.com>
To: "Óscar Fuentes" <ofv@wanadoo.es>
Cc: Philipp Stephani <phst@google.com>,
Emacs developers <emacs-devel@gnu.org>
Subject: Re: [PATCH] Add a new user option 'ido-big-directories'.
Date: Fri, 19 Apr 2019 11:10:11 +0200 [thread overview]
Message-ID: <CAArVCkSj48t_b8_JrGUFC7Ebrs2s-e4PHeL69a_bHfrs8AMU_w@mail.gmail.com> (raw)
In-Reply-To: <87bm14sbko.fsf@telefonica.net>
Am Mi., 17. Apr. 2019 um 20:58 Uhr schrieb Óscar Fuentes <ofv@wanadoo.es>:
>
> Philipp Stephani <p.stephani2@gmail.com> writes:
>
> > This provides an alternative to 'ido-max-directory-size', for
> > directories that are statically known to be too big for Ido
> > completion.
> >
> > * lisp/ido.el (ido-big-directories): New user option.
> > (ido-directory-too-big-p): Use it.
>
> What this option does is to revert to non-ido completion when the
> regexp matches the directory name, it has nothing to do with the
> directory being big.
>
> I suggest that you rename the user option accordingly and move its use
> outside of ido-directory-too-big-p.
This is a semantical difference: it's specifically intended to mark
directories as big, and Ido shows "too big" when attempting to
complete such a directory, so I think the name is warranted.
next prev parent reply other threads:[~2019-04-19 9:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 12:23 [PATCH] Add a new user option 'ido-big-directories' Philipp Stephani
2019-04-12 12:58 ` Eli Zaretskii
2019-04-17 18:30 ` Philipp Stephani
2019-04-17 18:31 ` Philipp Stephani
2019-04-18 14:40 ` Eli Zaretskii
2019-04-19 8:35 ` Philipp Stephani
2019-04-17 18:58 ` Óscar Fuentes
2019-04-19 9:10 ` Philipp Stephani [this message]
2019-04-19 12:23 ` Óscar Fuentes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAArVCkSj48t_b8_JrGUFC7Ebrs2s-e4PHeL69a_bHfrs8AMU_w@mail.gmail.com \
--to=p.stephani2@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=ofv@wanadoo.es \
--cc=phst@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).