From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: scratch/sigchld-fd 8f0ce42 1/2: Fix deadlock when receiving SIGCHLD during 'pselect'. Date: Sat, 23 Jan 2021 18:36:48 +0100 Message-ID: References: <20210116184947.2105.45267@vcs0.savannah.gnu.org> <20210116184949.3C17C211A5@vcs0.savannah.gnu.org> <834kjd7yk5.fsf@gnu.org> <83turc7n93.fsf@gnu.org> <83pn1z7inp.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33553"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Philipp Stephani , Emacs developers To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 23 18:37:46 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l3Mr4-0008bh-7w for ged-emacs-devel@m.gmane-mx.org; Sat, 23 Jan 2021 18:37:46 +0100 Original-Received: from localhost ([::1]:58812 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l3Mr3-0004xH-BM for ged-emacs-devel@m.gmane-mx.org; Sat, 23 Jan 2021 12:37:45 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37050) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3MqP-0004K3-H1 for emacs-devel@gnu.org; Sat, 23 Jan 2021 12:37:05 -0500 Original-Received: from mail-oi1-x231.google.com ([2607:f8b0:4864:20::231]:45486) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l3MqL-0002y0-3v; Sat, 23 Jan 2021 12:37:04 -0500 Original-Received: by mail-oi1-x231.google.com with SMTP id g69so9145104oib.12; Sat, 23 Jan 2021 09:37:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qRf6Q82nL1rzBp69oLzksVzmZKozw/dn0Y2s+xdaE00=; b=eO+nr5kVfcvoERoB7jwxAxgXveYIL0kISopHHrt+wNwvgYmoafgoe9Fdd+qbb83p6m lt+YjR4f4SjnSBjpJa+XgQwE6CfgFcnarmg/wrLiqLR0tzd2q0hG3uJ1PuFkz8raffvW x3UG8K1vqlmg2W44GIPtpSzYiBEB1JO+DYpnzvgTZwLUhOUjiTleIqb/3MAWKiWvuSOu LvPLRASQX4o5y93IbNl/5VKcYT/kEXRgHxFEDVYsSkI/xLe1+b4uTFCn1VPnImjF/zoG suXDKyhbhojl0r0Fr1NjwcGtscFe38ORNnJp2iU0Dof9UU1MJjTEN+ElLodJTFhpN00D SxmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qRf6Q82nL1rzBp69oLzksVzmZKozw/dn0Y2s+xdaE00=; b=eyaWcgNfxVvVknBiduaQO7hHOGPmm7A/P1/qbmh0yukTJDfuZDzsY/XfMrpAs2oZCl Q4sNCNa6fhWeApGbMtM0lAjVpKOy2kIEVZRskgoJ2KPdPjnR4Z2z0LIF7X8+1Hrikfsk rFSk2jZYVa0/F8fNTRE7nmTANC6jf68H3ENJH1bbr+Y6kF0sXRFOOZGw+rAsmTJ65EZ6 E9Raqzcn5MopugPrsKJ7QNYN+5PsmqEzZJF7k+fM7gGWkvgYV6umd6Qv+3a0vvyd9+nG Vr4d9NCLQMqtlgqD19KY8IoBxuagfHFC5iU4bvyjGt9zAeymRxpmkVZ8apKeAe/UbRST faiQ== X-Gm-Message-State: AOAM533HA1tQAlHvmIXar2wtQTownlWCTEaXitrHhM4D1ddPn8g8UnJp rD56oFVACu4LD2Ud7G22J0P/tFSB7CuG5k4NK8n0XdBKjBA= X-Google-Smtp-Source: ABdhPJxsASskXi4crSvz74r442K+I00sW8ybsaN3BvH/isNdxeUDcjNS+fr09Y+KKBX8lbIsKtVda8XwZwbk7lXunFY= X-Received: by 2002:aca:5d09:: with SMTP id r9mr6735906oib.25.1611423419387; Sat, 23 Jan 2021 09:36:59 -0800 (PST) In-Reply-To: <83pn1z7inp.fsf@gnu.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::231; envelope-from=p.stephani2@gmail.com; helo=mail-oi1-x231.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263307 Archived-At: Am Mi., 20. Jan. 2021 um 16:05 Uhr schrieb Eli Zaretskii : > > > > The thing is, on Windows we can only wait on up to 64 handles (unless > > > we complicate the code with multilevel wait, that is), so every > > > unnecessary descriptor we need to wait on means we can support fewer > > > simultaneous subprocesses. We are already limited to just 32 > > > subprocesses, which is quite low a number. > > > > OK, that's a good point, I didn't know about this limitation. I'll see > > that I can remove the pipe on Windows. > > Just making those child_signal_* function be no-ops on MS-Windows, and > #ifedf'ing away that call to FD_SET of child_fd, should be okay, I > think. I was about to take a stab at this, but looks like you beat me to it :-)