From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: add-hook and defvar Date: Thu, 05 Mar 2015 20:28:08 +0000 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a11c1dada023adf05109068d7 X-Trace: ger.gmane.org 1425587309 30748 80.91.229.3 (5 Mar 2015 20:28:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 5 Mar 2015 20:28:29 +0000 (UTC) Cc: Artur Malabarba , emacs-devel To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Mar 05 21:28:28 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YTcNg-0003T5-FE for ged-emacs-devel@m.gmane.org; Thu, 05 Mar 2015 21:28:28 +0100 Original-Received: from localhost ([::1]:54747 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTcNf-0007ew-QL for ged-emacs-devel@m.gmane.org; Thu, 05 Mar 2015 15:28:27 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38136) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTcNP-0007dE-GQ for emacs-devel@gnu.org; Thu, 05 Mar 2015 15:28:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YTcNO-0007MH-Gy for emacs-devel@gnu.org; Thu, 05 Mar 2015 15:28:11 -0500 Original-Received: from mail-ob0-x235.google.com ([2607:f8b0:4003:c01::235]:36786) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTcNO-0007M7-CG for emacs-devel@gnu.org; Thu, 05 Mar 2015 15:28:10 -0500 Original-Received: by obbnt9 with SMTP id nt9so16470892obb.3 for ; Thu, 05 Mar 2015 12:28:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:references:from:date:message-id:subject:to:cc :content-type; bh=By73Gbo1Q/HaD1tkfk8q2VjwCeJFpZmSyFmUpT27vig=; b=OcMG/VE2eyu9DEvLZplB3wGB9Rx0Ro+j24MXUKA1lXBGU69D66d++uE0YFfEDIcuQg NHUghkAo7qK7fa8+K8yI0nZyOpqYrIU1ljK9naul3zQRXcL+mlTqIXJ/5X+xkKCjZ6nW jZtGoky2Dyux9dXp93RbDnirhnogDGJNaA+yamTAS+qcGw3sBef9qhccJK0wh+8pZnqz /xjxM7u6UxV/2y75maU7GmTasYGuhj/HcpF0JW4oLuILvbXatJ2uxTzkImNfAc5T3C5u THvHsfzZrwFgSJmiXNG1fNxfPN5TGPmOpSJED40Y46ICaBGXfyzqLQZvRk1EHc5zEbdi 1VyA== X-Received: by 10.182.251.138 with SMTP id zk10mr8457172obc.72.1425587289824; Thu, 05 Mar 2015 12:28:09 -0800 (PST) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4003:c01::235 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:183682 Archived-At: --001a11c1dada023adf05109068d7 Content-Type: multipart/alternative; boundary=001a11c1dada023ad905109068d5 --001a11c1dada023ad905109068d5 Content-Type: text/plain; charset=UTF-8 Stefan Monnier schrieb am Mi., 25. Feb. 2015 um 03:56 Uhr: > > Is this something the byte compiler could warn about? At least normal > hooks > > by convention end in "-hook", so a warning could be emitted every time > such > > a variable is defined that doesn't have nil as default. > > Yes, we could do that. Patch welcome, > > > Added a patch. --001a11c1dada023ad905109068d5 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


Stefan Monnier <monnier@iro.umontreal.ca> sc= hrieb am Mi., 25. Feb. 2015 um 03:56=C2=A0Uhr:
> Is this something the byte compiler could warn about? At least n= ormal hooks
> by convention end in "-hook", so a warning could be emitted = every time such
> a variable is defined that doesn't have nil as default.

Yes, we could do that.=C2=A0 Patch welcome,



Added a patch.=C2=A0
--001a11c1dada023ad905109068d5-- --001a11c1dada023adf05109068d7 Content-Type: text/plain; charset=US-ASCII; name="0001-Warn-if-a-hook-variable-is-given-a-non-nil-init-form.txt" Content-Disposition: attachment; filename="0001-Warn-if-a-hook-variable-is-given-a-non-nil-init-form.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: 14beb9f9b5af5e451d01 RnJvbSA4YWFkNzRkMmNiMTJhN2FmZDYwNjdiODczNzg5NGMzYTRiOTA1YTIwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwIFN0ZXBoYW5pIDxwaHN0QGdvb2dsZS5jb20+CkRh dGU6IFRodSwgNSBNYXIgMjAxNSAyMTowNjowNyArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIFdhcm4g aWYgYSBob29rIHZhcmlhYmxlIGlzIGdpdmVuIGEgbm9uLW5pbCBpbml0IGZvcm0KCi0tLQogbGlz cC9lbWFjcy1saXNwL2J5dGVjb21wLmVsIHwgMyArKysKIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2Vy dGlvbnMoKykKCmRpZmYgLS1naXQgYS9saXNwL2VtYWNzLWxpc3AvYnl0ZWNvbXAuZWwgYi9saXNw L2VtYWNzLWxpc3AvYnl0ZWNvbXAuZWwKaW5kZXggZTkyOWMwMi4uYjlkYjMyMiAxMDA2NDQKLS0t IGEvbGlzcC9lbWFjcy1saXNwL2J5dGVjb21wLmVsCisrKyBiL2xpc3AvZW1hY3MtbGlzcC9ieXRl Y29tcC5lbApAQCAtMjMxMSw2ICsyMzExLDkgQEAgbGlzdCB0aGF0IHJlcHJlc2VudHMgYSBkb2Mg c3RyaW5nIHJlZmVyZW5jZS4KIChkZWZ1biBieXRlLWNvbXBpbGUtZmlsZS1mb3JtLWRlZnZhciAo Zm9ybSkKICAgKGxldCAoKHN5bSAobnRoIDEgZm9ybSkpKQogICAgIChieXRlLWNvbXBpbGUtLWRl Y2xhcmUtdmFyIHN5bSkKKyAgICAoYW5kIChzdHJpbmctc3VmZml4LXAgIi1ob29rIiAoc3ltYm9s LW5hbWUgc3ltKSkKKyAgICAgICAgIChudGggMiBmb3JtKQorICAgICAgICAgKGJ5dGUtY29tcGls ZS13YXJuICJob29rIHZhcmlhYmxlIGAlcycgaGFzIG5vbi1uaWwgaW5pdCB2YWx1ZSIgc3ltKSkK ICAgICAoaWYgKGVxIChjYXIgZm9ybSkgJ2RlZmNvbnN0KQogICAgICAgICAocHVzaCBzeW0gYnl0 ZS1jb21waWxlLWNvbnN0LXZhcmlhYmxlcykpKQogICAoaWYgKGFuZCAobnVsbCAoY2RkciBmb3Jt KSkJCTtObyBgdmFsdWUnIHByb3ZpZGVkLgotLSAKMi4yLjAucmMwLjIwNy5nYTNhNjE2YwoK --001a11c1dada023adf05109068d7--