From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: Dynamic modules: should should-error work? Date: Mon, 23 Nov 2015 19:28:09 +0000 Message-ID: References: <838u5p3n32.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=089e0102def45917ea05253a3a24 X-Trace: ger.gmane.org 1448306958 3441 80.91.229.3 (23 Nov 2015 19:29:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 23 Nov 2015 19:29:18 +0000 (UTC) To: Eli Zaretskii , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 23 20:29:16 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a0wmy-0000w5-P4 for ged-emacs-devel@m.gmane.org; Mon, 23 Nov 2015 20:28:36 +0100 Original-Received: from localhost ([::1]:34236 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0wmz-0003Md-A3 for ged-emacs-devel@m.gmane.org; Mon, 23 Nov 2015 14:28:37 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56139) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0wmm-0003MQ-G0 for emacs-devel@gnu.org; Mon, 23 Nov 2015 14:28:25 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a0wml-00039U-Hu for emacs-devel@gnu.org; Mon, 23 Nov 2015 14:28:24 -0500 Original-Received: from mail-wm0-x236.google.com ([2a00:1450:400c:c09::236]:35718) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0wmk-00038X-00; Mon, 23 Nov 2015 14:28:22 -0500 Original-Received: by wmuu63 with SMTP id u63so68216279wmu.0; Mon, 23 Nov 2015 11:28:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :content-type; bh=z49nbq255VQR2l8ldtH+dWGbJSlNxMPA3Vp8pazETJs=; b=O6diD7W+isfmv0KiAikReM3xY1JxBKnnhcH6XLSBkwheYAwGtTp4LYQfsyymJVY6S3 1PDF5gSXM+AOrrTMvcqIuFgLPhAOiCHHOEp1kAue/fA54JiXubcKyHFXiHLZCTu0jvhZ Idpt/D8U9ZtVUyiMigKeoiWIZPAOLCSPOCsiKhuhxa60Q7iDI6uuUP68+PEg9PmAmSUn jwgV+1Bg9MGX4qr4ZL2lg8btuDq2zqoCSFr36T3lm+/B/7B9PpkYbUMkywV0UGVxCOEg C0MnccfDY850S0Cx2t6+w94vS/omwbTnOxJC3KzhgWNbsSlElQIMf8tSv72MMIgYf7EC GZEA== X-Received: by 10.194.87.39 with SMTP id u7mr32682956wjz.11.1448306900671; Mon, 23 Nov 2015 11:28:20 -0800 (PST) In-Reply-To: <838u5p3n32.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c09::236 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:195138 Archived-At: --089e0102def45917ea05253a3a24 Content-Type: multipart/alternative; boundary=089e0102def45917e505253a3a22 --089e0102def45917e505253a3a22 Content-Type: text/plain; charset=UTF-8 Eli Zaretskii schrieb am So., 22. Nov. 2015 um 19:29 Uhr: > It looks like should-error doesn't work with functions implemented in > modules. For example, try this in modules/mod-test/test.el: > > (ert-deftest mod-test-sum-test () > (should-error (mod-test-sum 1 2 3))) > > I cannot get this test to succeed, although the error message about > wrong number of arguments is emitted. What am I missing? > > This works for me. Maybe there was some intermittent bug that has since been fixed? Anyway, this is a useful thing to test. I've attached a patch to add this to the test suite. --089e0102def45917e505253a3a22 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


Eli Za= retskii <eliz@gnu.org> schrieb am= So., 22. Nov. 2015 um 19:29=C2=A0Uhr:
It looks like should-error doesn't work with functions implemented = in
modules.=C2=A0 For example, try this in modules/mod-test/test.el:

=C2=A0 (ert-deftest mod-test-sum-test ()
=C2=A0 =C2=A0 (should-error (mod-test-sum 1 2 3)))

I cannot get this test to succeed, although the error message about
wrong number of arguments is emitted.=C2=A0 What am I missing?


This works for me. Maybe there was som= e intermittent bug that has since been fixed?
Anyway, this is a u= seful thing to test. I've attached a patch to add this to the test suit= e.=C2=A0
--089e0102def45917e505253a3a22-- --089e0102def45917ea05253a3a24 Content-Type: application/octet-stream; name="0001-Add-test-for-argument-count-check.patch" Content-Disposition: attachment; filename="0001-Add-test-for-argument-count-check.patch" Content-Transfer-Encoding: base64 Content-ID: <15135d13b825041301b1> X-Attachment-Id: 15135d13b825041301b1 RnJvbSA2NjdmYTRjZmY1MjU2MDRhZGJlZTdmNWI5MjA1MzZiNjM5ODdlNzJkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwIFN0ZXBoYW5pIDxwaHN0QGdvb2dsZS5jb20+CkRh dGU6IE1vbiwgMjMgTm92IDIwMTUgMjA6Mjc6MDcgKzAxMDAKU3ViamVjdDogW1BBVENIXSBBZGQg dGVzdCBmb3IgYXJndW1lbnQgY291bnQgY2hlY2sKCi0tLQogbW9kdWxlcy9tb2QtdGVzdC9tb2Qt dGVzdC5jIHwgMiArKwogbW9kdWxlcy9tb2QtdGVzdC90ZXN0LmVsICAgIHwgMyArKy0KIDIgZmls ZXMgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEv bW9kdWxlcy9tb2QtdGVzdC9tb2QtdGVzdC5jIGIvbW9kdWxlcy9tb2QtdGVzdC9tb2QtdGVzdC5j CmluZGV4IDQ0YTE0ZGMuLmIwYzUzNWMgMTAwNjQ0Ci0tLSBhL21vZHVsZXMvbW9kLXRlc3QvbW9k LXRlc3QuYworKysgYi9tb2R1bGVzL21vZC10ZXN0L21vZC10ZXN0LmMKQEAgLTQyLDYgKzQyLDgg QEAgc3VtIChpbnRtYXhfdCBhLCBpbnRtYXhfdCBiKQogc3RhdGljIGVtYWNzX3ZhbHVlCiBGbW9k X3Rlc3Rfc3VtIChlbWFjc19lbnYgKmVudiwgcHRyZGlmZl90IG5hcmdzLCBlbWFjc192YWx1ZSBh cmdzW10sIHZvaWQgKmRhdGEpCiB7CisgIGFzc2VydCAobmFyZ3MgPT0gMik7CisKICAgaW50bWF4 X3QgYSA9IGVudi0+ZXh0cmFjdF9pbnRlZ2VyIChlbnYsIGFyZ3NbMF0pOwogICBpbnRtYXhfdCBi ID0gZW52LT5leHRyYWN0X2ludGVnZXIgKGVudiwgYXJnc1sxXSk7CiAKZGlmZiAtLWdpdCBhL21v ZHVsZXMvbW9kLXRlc3QvdGVzdC5lbCBiL21vZHVsZXMvbW9kLXRlc3QvdGVzdC5lbAppbmRleCA5 OGNlNDY0Li5kOTQ5ZmE0IDEwMDY0NAotLS0gYS9tb2R1bGVzL21vZC10ZXN0L3Rlc3QuZWwKKysr IGIvbW9kdWxlcy9tb2QtdGVzdC90ZXN0LmVsCkBAIC0yOCw3ICsyOCw4IEBACiA7OwogCiAoZXJ0 LWRlZnRlc3QgbW9kLXRlc3Qtc3VtLXRlc3QgKCkKLSAgKHNob3VsZCAoPSAobW9kLXRlc3Qtc3Vt IDEgMikgMykpKQorICAoc2hvdWxkICg9IChtb2QtdGVzdC1zdW0gMSAyKSAzKSkKKyAgKHNob3Vs ZC1lcnJvciAobW9kLXRlc3Qtc3VtIDEgMiAzKSA6dHlwZSAnd3JvbmctbnVtYmVyLW9mLWFyZ3Vt ZW50cykpCiAKIChlcnQtZGVmdGVzdCBtb2QtdGVzdC1zdW0tZG9jc3RyaW5nICgpCiAgIChzaG91 bGQgKHN0cmluZz0gKGRvY3VtZW50YXRpb24gJ21vZC10ZXN0LXN1bSkgIlJldHVybiBBICsgQiIp KSkKLS0gCjIuNi4zCgo= --089e0102def45917ea05253a3a24--