From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: pure-fns in byte-opt.el Date: Sun, 24 Sep 2017 07:34:27 +0000 Message-ID: References: <20170725020650.GA12601@holos.localdomain> <20170726010000.GA14292@holos.localdomain> <83o9s75kus.fsf@gnu.org> <20170727023608.GA1895@holos.localdomain> <83y3r94xo5.fsf@gnu.org> <20170728002448.GA2431@holos.localdomain> <83mv7p3uy5.fsf@gnu.org> <20170729012407.GA6581@holos.localdomain> <83vamb3duz.fsf@gnu.org> <20170729163446.GA9109@holos.localdomain> <83a83n2m7r.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a113cd06a6754f00559ea794e" X-Trace: blaine.gmane.org 1506238495 970 195.159.176.226 (24 Sep 2017 07:34:55 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 24 Sep 2017 07:34:55 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii , Mark Oteiza Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Sep 24 09:34:48 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dw1R4-0007na-K0 for ged-emacs-devel@m.gmane.org; Sun, 24 Sep 2017 09:34:42 +0200 Original-Received: from localhost ([::1]:37186 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dw1RA-0005aw-8F for ged-emacs-devel@m.gmane.org; Sun, 24 Sep 2017 03:34:48 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:32768) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dw1R3-0005ag-DS for emacs-devel@gnu.org; Sun, 24 Sep 2017 03:34:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dw1R2-0001re-IE for emacs-devel@gnu.org; Sun, 24 Sep 2017 03:34:41 -0400 Original-Received: from mail-oi0-x232.google.com ([2607:f8b0:4003:c06::232]:49506) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dw1R0-0001oj-HP; Sun, 24 Sep 2017 03:34:38 -0400 Original-Received: by mail-oi0-x232.google.com with SMTP id i128so3321385oih.6; Sun, 24 Sep 2017 00:34:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=20IbhO1g2Ta+EUE66sNH4EYiObBz7aeaayGec0Acrvs=; b=vecwxDhOMTNL2cbyB33Hv4EVVdmxTwxdpjLcC0mEkIxpecQ3ElRhITStkL8UZHc917 jgtAucQpysQMEao1A2X8fdXELXwOnXhf7mhwleEHSGUVqAe7shJXgD8NveXS1DS3UvFS oPiEKZT/+5CW6cd9gS4xR58xby/IyMXA+3VQ9Xxb3qAWwDRmVlfX0+SuIGr1zz6sP9pW knRQzzIuGJwYRW3kWkRjmBz42+hveb4eytRSWKSa+haCwppEbU62Sp+sWD/21SrGDpRg qRog16uwLTfEE4nWhvXcknqM0CfAUAXuN6OxAyxG5vW/bvkxdtLZ8NsLA4JbdtzfPXah PzIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=20IbhO1g2Ta+EUE66sNH4EYiObBz7aeaayGec0Acrvs=; b=aZSjKaVQGC44bPsoQ6AynTPVFJTmLbHu0kgwYey/eCuCZAtDIdpXrHlz0WYy0xyTug pHWHpSaIjfLO/lXkq+dhI653u4PGczfNoDs25yqDjcQ+FYwN+A7wOumfOEbL1AsKjp9q wMOxZ3xQCRauVHsGeUQfaG/snokLSeLSzyglifuVC8qG+amf0/vSnln2Rj6Isb+u5Lwu Jq+JLHdqzxeRBLQeZ1imP4nAjjr4V9MHk6/jOaTRL0lJC9vYS1rpal0zDpuajzb1Am0E Fx15mSNnz9qT5HUQXMUB3uPc5+WtcjWNRTofm0/wo6HD56eQMBhS7Kq4O24kmL4dJJyX CkHg== X-Gm-Message-State: AHPjjUgAe9SmvgwKusr40/i5UlUZW1iaz3yTFU4/RlTfL09neX0he+md 1WwH9RdX9KF4WwEh3SDQJJdxilOvqgFB1t4hljC6sg== X-Google-Smtp-Source: AOwi7QBREAFuHKLHxeQQJRajE/yQrBeBcrSLvMz4320Ju/uOyP032dqrvT37rJv4fR7pzb9zCZaN1gYEF+DzJXc6gQQ= X-Received: by 10.202.67.194 with SMTP id q185mr428935oia.52.1506238477586; Sun, 24 Sep 2017 00:34:37 -0700 (PDT) In-Reply-To: <83a83n2m7r.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c06::232 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:218738 Archived-At: --001a113cd06a6754f00559ea794e Content-Type: text/plain; charset="UTF-8" Eli Zaretskii schrieb am Sa., 29. Juli 2017 um 19:22 Uhr: > > Date: Sat, 29 Jul 2017 12:34:46 -0400 > > From: Mark Oteiza > > Cc: emacs-devel@gnu.org > > > > >So I think the problem happens in unidata-word-list-compress, and it > > >happens because make-vector, which that function calls always returns > > >the same vector, so the vectors used by that function and created by > > >it are all messed up. > > > > I don't follow: why does it always return the same vector? > > That's how I understand what the byte compiler does when you declare > that function "pure". > That sounds like a bug. Optimization shouldn't change semantics. Either we need to change the definition of "pure" to something far more restrictive, or we should fix the optimizer. --001a113cd06a6754f00559ea794e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Eli Za= retskii <eliz@gnu.org> schrieb am= Sa., 29. Juli 2017 um 19:22=C2=A0Uhr:
> Date: Sat, 29 Jul 2017 12:34:46 -0400
> From: Mark Oteiza <mvoteiza@udel.edu>
> Cc: emacs-dev= el@gnu.org
>
> >So I think the problem happens in unidata-word-list-compress, and = it
> >happens because make-vector, which that function calls always retu= rns
> >the same vector, so the vectors used by that function and created = by
> >it are all messed up.
>
> I don't follow: why does it always return the same vector?

That's how I understand what the byte compiler does when you declare that function "pure".

That sounds like a bug. Optimization shoul= dn't change semantics. Either we need to change the definition of "= ;pure" to something far more restrictive, or we should fix the optimiz= er.=C2=A0
--001a113cd06a6754f00559ea794e--