From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: emacs | Pipeline #8399 has failed for master | ee0e259e Date: Mon, 4 Jan 2021 21:38:07 +0100 Message-ID: References: <5feaf98365b55_3f903d428113941@emba.gnu.org.mail> <87o8ica9xp.fsf@gmx.de> <87pn2s35a2.fsf@gmail.com> <87ft3oa4pz.fsf@gmx.de> <8735zo9ui7.fsf@gmx.de> <87h7nw39gg.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4549"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Michael Albinus To: Emacs developers Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jan 04 21:39:28 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kwWdU-00012O-5x for ged-emacs-devel@m.gmane-mx.org; Mon, 04 Jan 2021 21:39:28 +0100 Original-Received: from localhost ([::1]:39506 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kwWdT-0003Aa-7s for ged-emacs-devel@m.gmane-mx.org; Mon, 04 Jan 2021 15:39:27 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52418) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwWcU-0002hM-DT for emacs-devel@gnu.org; Mon, 04 Jan 2021 15:38:26 -0500 Original-Received: from mail-oo1-xc2b.google.com ([2607:f8b0:4864:20::c2b]:46751) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kwWcS-00026d-KV for emacs-devel@gnu.org; Mon, 04 Jan 2021 15:38:26 -0500 Original-Received: by mail-oo1-xc2b.google.com with SMTP id n127so6570367ooa.13 for ; Mon, 04 Jan 2021 12:38:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=KhJ3dFjJ9D4bRXVcHO4p2yB09XFNXRLZuMqgXmjAg7I=; b=Nw9cIk1r3g5TfQgNGT1ea2ldC6Hr2r8JLGss2gRvSRGQvsOtVmhLr8BqXqRA9O0/SI +f7P01KjSpV4iY26mupVwZmrCvrFNfrTXzhyWl5Fccm4mahLPdonrWR5VT/QduRCZAz0 Dgqm1h4v1gN62B6YwomeE05/26fYNhJkDFJWRq05YNA9g1dRvDXC7+XcX+TYDDCAEWzx 6WshmKwl1JOCFbCuGbiy1KNH1YhVUNpcCxIj+9+8hlpZr5VTCXFo5+IlrD5yjMSFVoIe bR/KIIVQjcV6Fi53YQNaWBwRmsvS7lN1tmkH9pu44Y9fC613DRGsRjJMq5jZNYs0Ouro UQHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=KhJ3dFjJ9D4bRXVcHO4p2yB09XFNXRLZuMqgXmjAg7I=; b=nJ5f0MDV0Wxci2MMbSdFnrBRZ0FsxTOmn2MC+P8Xe3OAS+QlemivmocCgqBbyv4iaW 1RT28SDN8ObRnxdWSx4xP9bkhYR+fGEw3wQyIPU2p0/6Y8N09Y16y2JS/z/El5EHPONn M3LgPv74zqN49kJaHZ2Uxnn0O9Bf6L4ZwMJiiGwk82OdC+hWhJLKReqTZRu7LKusy95M r0ddZRnhv9y1bSS6LK05c7bEpGGgpWT1nPIKcvIxdONn+NPwMO15gMOaGmZtFXHTGR2H TOX+RMbts8W/zJ++0xnb4NDvYs0ZNU3KTV9qmfccpOy7KNt8Y+/l0oXjBXoYwmZCtYgF m+8g== X-Gm-Message-State: AOAM533ISeo+86I//IcjTvu2mrdYr6BF5Frpesn07CyxKPN3BGtwigGW hL/vP/1RnaZOglyhpl0ZQVdcBU2uM5DT1/sb8wwQ6POVg2U= X-Google-Smtp-Source: ABdhPJyg+FnVMMIjYbWE8KdSFtWjCDYs6Cpug6f4Q2ut7xhCL5/biDIrU8HAuCar3+wnuaNvi3uRZaL7AZmnR7X9+bI= X-Received: by 2002:a4a:b082:: with SMTP id k2mr50160595oon.60.1609792698465; Mon, 04 Jan 2021 12:38:18 -0800 (PST) In-Reply-To: <87h7nw39gg.fsf@gmail.com> Received-SPF: pass client-ip=2607:f8b0:4864:20::c2b; envelope-from=p.stephani2@gmail.com; helo=mail-oo1-xc2b.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:262482 Archived-At: Am Mo., 4. Jan. 2021 um 18:21 Uhr schrieb Robert Pluim : > > Michael Albinus writes: > > > Hi Robert, > > > >>> Is there a way to get src/process-tests.log? That would at least > >>> narrow it down. > >> > >> No, the whole CI job runs into a timeout. I have wrapped now all tests > >> in process-tests.el with a timeout of 60 seconds; hopefully it shows u= s > >> the log file in case of. > > > > See . > > process-test-sentinel-sit-for has produced a failure. And according to > > the timestamps, process-test-stderr-buffer ran into the timeout. > > > > process-test-sentinel-wait-function-working-p which is used by > process-test-sentinel-sit-for looks racy. Just because the process > sentinel has been called is no guarantee that the process has exited > and had its process-status set correctly, perhaps it should loop on > 'process-live-p' AFAIK the only correct way to wait for a process to exit is (while (accept-process-output PROC)). > > The process-test-stderr-buffer timeout I can't explain: nothing there > can wait longer than 2 seconds (unless it=CA=BCs 'make-process' that=CA= =BCs > timing out?) make-process can in theory deadlock on BSD-like systems due to a race between setting the close-on-exec flag and other fork+exec combinations. That's rather unlikely though. But maybe there's a race between accept-process-output and calling the sentinel so that the sentinel is called too early, and then accept-process-output blocks? AFAIK, when splitting stderr and stdout, one has to wait separately for the two involved processes: (while (accept-process-output process)) (while (accept-process-output stderr-process))