From mboxrd@z Thu Jan 1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Philipp Stephani
Newsgroups: gmane.emacs.devel
Subject: Re: What's the line length limit in the Emacs codebase?
Date: Sat, 26 Dec 2020 12:04:50 +0100
Message-ID:
References:
<83wnx8pm0e.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
logging-data="37524"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: Eli Zaretskii , Emacs developers
To: Richard Stallman
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Dec 26 12:06:52 2020
Return-path:
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.92)
(envelope-from )
id 1kt7PP-0009fQ-Sr
for ged-emacs-devel@m.gmane-mx.org; Sat, 26 Dec 2020 12:06:51 +0100
Original-Received: from localhost ([::1]:53810 helo=lists1p.gnu.org)
by lists.gnu.org with esmtp (Exim 4.90_1)
(envelope-from )
id 1kt7PO-00060j-Tf
for ged-emacs-devel@m.gmane-mx.org; Sat, 26 Dec 2020 06:06:50 -0500
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56926)
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from )
id 1kt7Ng-0004KX-PQ
for emacs-devel@gnu.org; Sat, 26 Dec 2020 06:05:04 -0500
Original-Received: from mail-ot1-x335.google.com ([2607:f8b0:4864:20::335]:36137)
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from )
id 1kt7Nf-00070X-5Q; Sat, 26 Dec 2020 06:05:04 -0500
Original-Received: by mail-ot1-x335.google.com with SMTP id d20so5366879otl.3;
Sat, 26 Dec 2020 03:05:02 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=mime-version:references:in-reply-to:from:date:message-id:subject:to
:cc; bh=Vfed8FxW8P6zl7HP6nZPkm+4lu395lt8py7Ntc4tX9o=;
b=sak546hGp4GwT7v9QRGZy0g0rMlyQF6/e1ohO4ORE3LAT7Z3BEMf4EeOQWeK66xt9Y
22lYW3YhEB9jr10EC2yjzdtzO6QA7EZk6NutSB7jGV56xXArmwa6ryes6r4kCiV49Mb5
u4Qjm94HiVenxYoo3Q3z1VWyGEdhCay2q4nc/3h/EJIAMLhgt/Wb6oN1nAFe4lP9u03j
cwQaS9GK1JnnfVzpWHyUSWZWQAb2PWf0Ub2CmCLjigObFJAY3UGsB0nIzh7b5L/E/WOf
B+wcyJI22C+NuL5DmKuiOiEFphzCbvtcub60R8mLVJx1VucNG1DnG3dGmB9c2lrGlkkE
065w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=Vfed8FxW8P6zl7HP6nZPkm+4lu395lt8py7Ntc4tX9o=;
b=H3CKMxs/itUZdhB9A0J7SVSDXSrFPKnpBjhPFvihw/n+NiLKUOavraNNieAWRXi2c+
gwCpq0bGuQgEyIAnO8QC9i9z+/2mPWwKpQAHxBflKvX+qkxLc/qvsqPtKEsMzFfUz3Ah
vb1/YpmlqeBgi3uJIrlH/Kso/wSjzEIXzMqcLHtEESDIkHv7d7WhyHuabX080QN3f6VX
CUiWiSyvUA4IoS/Un2B4XVYhTFcTUxlotwRaTBfma53cRURkK7LVDH8itjSu/vez/58t
XOH9TopefGZ0Jl7lluq57KXK5HSgdSipBaPVsSjVca8y3teskPJWKRaQ+l/qpXQdQVU4
iVuw==
X-Gm-Message-State: AOAM5316UDpBiMNUgF1KA+8zwpY8X7HOK8EXagbW7i/bJarlQdF76XGM
CnU/MDlU8P62yv32+Otxawpmh4u9TuFyQ3BZQq0lR2Z4Bfk=
X-Google-Smtp-Source: ABdhPJy0SXys+MtQOTHnHG8fnh9/xBgcnIw1u3DHCMMGdlyO6E5BVSpYhuGQo8PnERcCM5VueGgGpkAGQr3bGdXHWJ0=
X-Received: by 2002:a9d:269:: with SMTP id 96mr27448216otb.174.1608980701128;
Sat, 26 Dec 2020 03:05:01 -0800 (PST)
In-Reply-To:
Received-SPF: pass client-ip=2607:f8b0:4864:20::335;
envelope-from=p.stephani2@gmail.com; helo=mail-ot1-x335.google.com
X-Spam_score_int: -17
X-Spam_score: -1.8
X-Spam_bar: -
X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,
RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions."
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
Xref: news.gmane.io gmane.emacs.devel:261834
Archived-At:
Am Sa., 26. Dez. 2020 um 11:24 Uhr schrieb Richard Stallman :
>
> [[[ To any NSA and FBI agents reading my email: please consider ]]]
> [[[ whether defending the US Constitution against all enemies, ]]]
> [[[ foreign or domestic, requires you to follow Snowden's example. ]]]
>
> > > 70 is it, we just don't necessarily enforce it religously.
> > >
> > > Where did you see significant deviations from that standard?
>
> > Everywhere? When I last counted there were more than 1900 files in the
> > codebase that have lines longer than 70 characters. In src/emacs.c
> > alone there are over 160 such lines.
>
> Why argue about how rigid to be? Relax, please.
>
> If you see a clean way to eliminate some of those overlong lines,
> please do it. That way, we will move towards having fewer annoyingly
> long lines, and we will avoid the need to adopt a rule about it.
I don't think we should reformat existing code, that just adds
annoying whitespace changes that make 'git blame' etc. unnecessarily
hard. What I'd propose would be to stick to the 70-column limit a bit
more consistently in new or changed code.