From: Philipp Stephani <p.stephani2@gmail.com>
To: Alan Mackenzie <acm@muc.de>
Cc: Eli Zaretskii <eliz@gnu.org>, eggert@cs.ucla.edu, emacs-devel@gnu.org
Subject: Re: Old-style backquotes
Date: Sat, 09 Dec 2017 21:05:22 +0000 [thread overview]
Message-ID: <CAArVCkSBNLjeat_jGpDXrY__5WdCLi=zwGnyWVnSzOANBL+OuA@mail.gmail.com> (raw)
In-Reply-To: <CAArVCkS9PrZh+v+MM_uoFwDmv43vEpZSgDZNSh3JEjxjTUOw8w@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1570 bytes --]
Philipp Stephani <p.stephani2@gmail.com> schrieb am Sa., 9. Dez. 2017 um
21:58 Uhr:
> Alan Mackenzie <acm@muc.de> schrieb am Sa., 9. Dez. 2017 um 21:55 Uhr:
>
>> Hello, Philipp.
>>
>> On Sat, Dec 09, 2017 at 20:44:35 +0000, Philipp Stephani wrote:
>> > Philipp Stephani <p.stephani2@gmail.com> schrieb am So., 8. Okt. 2017
>> um
>> > 18:59 Uhr:
>>
>> > > Eli Zaretskii <eliz@gnu.org> schrieb am So., 8. Okt. 2017 um 18:38
>> Uhr:
>>
>> > >> > From: Philipp Stephani <p.stephani2@gmail.com>
>> > >> > Date: Sun, 08 Oct 2017 16:25:44 +0000
>> > >> > Cc: eggert@cs.ucla.edu, emacs-devel@gnu.org
>>
>> > >> > Here's a new patch that also fixes the byte compiler tests.
>>
>> > >> Thanks, LGTM, but please mention the NEWS change in the log message.
>>
>> > >> Also, the log message should quote 'like this', not ‘like this’.
>>
>>
>> > > Fixed and pushed as 9613690f6e to master.
>>
>>
>> > I've now fixed the Bovine issue and re-pushed this commit as 8b8197235f
>> to
>> > master.
>>
>> Just as a matter of interest, I think there are still some old style
>> backquotes in advice.el. In master:
>>
>> find . -name '*.el' | xargs grep -n '(` '
>>
>> produces:
>>
>> ./emacs-lisp/advice.el:1517:;; (` (list (, x))))
>> ./emacs-lisp/advice.el:1550:;; (` (progn (print (, x))
>>
>> . Do these need converting?
>>
>>
> Thanks, compiling didn't catch those because they are in comments. Yes,
> they should definitely be fixed. Will send a follow-up patch in a second.
>
Fixed in commit ac6ea59830.
[-- Attachment #2: Type: text/html, Size: 2638 bytes --]
prev parent reply other threads:[~2017-12-09 21:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-03 13:51 Old-style backquotes Philipp Stephani
2017-10-03 14:12 ` Paul Eggert
2017-10-03 14:17 ` [PATCH] Raise an error when detecting old-style backquotes Philipp Stephani
2017-10-03 17:43 ` Stefan Monnier
2017-10-03 18:36 ` Philipp Stephani
2017-10-03 18:52 ` Stefan Monnier
2017-10-08 16:03 ` Philipp Stephani
2017-10-08 19:14 ` Stefan Monnier
2017-10-04 14:12 ` Richard Stallman
2017-10-04 15:30 ` Stefan Monnier
2017-10-05 7:03 ` Richard Stallman
2017-10-06 4:04 ` Stefan Monnier
2017-10-06 15:17 ` Richard Stallman
2017-10-03 15:02 ` Old-style backquotes Eli Zaretskii
2017-10-08 14:58 ` Philipp Stephani
2017-10-08 16:05 ` Eli Zaretskii
2017-10-08 16:09 ` Eli Zaretskii
2017-10-08 16:25 ` Philipp Stephani
2017-10-08 16:38 ` Eli Zaretskii
2017-10-08 16:59 ` Philipp Stephani
2017-12-09 20:44 ` Philipp Stephani
2017-12-09 20:48 ` Alan Mackenzie
2017-12-09 20:58 ` Philipp Stephani
2017-12-09 21:05 ` Philipp Stephani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAArVCkSBNLjeat_jGpDXrY__5WdCLi=zwGnyWVnSzOANBL+OuA@mail.gmail.com' \
--to=p.stephani2@gmail.com \
--cc=acm@muc.de \
--cc=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).