From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: [PATCH PING] Honor 'SOURCE_DATE_EPOCH' when generating autoloads. Date: Wed, 23 Dec 2015 16:52:08 +0000 Message-ID: References: <87k2ph3mgx.fsf@gnu.org> <87io4lnkyz.fsf@gnu.org> <83mvtwoktg.fsf@gnu.org> <878u5gkakj.fsf@gnu.org> <83a8pwoesc.fsf@gnu.org> <87two3475d.fsf@gnu.org> <5665D6B9.4030309@cs.ucla.edu> <5665DAA1.2080208@cs.ucla.edu> <83k2o9t6t1.fsf@gnu.org> <56771D52.2070406@cs.ucla.edu> <83fuytp1au.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a1144496c8619ce0527938bdd X-Trace: ger.gmane.org 1450889564 5130 80.91.229.3 (23 Dec 2015 16:52:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 23 Dec 2015 16:52:44 +0000 (UTC) Cc: eggert@cs.ucla.edu, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 23 17:52:39 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aBmeT-0006AM-Qq for ged-emacs-devel@m.gmane.org; Wed, 23 Dec 2015 17:52:38 +0100 Original-Received: from localhost ([::1]:56891 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBmeT-0006aH-86 for ged-emacs-devel@m.gmane.org; Wed, 23 Dec 2015 11:52:37 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50431) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBmeE-0006aA-0D for emacs-devel@gnu.org; Wed, 23 Dec 2015 11:52:23 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aBmeC-0004tg-PW for emacs-devel@gnu.org; Wed, 23 Dec 2015 11:52:21 -0500 Original-Received: from mail-wm0-x22f.google.com ([2a00:1450:400c:c09::22f]:36326) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBmeA-0004sG-U3; Wed, 23 Dec 2015 11:52:19 -0500 Original-Received: by mail-wm0-x22f.google.com with SMTP id p187so153381954wmp.1; Wed, 23 Dec 2015 08:52:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-type; bh=A5PQiz+gr29w49DKBdc473gjGzP4G/ygerthxUad+FE=; b=f1e/F9sKccTY3xA/vsCB8gxBrMNW0dnqGCpLc7HpwS51PT7WDXxkAcH7zRYICTchN7 foocPnKRmMaaZYqRv3HD8E4WgwJ9YIIONoNiTrg1K+tLdjUWC31oG0bxLqxQjCuaK9mZ 3N2GSOHXLiZCE3bRnJbIjcHsLbrZuMGBlKC8nrKJK+rnx2q04qv7OVvLQzxOuo5Px3fV v9lF2IZD399CnENlKdAfjPC2OdtlUXN2kvColy77xOY5SHqke3d91B4IAYUUxG6TfYxd oxasisP3ZolytPZUgg6kUHZkYEz9CEDJmIMu8nqSuicB1+KwAZtq9fY7HcxXeL0cdOiP MW6g== X-Received: by 10.28.7.14 with SMTP id 14mr32872421wmh.45.1450889538048; Wed, 23 Dec 2015 08:52:18 -0800 (PST) In-Reply-To: <83fuytp1au.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::22f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:196719 Archived-At: --001a1144496c8619ce0527938bdd Content-Type: text/plain; charset=UTF-8 Eli Zaretskii schrieb am Mi., 23. Dez. 2015 um 17:38 Uhr: > > From: Philipp Stephani > > Date: Wed, 23 Dec 2015 16:01:30 +0000 > > > > OK, here's a patch. > > Thanks. A few minor comments. > > > +AC_ARG_ENABLE(deterministic-dump, > > +[AS_HELP_STRING([--enable-deterministic-dump], > > + [Make dumping deterministic by removing system-specific > > + information from the dump, such as host names and > > + timestamps.])]) > > I'd prefer calling this "deterministic-build", so that we could use it > to solve any other similar problems unrelated to dumping. Maybe even > "reproducible-build". > I think we have two categories of builds here: - Builds that get executed when running 'make' in the Emacs directory. This includes dumping and byte compilation of code bundled with Emacs. - Builds that get executed by running an initialized Emacs binary, likely on a different machine. This includes e.g. byte compilation of third-party libraries. I think these two categories are separate enough to have two different variables. This patch only addresses the first category, therefore I didn't want to use the generic term "build", but "dump" is also not quite right. Do we have a proper term for the first category? "bootstrap"? "emacs-build"? > > (If we do change the option, we should also change the name of the > variable and the cpp symbol.) > > > +(defconst emacs-build-system > > + (if deterministic-dump "unknown" (system-name)) > > "Name of the system on which Emacs was built.") > > Can we find a better string, like "elided" or "undisclosed"? > "Unknown" sounds too self-derogatory. > Sure, 'elided' is fine. > > > + DEFVAR_BOOL ("deterministic-dump", Vdeterministic_dump, > > + doc: /* If t, attempt to make dumping deterministic by avoiding > > I think the usual style is "If non-nil". > ok > > > +sources of nondeterminism such as absolute paths, the hostname, or > > GNU coding standards frown on using "path" for anything that isn't > PATH-style list of directories. Please use "file name" instead. > > ok --001a1144496c8619ce0527938bdd Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


Eli Za= retskii <eliz@gnu.org> schrieb am= Mi., 23. Dez. 2015 um 17:38=C2=A0Uhr:
> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Wed, 23 Dec 2015 16:01:30 +0000
>
> OK, here's a patch.

Thanks.=C2=A0 A few minor comments.

> +AC_ARG_ENABLE(deterministic-dump,
> +[AS_HELP_STRING([--enable-deterministic-dump],
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 [Make dumping= deterministic by removing system-specific
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 information f= rom the dump, such as host names and
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 timestamps.])= ])

I'd prefer calling this "deterministic-build", so that we cou= ld use it
to solve any other similar problems unrelated to dumping.=C2=A0 Maybe even<= br> "reproducible-build".

I think= we have two categories of builds here:
- Builds that get execute= d when running 'make' in the Emacs directory. This includes dumping= and byte compilation of code bundled with Emacs.
- Builds that g= et executed by running an initialized Emacs binary, likely on a different m= achine. This includes e.g. byte compilation of third-party libraries.
=
I think these two categories are separate enough to have two different= variables. This patch only addresses the first category, therefore I didn&= #39;t want to use the generic term "build", but "dump" = is also not quite right. Do we have a proper term for the first category? &= quot;bootstrap"? "emacs-build"?
=C2=A0

(If we do change the option, we should also change the name of the
variable and the cpp symbol.)

> +(defconst emacs-build-system
> +=C2=A0 (if deterministic-dump "unknown" (system-name))
>=C2=A0 =C2=A0 "Name of the system on which Emacs was built.")=

Can we find a better string, like "elided" or "undisclosed&q= uot;?
"Unknown" sounds too self-derogatory.

Sure, 'elided' is fine.
=C2=A0

> +=C2=A0 DEFVAR_BOOL ("deterministic-dump", Vdeterministic_du= mp,
> +=C2=A0 =C2=A0 doc: /* If t, attempt to make dumping deterministic by = avoiding

I think the usual style is "If non-nil".
ok
=C2=A0

> +sources of nondeterminism such as absolute paths, the hostname, or
GNU coding standards frown on using "path" for anything that isn&= #39;t
PATH-style list of directories.=C2=A0 Please use "file name" inst= ead.


ok=C2=A0
--001a1144496c8619ce0527938bdd--