From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 74f54af: Use eassume (false) for branch that's never taken. Date: Fri, 19 Apr 2019 11:52:13 +0200 Message-ID: References: <83ftqecrms.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="238717"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Philipp Stephani , Emacs developers To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 19 11:55:03 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hHQEY-000zwa-On for ged-emacs-devel@m.gmane.org; Fri, 19 Apr 2019 11:55:02 +0200 Original-Received: from localhost ([127.0.0.1]:54017 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHQEX-0006Wn-Gw for ged-emacs-devel@m.gmane.org; Fri, 19 Apr 2019 05:55:01 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46002) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHQDi-0006WM-JJ for emacs-devel@gnu.org; Fri, 19 Apr 2019 05:54:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hHQC3-0005zq-IM for emacs-devel@gnu.org; Fri, 19 Apr 2019 05:52:28 -0400 Original-Received: from mail-oi1-x235.google.com ([2607:f8b0:4864:20::235]:41234) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hHQC2-0005yi-5O; Fri, 19 Apr 2019 05:52:26 -0400 Original-Received: by mail-oi1-x235.google.com with SMTP id v7so3677772oie.8; Fri, 19 Apr 2019 02:52:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ue7CfcqWJWbbZ2J/vU2Bz+aIpDCERy8PZdYYJ3MKfb8=; b=Pg9hYeaNBjj6qbicFAGrrgGzt8sIBahyh42cSM7aUmC3WH/3U2p2r9PgT2//BeeRC5 4WCoseDMARaklRl1pVHG2DA/+Vpm0UbxONrkfMBfdWSBzQoRQega02KKxbl5asiL2Js5 PvUl0L8oIUJWeYQIE+x+uAh2RWgd6NYJZj7IjwvR1nuV0v3dOMkBogyY8IP97jnkMyX0 9wW5Nv2E07LiSyrOmgFILxK8agHqljphJSUzBHaHK/e5SPiaxjQDopRCIDUmB0hcGY9M +x0Gt/nbZx0keQfRXGFi5qZXrqgf1O784q0tcAXSTtpp2owM+oPji9GkOleBIO2BZ04d PhAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ue7CfcqWJWbbZ2J/vU2Bz+aIpDCERy8PZdYYJ3MKfb8=; b=aXywl/2DpDnC9WfrsGC58fP53oZfQJhU8akPZWvuhSgIcsn0MVmHVX8lYrk8RH0RfI nQGjWHnH0+dt9frOoEDwbP9AE7w6SFs6pRP4HZsE9/HEjx3GM42FcWAuxv+XQcgNDX8L XbxP8Nb+1CKzhkQzmvEABepGC0yyOKGmLC53lHcXwt+1IzJ29lc1Ot3wk/fezD7LHmBQ WlC1Z9zy9i2jxrjVkZkbGLilhdfgmLVjF1e3QS64Tstw56SUX+f0kp/uzqtjG4HNkZFt m3WOMLk3p1WYqep7td2vuHQ0ZZ4TAgTjRxzUSz415FhC2n/o6L41BKrNXUXDJYpvlPZr owRw== X-Gm-Message-State: APjAAAWxi9v/ypmp3hIRGkwkeTuJnvfeEr+N4iiZPX+h33faF7aLkwap eB7hJZxmHLlLhD/mv33Gatr71qjlghfhJFLebJ6mqA== X-Google-Smtp-Source: APXvYqyJGwYGolYlQj+QWbSm0apwp5pH2HkiqMUz8GOFcGune7b/usfcg6FnaDgbWTWig4OOo0n756pClf/I4IU3ybQ= X-Received: by 2002:aca:47d7:: with SMTP id u206mr1464166oia.9.1555667544898; Fri, 19 Apr 2019 02:52:24 -0700 (PDT) In-Reply-To: <83ftqecrms.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::235 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235649 Archived-At: Am Fr., 19. Apr. 2019 um 10:43 Uhr schrieb Eli Zaretskii : > > Philipp, I don't understand this change. The function in question > should return a Lisp_Object, and AFAIU eassume doesn't do that when > ENABLE_CHECKING is not defined. What am I missing? > The default branch can never be taken. We use eassume(false) in many other places to document this.