From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: Preview: portable dumper Date: Thu, 15 Feb 2018 22:44:10 +0000 Message-ID: References: <20180215193047.GA5448@breton.holly.idiocy.org> <62b22b44-2c40-4cca-a25a-d588353cd1fa@email.android.com> <20180215203525.GA12965@breton.holly.idiocy.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="94eb2c1aac1e013907056547f894" X-Trace: blaine.gmane.org 1518734644 19227 195.159.176.226 (15 Feb 2018 22:44:04 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 15 Feb 2018 22:44:04 +0000 (UTC) Cc: Eli Zaretskii , Daniel Colascione , Angelo Graziosi , emacs-devel@gnu.org To: Alan Third Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 15 23:43:59 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1emSFg-0003R1-Jy for ged-emacs-devel@m.gmane.org; Thu, 15 Feb 2018 23:43:40 +0100 Original-Received: from localhost ([::1]:39113 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emSHg-0003pN-Vt for ged-emacs-devel@m.gmane.org; Thu, 15 Feb 2018 17:45:45 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38155) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emSGQ-0003n0-2Q for emacs-devel@gnu.org; Thu, 15 Feb 2018 17:44:27 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1emSGO-0007VS-Vl for emacs-devel@gnu.org; Thu, 15 Feb 2018 17:44:26 -0500 Original-Received: from mail-lf0-x236.google.com ([2a00:1450:4010:c07::236]:38643) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1emSGM-0007PX-RJ; Thu, 15 Feb 2018 17:44:23 -0500 Original-Received: by mail-lf0-x236.google.com with SMTP id g72so1721869lfg.5; Thu, 15 Feb 2018 14:44:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3PITG2j4s286kzoODRg+qond+Kvsl9fZHoJbRPB0NIM=; b=dcZHdyYG1UjTcZL+C/sgXpKN+uDoqXltvXgGkJ5MHE2WuVhqziGMEaBjstu5f0MKkE nkoBqsCQVRoZzlyNuNFHLkwVP455YBhasIWx/ewkqYbFhv3upHYMtHdetCZVeN9YwPQN xXilgu/fPSgdY30h7FDTb61MW/ElMaNyNk029vU6fs+a6v4fEwZYACTOMBZUkvHZQomo jZfYKWltqmlSetua+GWGV0rhxJ9H9ilw5yCUlaB5mnOm0uTrKHR446A9/ulzDcYQwNl/ 6rbQD+xOsQK/2OdX0hPcETlmLFHZniw3ms+waMcx4VgKqyDNkrN4M44c8GMZRA4z9Eyu 5w4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3PITG2j4s286kzoODRg+qond+Kvsl9fZHoJbRPB0NIM=; b=cWWE+CFoq/5s6+Q2sOAKeaSWu2sh1rgTnFgcgC228NQwoQMpaGP8PaBZhSHoyJJULO WYzphBjXMUA45Q6MfDwrUuNp9EidpkIdcKLB/nkZdATx6+WwelVHUKVBr3sAG/NLU3XM SAzKK0MLJXcOPHwVh8PuCZ95OQxl+J6hoDJfMaDQ5WuURbM+0GtQPRcJt6xyRSag4YFV bmTJN5f7N02293qPE6FvjmfFCavWl5B06UHDzBnraAYueiVTKUvlhdf4KXtjT6uoHhIT q2bxD4oFKFkgs806OVzvaq9YxFz7fxoAhAqBdr4C3XYFEVoBjXo0BvJphAU56YDQK0GU 2j1w== X-Gm-Message-State: APf1xPD6VFmIU4Yzwg8wqIXO73LqMk0EDO6ZaT0ZbWZLNhKgsg5pxPUC RH6rteiGR35SmYNKCdzoHSY2AhwbvBwAbNc7O+E= X-Google-Smtp-Source: AH8x22506f1XkQpREtqBaQFRxRRAM/FnJsF56D06ZKSDFDFInpnT/sRctuMhSMqto66HNVdOpz6N0DRAVEpIeqp0eds= X-Received: by 10.46.77.68 with SMTP id a65mr2776003ljb.100.1518734661456; Thu, 15 Feb 2018 14:44:21 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::236 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222781 Archived-At: --94eb2c1aac1e013907056547f894 Content-Type: multipart/alternative; boundary="94eb2c1aac1e013903056547f892" --94eb2c1aac1e013903056547f892 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Philipp Stephani schrieb am Do., 15. Feb. 2018 um 23:38 Uhr: > Alan Third schrieb am Do., 15. Feb. 2018 um 21:36 Uhr: > >> On Thu, Feb 15, 2018 at 11:49:30AM -0800, Daniel Colascione wrote: >> > Thanks for checking. If you disable Wconversion at the top of the >> > file, you should be able to unblock yourself. The warning helps make >> > the code robust, but it's annoying to account for compiler >> > differences. >> >> Thanks, I=E2=80=99ve got it to build and it seems to work fine. >> >> Here are the changes I had to make: >> >> 3 files changed, 15 insertions(+), 15 deletions(-) >> src/dispnew.c | 2 +- >> src/macfont.m | 26 +++++++++++++------------- >> src/pdumper.c | 2 +- >> > > Another minor thing (that breaks the build with -Werror) is that the > functions set_{marker,vectorlike}_marked are unused. Same with > syms_of_nsfns_1. I also had to change the eassert(("...", 0)) to > eassert("..." && 0) to stop the compiler from complaining about an unused > expression. > This is the patch that I've applied: --94eb2c1aac1e013903056547f892 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Philip= p Stephani <p.stephani2@gmail.c= om> schrieb am Do., 15. Feb. 2018 um 23:38=C2=A0Uhr:
Alan Third <alan@idiocy.org> schrieb am Do., 15. Feb. 2018 um 21:36=C2=A0Uhr= :
On Thu, Feb 15, 2018 at 11:49:30A= M -0800, Daniel Colascione wrote:
> Thanks for checking. If you disable Wconversion at the top of the
> file, you should be able to unblock yourself. The warning helps make > the code robust, but it's annoying to account for compiler
> differences.

Thanks, I=E2=80=99ve got it to build and it seems to work fine.

Here are the changes I had to make:

3 files changed, 15 insertions(+), 15 deletions(-)
src/dispnew.c |=C2=A0 2 +-
src/macfont.m | 26 +++++++++++++-------------
src/pdumper.c |=C2=A0 2 +-

Another minor thing (that breaks the build with -Werror) is t= hat the functions set_{marker,vectorlike}_marked are unused. Same with syms= _of_nsfns_1. I also had to change the eassert(("...", 0)) to eass= ert("..." && 0) to stop the compiler from complaining abo= ut an unused expression.=C2=A0

This is the patch that I've applied:=C2=A0
--94eb2c1aac1e013903056547f892-- --94eb2c1aac1e013907056547f894 Content-Type: text/plain; charset="US-ASCII"; name="pdump-patch.txt" Content-Disposition: attachment; filename="pdump-patch.txt" Content-Transfer-Encoding: base64 Content-ID: <1619ba38194c9731fa11> X-Attachment-Id: 1619ba38194c9731fa11 ZGlmZiAtLWdpdCBhL3NyYy9hbGxvYy5jIGIvc3JjL2FsbG9jLmMKaW5kZXggOTBmOTEzZGEzNi4u NmY4MTE5NWNjMyAxMDA2NDQKLS0tIGEvc3JjL2FsbG9jLmMKKysrIGIvc3JjL2FsbG9jLmMKQEAg LTM3OCw3ICszNzgsNiBAQCBpbmxpbmUgc3RhdGljIGJvb2wgdmVjdG9yX21hcmtlZF9wIChjb25z dCBzdHJ1Y3QgTGlzcF9WZWN0b3IgKnYpOwogaW5saW5lIHN0YXRpYyB2b2lkIHNldF92ZWN0b3Jf bWFya2VkIChzdHJ1Y3QgTGlzcF9WZWN0b3IgKnYpOwogCiBpbmxpbmUgc3RhdGljIGJvb2wgdmVj dG9ybGlrZV9tYXJrZWRfcCAoY29uc3QgdW5pb24gdmVjdG9ybGlrZV9oZWFkZXIgKnYpOwotaW5s aW5lIHN0YXRpYyB2b2lkIHNldF92ZWN0b3JsaWtlX21hcmtlZCAodW5pb24gdmVjdG9ybGlrZV9o ZWFkZXIgKnYpOwogCiBpbmxpbmUgc3RhdGljIGJvb2wgY29uc19tYXJrZWRfcCAoY29uc3Qgc3Ry dWN0IExpc3BfQ29ucyAqYyk7CiBpbmxpbmUgc3RhdGljIHZvaWQgc2V0X2NvbnNfbWFya2VkIChz dHJ1Y3QgTGlzcF9Db25zICpjKTsKQEAgLTM5Myw3ICszOTIsNiBAQCBpbmxpbmUgc3RhdGljIGJv b2wgbWlzY19hbnlfbWFya2VkX3AgKGNvbnN0IHN0cnVjdCBMaXNwX01pc2NfQW55ICptKTsKIGlu bGluZSBzdGF0aWMgdm9pZCBzZXRfbWlzY19hbnlfbWFya2VkIChzdHJ1Y3QgTGlzcF9NaXNjX0Fu eSAqbSk7CiAKIGlubGluZSBzdGF0aWMgYm9vbCBtYXJrZXJfbWFya2VkX3AgKGNvbnN0IHN0cnVj dCBMaXNwX01hcmtlciAqbSk7Ci1pbmxpbmUgc3RhdGljIHZvaWQgc2V0X21hcmtlcl9tYXJrZWQg KHN0cnVjdCBMaXNwX01hcmtlciAqbSk7CiAKIGlubGluZSBzdGF0aWMgYm9vbCBvdmVybGF5X21h cmtlZF9wIChjb25zdCBzdHJ1Y3QgTGlzcF9PdmVybGF5ICptKTsKIGlubGluZSBzdGF0aWMgdm9p ZCBzZXRfb3ZlcmxheV9tYXJrZWQgKHN0cnVjdCBMaXNwX092ZXJsYXkgKm0pOwpAQCAtNDE1MCwx MiArNDE0OCw2IEBAIHZlY3Rvcmxpa2VfbWFya2VkX3AgKGNvbnN0IHVuaW9uIHZlY3Rvcmxpa2Vf aGVhZGVyICpoZWFkZXIpCiAgIHJldHVybiB2ZWN0b3JfbWFya2VkX3AgKChjb25zdCBzdHJ1Y3Qg TGlzcF9WZWN0b3IgKikgaGVhZGVyKTsKIH0KIAotc3RhdGljIHZvaWQKLXNldF92ZWN0b3JsaWtl X21hcmtlZCAodW5pb24gdmVjdG9ybGlrZV9oZWFkZXIgKmhlYWRlcikKLXsKLSAgc2V0X3ZlY3Rv cl9tYXJrZWQgKChzdHJ1Y3QgTGlzcF9WZWN0b3IgKikgaGVhZGVyKTsKLX0KLQogc3RhdGljIGJv b2wKIGNvbnNfbWFya2VkX3AgKGNvbnN0IHN0cnVjdCBMaXNwX0NvbnMgKmMpCiB7CkBAIC00MjMw LDEyICs0MjIyLDYgQEAgbWFya2VyX21hcmtlZF9wIChjb25zdCBzdHJ1Y3QgTGlzcF9NYXJrZXIg Km0pCiAgIHJldHVybiBtaXNjX2FueV9tYXJrZWRfcCAoKHN0cnVjdCBMaXNwX01pc2NfQW55ICop IG0pOwogfQogCi1zdGF0aWMgdm9pZAotc2V0X21hcmtlcl9tYXJrZWQgKHN0cnVjdCBMaXNwX01h cmtlciAqbSkKLXsKLSAgc2V0X21pc2NfYW55X21hcmtlZCAoKHN0cnVjdCBMaXNwX01pc2NfQW55 ICopIG0pOwotfQotCiBzdGF0aWMgYm9vbAogb3ZlcmxheV9tYXJrZWRfcCAoY29uc3Qgc3RydWN0 IExpc3BfT3ZlcmxheSAqbSkKIHsKZGlmZiAtLWdpdCBhL3NyYy9tYWNmb250Lm0gYi9zcmMvbWFj Zm9udC5tCmluZGV4IDM3N2ZjM2ZhNDguLjJjYmUwN2Q3NTEgMTAwNjQ0Ci0tLSBhL3NyYy9tYWNm b250Lm0KKysrIGIvc3JjL21hY2ZvbnQubQpAQCAtMTY0Niw3ICsxNjQ2LDcgQEAgc3RhdGljIGlu dCBtYWNmb250X3ZhcmlhdGlvbl9nbHlwaHMgKHN0cnVjdCBmb250ICosIGludCBjLAogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIHZhcmlhdGlvbnNbMjU2XSk7 CiBzdGF0aWMgdm9pZCBtYWNmb250X2ZpbHRlcl9wcm9wZXJ0aWVzIChMaXNwX09iamVjdCwgTGlz cF9PYmplY3QpOwogCi1zdGF0aWMgc3RydWN0IGZvbnRfZHJpdmVyIGNvbnN0IG1hY2ZvbnRfZHJp dmVyID0KK3N0YXRpYyBzdHJ1Y3QgZm9udF9kcml2ZXIgbWFjZm9udF9kcml2ZXIgPQogICB7CiAg IC50eXBlID0gTElTUFNZTV9JTklUSUFMTFkgKFFtYWNfY3QpLAogICAuZ2V0X2NhY2hlID0gbWFj Zm9udF9nZXRfY2FjaGUsCkBAIC00MDM0LDYgKzQwMzQsOCBAQCBTbyB3ZSB1c2UgQ1RGb250RGVz Y3JpcHRvckNyZWF0ZU1hdGNoaW5nRm9udERlc2NyaXB0b3IgKG5vCiAKIAwKIAorc3RhdGljIHZv aWQgc3ltc19vZl9tYWNmb250X2Zvcl9wZHVtcGVyICh2b2lkKTsKKwogdm9pZAogc3ltc19vZl9t YWNmb250ICh2b2lkKQogewpkaWZmIC0tZ2l0IGEvc3JjL25zZm5zLm0gYi9zcmMvbnNmbnMubQpp bmRleCA4OTExYWQyN2ZlLi5jMmVlNGRmMzNmIDEwMDY0NAotLS0gYS9zcmMvbnNmbnMubQorKysg Yi9zcmMvbnNmbnMubQpAQCAtMzE5NiwxMiArMzE5Niw2IEBAIC0gKE5TU3RyaW5nICopcGFuZWw6 IChpZClzZW5kZXIgdXNlckVudGVyZWRGaWxlbmFtZTogKE5TU3RyaW5nICopZmlsZW5hbWUKIAog ICAgPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0gKi8KIAotc3RhdGljIHZvaWQKLXN5bXNfb2ZfbnNmbnNfMSAo dm9pZCkKLXsKLQotfQotCiB2b2lkCiBzeW1zX29mX25zZm5zICh2b2lkKQogewpkaWZmIC0tZ2l0 IGEvc3JjL3BkdW1wZXIuYyBiL3NyYy9wZHVtcGVyLmMKaW5kZXggNDk5YzhkYzI3Yy4uNzA1M2U1 MmFkNiAxMDA2NDQKLS0tIGEvc3JjL3BkdW1wZXIuYworKysgYi9zcmMvcGR1bXBlci5jCkBAIC0y OTE3LDcgKzI5MTcsNyBAQCBkdW1wX29iamVjdF8xIChzdHJ1Y3QgZHVtcF9jb250ZXh0ICpjdHgs IExpc3BfT2JqZWN0IG9iamVjdCkKICAgICAgICAgICBvZmZzZXQgPSBkdW1wX2Zsb2F0IChjdHgs IFhGTE9BVCAob2JqZWN0KSk7CiAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2VfTGlzcF9J bnQ6Ci0gICAgICAgICAgZWFzc2VydCAoKCJzaG91bGQgbm90IGJlIGR1bXBpbmcgaW50OiBpcyBz ZWxmLXJlcHJlc2VudGluZyIsIDApKTsKKyAgICAgICAgICBlYXNzZXJ0ICgic2hvdWxkIG5vdCBi ZSBkdW1waW5nIGludDogaXMgc2VsZi1yZXByZXNlbnRpbmciICYmIGZhbHNlKTsKICAgICAgICAg ZGVmYXVsdDoKICAgICAgICAgICBlbWFjc19hYm9ydCAoKTsKICAgICAgICAgfQo= --94eb2c1aac1e013907056547f894--