From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani
Philipp Stephani wrote:<= br> > Here's a new patch. It makes this change, and also changes the all= ocation
> slightly so that objects have unique addresses (useful for checking).<= br>
Thanks for working on this. Some comments.
Have you looked into the runtime overhead of this approach, assuming
-module-assertions is not specified? Currently lisp_to_value and value_to_l= isp
typically=C2=A0 are optimized away (i.e., zero machine instructions), and t= hat
wouldn't be true under the proposed patch even when -module-assertions = is not
used. Granted, module calls need not be super-fast, but it might be nice to=
avoid the overhead in the typical case if that is easy.
Or vice = versa.
Are the FOR_EACH_TAIL_SAFE macro calls needed? This macro is needed only fo= r
lists that might be circular (e.g., the lists are available to Lisp code, w= hich
can call setcdr on their components). If the calls are not needed I suggest= just
an ordinary for loop.
A small point: the FOR_EACH... loops should be indented like ordinary for-l= oops.