From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: Preview: portable dumper Date: Thu, 15 Feb 2018 22:38:13 +0000 Message-ID: References: <20180215193047.GA5448@breton.holly.idiocy.org> <62b22b44-2c40-4cca-a25a-d588353cd1fa@email.android.com> <20180215203525.GA12965@breton.holly.idiocy.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a113fba22b2e11b056547e267" X-Trace: blaine.gmane.org 1518735372 24304 195.159.176.226 (15 Feb 2018 22:56:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 15 Feb 2018 22:56:12 +0000 (UTC) Cc: Eli Zaretskii , Daniel Colascione , Angelo Graziosi , emacs-devel@gnu.org To: Alan Third Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 15 23:56:07 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1emSRe-0005iq-Kc for ged-emacs-devel@m.gmane.org; Thu, 15 Feb 2018 23:56:02 +0100 Original-Received: from localhost ([::1]:40526 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emSTg-0000Ta-93 for ged-emacs-devel@m.gmane.org; Thu, 15 Feb 2018 17:58:08 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36605) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emSAe-0006R0-R6 for emacs-devel@gnu.org; Thu, 15 Feb 2018 17:38:29 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1emSAd-00031c-Ri for emacs-devel@gnu.org; Thu, 15 Feb 2018 17:38:28 -0500 Original-Received: from mail-lf0-x22a.google.com ([2a00:1450:4010:c07::22a]:43948) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1emSAb-0002zl-TR; Thu, 15 Feb 2018 17:38:26 -0500 Original-Received: by mail-lf0-x22a.google.com with SMTP id q69so1682736lfi.10; Thu, 15 Feb 2018 14:38:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6nqfUvJkER1zMvtdaseY3dG9vCTBkl38+vYwXZqqEN8=; b=K2S7LcWAChWH2Y3lnuTVT7+yAGahDI9E33CzmJ+4f318bGuNSnkoGquDM+XEUlHkqX u5yIInEUzjBcfxAYPiZwy1GlCwcZb4j0dtbbU84mb7I2zQMpyzncQV0hfkWiKwLx7JiS w6UyURYp77IE3d1cKHvyKgzxKEd5g/B6lFGSa2Rx+6Kb+3VT7Pzad7VpmXkW21diQ0t9 59Ejdu1ZvcMG3+A/7Lb13pbUUBty/F/5u0uGjC/uQdXo5IXOsv8PhiEWAgqcbxKof6bz EN2uvL8qDHi1gfrHvRdadxCh2ovjWlqOvGKn/30FqTXN067N4aniSNLTc31yq8gATr7S +iKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6nqfUvJkER1zMvtdaseY3dG9vCTBkl38+vYwXZqqEN8=; b=cvVK1FDk6ofWi96MArkip0zkxZmk93f5pF3tqS3CmYg/2tNY5caorjErHKLMmpdPM8 uYU9pZ87a+qNozsAbO7wbVvX0UKJdztl/0EsnTsWzlWNVrB6YJ6UUvyR+Mw5UOy784ZM eNsKA5NeTHqBZQKQEWGs+dYBrYM3iGmPhog9N2C67X5KHfRs4AU0RBqaYCYUT7tjEg73 5MyLgjfRZHlb6ZgpT7IlRqjAwtO0BeWvlIYsX9/UAfbvYLsxEK1ynb3WQAnHxBusFKFA ogvpG6n3ya1uAgu7WF15dQv/NfoGliSB4/wwFKI/sWGW8KXs5RS86WZx3dIB481wAbpy +VgA== X-Gm-Message-State: APf1xPDzK6CI+1AaBkQUKsht6m6R8C+EoaGGn4krV5P9v3OC55zZLjte G66OKpCksM0/6d4HaK+qpfe7YqSQTLZgWpLM4UYFtQ== X-Google-Smtp-Source: AH8x225wE0rBTSpH94Q7LLOXaZa2z46k3DQfqRZCDqmsVL163bzcnZhrIL1iJbK/cyHAXV9Hy8nrwwybJEa9eLDC+MA= X-Received: by 10.25.16.66 with SMTP id f63mr2492801lfi.113.1518734304008; Thu, 15 Feb 2018 14:38:24 -0800 (PST) In-Reply-To: <20180215203525.GA12965@breton.holly.idiocy.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::22a X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222784 Archived-At: --001a113fba22b2e11b056547e267 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Alan Third schrieb am Do., 15. Feb. 2018 um 21:36 Uhr: > On Thu, Feb 15, 2018 at 11:49:30AM -0800, Daniel Colascione wrote: > > Thanks for checking. If you disable Wconversion at the top of the > > file, you should be able to unblock yourself. The warning helps make > > the code robust, but it's annoying to account for compiler > > differences. > > Thanks, I=E2=80=99ve got it to build and it seems to work fine. > > Here are the changes I had to make: > > 3 files changed, 15 insertions(+), 15 deletions(-) > src/dispnew.c | 2 +- > src/macfont.m | 26 +++++++++++++------------- > src/pdumper.c | 2 +- > Another minor thing (that breaks the build with -Werror) is that the functions set_{marker,vectorlike}_marked are unused. Same with syms_of_nsfns_1. I also had to change the eassert(("...", 0)) to eassert("..." && 0) to stop the compiler from complaining about an unused expression. --001a113fba22b2e11b056547e267 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Alan T= hird <alan@idiocy.org> schrieb= am Do., 15. Feb. 2018 um 21:36=C2=A0Uhr:
On Thu, Feb 15, 2018 at 11:49:30AM -0800, Daniel Colascione wrote: > Thanks for checking. If you disable Wconversion at the top of the
> file, you should be able to unblock yourself. The warning helps make > the code robust, but it's annoying to account for compiler
> differences.

Thanks, I=E2=80=99ve got it to build and it seems to work fine.

Here are the changes I had to make:

3 files changed, 15 insertions(+), 15 deletions(-)
src/dispnew.c |=C2=A0 2 +-
src/macfont.m | 26 +++++++++++++-------------
src/pdumper.c |=C2=A0 2 +-

Another minor thing (that breaks the build= with -Werror) is that the functions set_{marker,vectorlike}_marked are unu= sed. Same with syms_of_nsfns_1. I also had to change the eassert(("...= ", 0)) to eassert("..." && 0) to stop the compiler f= rom complaining about an unused expression.=C2=A0
--001a113fba22b2e11b056547e267--