From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 db436e9: Don't call debug on failed cl-assert Date: Sun, 06 Nov 2016 19:03:08 +0000 Message-ID: References: <20161105015720.6371.89806@vcs.savannah.gnu.org> <20161105015720.88A6322012D@vcs.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a114699d072155a0540a68f82 X-Trace: blaine.gmane.org 1478459058 18049 195.159.176.226 (6 Nov 2016 19:04:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 6 Nov 2016 19:04:18 +0000 (UTC) Cc: Noam Postavsky To: Stefan Monnier , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 06 20:04:14 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c3SjZ-0002rl-E0 for ged-emacs-devel@m.gmane.org; Sun, 06 Nov 2016 20:04:01 +0100 Original-Received: from localhost ([::1]:46456 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3Sjc-0003zD-8V for ged-emacs-devel@m.gmane.org; Sun, 06 Nov 2016 14:04:04 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35741) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3Siv-0003xm-Di for emacs-devel@gnu.org; Sun, 06 Nov 2016 14:03:22 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c3Siu-0007z8-Di for emacs-devel@gnu.org; Sun, 06 Nov 2016 14:03:21 -0500 Original-Received: from mail-wm0-x22f.google.com ([2a00:1450:400c:c09::22f]:36332) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c3Siu-0007yM-6E for emacs-devel@gnu.org; Sun, 06 Nov 2016 14:03:20 -0500 Original-Received: by mail-wm0-x22f.google.com with SMTP id p190so144386330wmp.1 for ; Sun, 06 Nov 2016 11:03:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AC2l587XqyhVrPAldgGcFOp7kPWvPj/NPFTInr17/EE=; b=A8vaXwS/p8DIu7NIDiBFhjt2koUyMbKcsmRU9O7ELVaeNgnTy0MlNWZMpfhSlja0pu 2tFxsXVl/x4l1ZIRd+PIUlCK134OaBMWW441VLsSrdaQIxxdz0JlGDWRhneTvQtMAetR 6twA+kCxwvP2HOnHgEYpcpyBdQdJMJ64S5KCyExqaZksJCbkt315ubzDfjsNpXn0/9W9 xAmg5arhgfpQTL9vAPD8H6tw162c8ZG8A+br5lsbGTLPtnueAbmMjBUWHBBKW8UXcxqO 3d/REGBWwFfI7pA1oO36vxxBNQypt2LJz9tDDv6KmY1MULiP39Koc/hmUUQ5S+dToP8r 9kvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AC2l587XqyhVrPAldgGcFOp7kPWvPj/NPFTInr17/EE=; b=btigrLqnmhw1oCyEfKuDwoRup3BmNobui/u8ts0bzbITytASu6fAqbdAwNTqyDUYlB xcF+Xa69A+gGN7ckfm21lxpvszyh2FikNKDKwca15qs6TuArQSZgmGnkdtXMbb0Bf6LN nJlDNiGW43Kt6SH6cOXDYm+dJiP8q0SMBQ3PDMVjThcXuei+fg7YRPuWFnZ4UA6p+rDB erj3/h00P5AkXQfH2SQR1Cg+02w0tTeq6emUACg2q/sg/H9BY9LgiCzdrqg45Myobz6x brzUGY1nmy//Rr2YWGUrctaxSMCpGD666J4HayeC/Jr5ElCZuVDOR4nrT4JT6mX3Pmtq mAdg== X-Gm-Message-State: ABUngveU6KuCkOuHpDxMUIVj9zqCgAPdfQhoL2E3twIHohw3GpISR0vSa10RVPrc0pB/Q5pxTF+WNVD9MbmOHw== X-Received: by 10.28.210.1 with SMTP id j1mr3851050wmg.86.1478458998918; Sun, 06 Nov 2016 11:03:18 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::22f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:209223 Archived-At: --001a114699d072155a0540a68f82 Content-Type: text/plain; charset=UTF-8 Stefan Monnier schrieb am So., 6. Nov. 2016 um 18:39 Uhr: > > Doing this causes problems when running ert tests > > Can it be fixed somewhere else? > > ERT should not have to install a debugger to do its job. Rather, condition-case should be extended to be able to catch all signals ( https://debbugs.gnu.org/cgi/bugreport.cgi?bug=24618) and should get direct access to the backtrace (https://debbugs.gnu.org/cgi/bugreport.cgi?bug=24617 ). --001a114699d072155a0540a68f82 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


Stefan= Monnier <monnier@iro.umontr= eal.ca> schrieb am So., 6. Nov. 2016 um 18:39=C2=A0Uhr:
> Doing this causes problems when running er= t tests

Can it be fixed somewhere else?


ERT should not have to install a debugger = to do its job. Rather, condition-case should be extended to be able to catc= h all signals (https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D24618) and should= get direct access to the backtrace (https://debbugs.gnu.org/cgi/bugreport.cgi?bug= =3D24617).=C2=A0
--001a114699d072155a0540a68f82--