From mboxrd@z Thu Jan 1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Philipp Stephani
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH] Ignore pending_signals when checking for quits.
Date: Sun, 28 Apr 2019 20:19:42 +0200
Message-ID:
References: <83y36nl7rl.fsf@gnu.org> <20190211201739.25229-1-phst@google.com>
<834l97pv0l.fsf@gnu.org>
<83y345bvk6.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
logging-data="71936"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: Philipp Stephani , Emacs developers
To: Eli Zaretskii
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 28 20:20:17 2019
Return-path:
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256)
(Exim 4.89)
(envelope-from )
id 1hKoPQ-000IeO-Q8
for ged-emacs-devel@m.gmane.org; Sun, 28 Apr 2019 20:20:16 +0200
Original-Received: from localhost ([127.0.0.1]:47175 helo=lists.gnu.org)
by lists.gnu.org with esmtp (Exim 4.71)
(envelope-from )
id 1hKoPP-0006Lv-RU
for ged-emacs-devel@m.gmane.org; Sun, 28 Apr 2019 14:20:15 -0400
Original-Received: from eggs.gnu.org ([209.51.188.92]:45078)
by lists.gnu.org with esmtp (Exim 4.71)
(envelope-from ) id 1hKoP1-00069W-6G
for emacs-devel@gnu.org; Sun, 28 Apr 2019 14:19:52 -0400
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
(envelope-from ) id 1hKoOy-00038S-1w
for emacs-devel@gnu.org; Sun, 28 Apr 2019 14:19:49 -0400
Original-Received: from mail-oi1-x241.google.com ([2607:f8b0:4864:20::241]:46803)
by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
(Exim 4.71) (envelope-from )
id 1hKoOt-000351-Fn; Sun, 28 Apr 2019 14:19:43 -0400
Original-Received: by mail-oi1-x241.google.com with SMTP id d62so816195oib.13;
Sun, 28 Apr 2019 11:19:43 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=mime-version:references:in-reply-to:from:date:message-id:subject:to
:cc; bh=fBbElCkU6rqgiNgbn//AIxz4GSJABZv38/Mm4EYX8Zk=;
b=ctTE3uvBqjL5HlNkpWUkTPvMqd9U5UYIoTwg549UA/xPmyLNS5lahxW7/xCl6wc6qZ
zgPT7CU8E1BCFpWCzoAUDxjSoQSr9J/ODFcf6kQcfNO2Q+xwpS81x4Bh/jvWvVfzEB4V
473EO3ILBl9NU45HlA3o8ZIVs5W/OYMu8RZtD3SlvpmpCIJmOMtJkD7KXLHbMz9+Dgl8
LWeeTCgORxDmrWg9RsopyzSa8DiT8vp1Lw1PhsAMCEXOiCW5f8sMraUFellxkTOVci+g
UmnXGJXoVpryra5782f5bMiyaPgofdLcfcPbxI+UHKhtlWms6rGcGTfs37DolXNQgOGN
MTXA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=fBbElCkU6rqgiNgbn//AIxz4GSJABZv38/Mm4EYX8Zk=;
b=VVoJYoD9C7xPbQ4HC9fQJBrbIXy4I99hmpGFtJrMugXEz44c4V3GIYUpyI+mt8vYKj
TT7HjTb3h75ei4DrqtD9NpKznjLfsd0eMD6JY8DG3ISYew6nnCLgmTLdS8sHFj2WX5MU
rnu58IKvQaS9KygObWvh7Jukelaio0JVia1mG9NBpScGEMAwUQm4S/Ss5w5oFrzXVAj/
JSBV7+THCai0WFP1nPMUCWGtmRa3/3uq2r/dpwk04bN8/4JaLN2M/Y7h+FUWMRXU3MQz
c4ShcS1cTi1QuBWKJWmN5j+od/GLsBX3chMVCkA5sYuoTIBlWUDDpYw9pk5cPhtAo2jK
jH4g==
X-Gm-Message-State: APjAAAUNc6XLmk59pH7JSrfsOQ1UirRIq+wJrSVUz7glEkFOd3TmgJyg
ZCaAoVSe6IFyq50S2N9d7U6ITOMsgm4CZNeFwRdsg1ar
X-Google-Smtp-Source: APXvYqw3qQLx+Q2aBgvhDaMWCr39wXXgY9ovyedlnTWJPidCGxiNErjSGeiqUrgT1ZAwPlJDChVg60QjaeCEe2AGerw=
X-Received: by 2002:aca:47d7:: with SMTP id u206mr14431173oia.9.1556475581929;
Sun, 28 Apr 2019 11:19:41 -0700 (PDT)
In-Reply-To: <83y345bvk6.fsf@gnu.org>
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
recognized.
X-Received-From: 2607:f8b0:4864:20::241
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions."
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel"
Xref: news.gmane.org gmane.emacs.devel:236011
Archived-At:
Am Fr., 19. Apr. 2019 um 22:16 Uhr schrieb Eli Zaretskii :
>
> > From: Philipp Stephani
> > Date: Fri, 19 Apr 2019 21:06:48 +0200
> > Cc: Emacs developers , Philipp Stephani
> >
> > Question: Would it be OK to backport the first part (using QUITP in
> > module_should_quit) to Emacs 26.3?
>
> Please show the part that you suggest to backport, I don't think I
> understand what that is.
The initial patch, i.e.
--- a/src/emacs-module.c
+++ b/src/emacs-module.c
@@ -671,13 +671,13 @@ module_vec_size (emacs_env *env, emacs_value vec)
return ASIZE (lvec);
}
-/* This function should return true if and only if maybe_quit would do
- anything. */
+/* This function should return true if and only if maybe_quit would
+ quit. */
static bool
module_should_quit (emacs_env *env)
{
MODULE_FUNCTION_BEGIN_NO_CATCH (false);
- return (! NILP (Vquit_flag) && NILP (Vinhibit_quit)) || pending_signals;
+ return QUITP;
}