From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: Dynamic modules: MODULE_HANDLE_SIGNALS etc. Date: Sun, 20 Dec 2015 18:27:19 +0000 Message-ID: References: <83mvu1x6t3.fsf@gnu.org> <565779CD.80405@cs.ucla.edu> <83io4nuc68.fsf@gnu.org> <83poy1t927.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a1130cd24627fd6052758865d X-Trace: ger.gmane.org 1450636073 4571 80.91.229.3 (20 Dec 2015 18:27:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 20 Dec 2015 18:27:53 +0000 (UTC) Cc: aurelien.aptel+emacs@gmail.com, tzz@lifelogs.com, eggert@cs.ucla.edu, dancol@dancol.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Dec 20 19:27:47 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aAihu-0004qt-Fe for ged-emacs-devel@m.gmane.org; Sun, 20 Dec 2015 19:27:46 +0100 Original-Received: from localhost ([::1]:41609 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aAiht-0004My-OO for ged-emacs-devel@m.gmane.org; Sun, 20 Dec 2015 13:27:45 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56204) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aAihg-0004MZ-FN for emacs-devel@gnu.org; Sun, 20 Dec 2015 13:27:33 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aAihf-0003bW-HA for emacs-devel@gnu.org; Sun, 20 Dec 2015 13:27:32 -0500 Original-Received: from mail-wm0-x22d.google.com ([2a00:1450:400c:c09::22d]:37614) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aAihd-0003aD-Dw; Sun, 20 Dec 2015 13:27:29 -0500 Original-Received: by mail-wm0-x22d.google.com with SMTP id p187so44020938wmp.0; Sun, 20 Dec 2015 10:27:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-type; bh=mhfwyui8EyP9Pt5G5qVQaG4+P6kpm2kezuQMpTretgQ=; b=Uq70OacBsvMMLySEt552LGoeTaJstAxVTcUOYapiWBPxDIz/UT2/5g3xTdkLVo1+kp E7BbiXnJkpg9AAn7BNTkABO7kxDrvkmQFJAcykAbLO6yWWQvATLd0VNK0Svp4YTSJ59+ Loe/RvYHar2JwyrA4HuncOuZMydkwh/Q34weSCHlv+QLARi5W73O1AwSWffGJrpV3jgI cI+0KdE/SO2G1qFilLPMWTwrQLHXj/RqJ++1i6hHmRasvtNgvugVpCy6DTIcUG6Rf1dj z+3B0mt5mnz4Q/z6XFUmeYOFLr0pQK1b9tYboiUUIMriUFNTl9/yscaFjWn1FR846oaf xj9Q== X-Received: by 10.194.116.170 with SMTP id jx10mr15746426wjb.166.1450636048759; Sun, 20 Dec 2015 10:27:28 -0800 (PST) In-Reply-To: <83poy1t927.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::22d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:196557 Archived-At: --001a1130cd24627fd6052758865d Content-Type: text/plain; charset=UTF-8 Eli Zaretskii schrieb am So., 20. Dez. 2015 um 16:48 Uhr: > > From: Philipp Stephani > > Date: Sat, 19 Dec 2015 21:03:32 +0000 > > Cc: dancol@dancol.org, tzz@lifelogs.com, aurelien.aptel+emacs@gmail.com, > > emacs-devel@gnu.org > > > > Here's another patch that replaces some of the custom error handling with > > signals. The signals will be immediately caught by the prologue, but some > > complexity and duplication is removed. > > Thanks. Did you run the mod-test test suite, yes > and did you make sure > that signaling an error from a module still reports the same > information and backtrace as before the change? > No, but I wouldn't know how the patch should change this. It only changes an implementation detail in the error reporting code of the module implementation itself. If we wanted to check the backtrace, I think we should rather add a unit test for it. --001a1130cd24627fd6052758865d Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


Eli Za= retskii <eliz@gnu.org> schrieb am= So., 20. Dez. 2015 um 16:48=C2=A0Uhr:
> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Sat, 19 Dec 2015 21:03:32 +0000
> Cc: dancol@danc= ol.org, tzz@lifel= ogs.com, aurelien.aptel+emacs@gmail.com,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0emacs-devel@gnu.org
>
> Here's another patch that replaces some of the custom error handli= ng with
> signals. The signals will be immediately caught by the prologue, but s= ome
> complexity and duplication is removed.

Thanks.=C2=A0 Did you run the mod-test test suite,

yes
=C2=A0
and did= you make sure
that signaling an error from a module still reports the same
information and backtrace as before the change?

No, but I wouldn't know how the patch should change this. It o= nly changes an implementation detail in the error reporting code of the mod= ule implementation itself.
If we wanted to check the backtrace, I= think we should rather add a unit test for it.=C2=A0
--001a1130cd24627fd6052758865d--