From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: Dynamic modules: MODULE_HANDLE_SIGNALS etc. Date: Sun, 20 Dec 2015 21:00:54 +0000 Message-ID: References: <83mvu1x6t3.fsf@gnu.org> <565779CD.80405@cs.ucla.edu> <83io4nuc68.fsf@gnu.org> <83poy1t927.fsf@gnu.org> <83d1u1t07d.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a1144496cb2464805275aabde X-Trace: ger.gmane.org 1450645276 9461 80.91.229.3 (20 Dec 2015 21:01:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 20 Dec 2015 21:01:16 +0000 (UTC) Cc: aurelien.aptel+emacs@gmail.com, tzz@lifelogs.com, eggert@cs.ucla.edu, dancol@dancol.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Dec 20 22:01:15 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aAl6P-0005G5-Sx for ged-emacs-devel@m.gmane.org; Sun, 20 Dec 2015 22:01:14 +0100 Original-Received: from localhost ([::1]:41982 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aAl6O-0005Tf-OL for ged-emacs-devel@m.gmane.org; Sun, 20 Dec 2015 16:01:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58161) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aAl6K-0005TZ-Fc for emacs-devel@gnu.org; Sun, 20 Dec 2015 16:01:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aAl6J-0002Fo-CZ for emacs-devel@gnu.org; Sun, 20 Dec 2015 16:01:08 -0500 Original-Received: from mail-wm0-x233.google.com ([2a00:1450:400c:c09::233]:35976) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aAl6H-0002FI-EM; Sun, 20 Dec 2015 16:01:05 -0500 Original-Received: by mail-wm0-x233.google.com with SMTP id p187so45723282wmp.1; Sun, 20 Dec 2015 13:01:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-type; bh=HURazgop8V9Ct91EzBJaoDNh4MlxZOZjydHog7lKaPY=; b=OJj0pVenfrVY8MVSWYQtXAy2HT4fsCi7rGZPvXdHfS10PuozwbvikBUvMpbfWLepiK s31dTUWoYAYojaCTGVZjxPVaD0Iuq2cTB/tlJwBu4tXzHK0JHqaNyuMWZB5UkL42zbmc wZTklax2ejeKe5ViPOioJK/ltS3WUhLhs0N2xc5STJ+MQS5JD0Y/nYCwiKFGzn7VVShl fz9VtxyPJEfWjvZ3o2v4l2hHq5fLCJsSMk712Hv8/67cKBpQL+CXIe8Mby0k0yvebLGH 0ilhvP72XzdUEaMmH9207o8cLBgG6HQmfGnPBSODuJOnZWZmguTmXGT6UyNXVGlvjwo1 Lkqw== X-Received: by 10.28.7.14 with SMTP id 14mr15201578wmh.45.1450645264579; Sun, 20 Dec 2015 13:01:04 -0800 (PST) In-Reply-To: <83d1u1t07d.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::233 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:196570 Archived-At: --001a1144496cb2464805275aabde Content-Type: multipart/alternative; boundary=001a1144496cb2464305275aabdc --001a1144496cb2464305275aabdc Content-Type: text/plain; charset=UTF-8 Eli Zaretskii schrieb am So., 20. Dez. 2015 um 19:59 Uhr: > > From: Philipp Stephani > > Date: Sun, 20 Dec 2015 18:27:19 +0000 > > Cc: eggert@cs.ucla.edu, dancol@dancol.org, tzz@lifelogs.com, > > aurelien.aptel+emacs@gmail.com, emacs-devel@gnu.org > > > > and did you make sure > > that signaling an error from a module still reports the same > > information and backtrace as before the change? > > > > No, but I wouldn't know how the patch should change this. It only > changes an > > implementation detail in the error reporting code of the module > implementation > > itself. > > I provided one such test here: > > http://lists.gnu.org/archive/html/emacs-devel/2015-11/msg02318.html > > and the resulting backtrace here: > > http://lists.gnu.org/archive/html/emacs-devel/2015-11/msg02405.html > > > If we wanted to check the backtrace, I think we should rather add a unit > test > > for it. > > That would be good, thanks. > > Added a patch to that effect. --001a1144496cb2464305275aabdc Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


Eli Za= retskii <eliz@gnu.org> schrieb am= So., 20. Dez. 2015 um 19:59=C2=A0Uhr:
> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Sun, 20 Dec 2015 18:27:19 +0000
> Cc: eggert@cs.= ucla.edu, dancol= @dancol.org, tzz@= lifelogs.com,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0aurelien.aptel+emacs@gmail.com, emacs-devel@gnu.org
>
>=C2=A0 =C2=A0 =C2=A0and did you make sure
>=C2=A0 =C2=A0 =C2=A0that signaling an error from a module still reports= the same
>=C2=A0 =C2=A0 =C2=A0information and backtrace as before the change?
>
> No, but I wouldn't know how the patch should change this. It only = changes an
> implementation detail in the error reporting code of the module implem= entation
> itself.

I provided one such test here:

=C2=A0 http://lists.gnu.org/archi= ve/html/emacs-devel/2015-11/msg02318.html

and the resulting backtrace here:

=C2=A0 http://lists.gnu.org/archi= ve/html/emacs-devel/2015-11/msg02405.html

> If we wanted to check the backtrace, I think we should rather add a un= it test
> for it.

That would be good, thanks.


Added a patch to that effect.=C2=A0
--001a1144496cb2464305275aabdc-- --001a1144496cb2464805275aabde Content-Type: application/octet-stream; name="0001-Add-check-for-expected-backtrace-in-module-calls.patch" Content-Disposition: attachment; filename="0001-Add-check-for-expected-backtrace-in-module-calls.patch" Content-Transfer-Encoding: base64 Content-ID: <151c131dbabd93349131> X-Attachment-Id: 151c131dbabd93349131 RnJvbSBmYmU3NWJhNjA4OWNkY2ViMDk1MDdiMzgzYzBkY2IwYjcwNDc5YzliIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwIFN0ZXBoYW5pIDxwaHN0QGdvb2dsZS5jb20+CkRh dGU6IFN1biwgMjAgRGVjIDIwMTUgMjE6NTk6MTAgKzAxMDAKU3ViamVjdDogW1BBVENIXSBBZGQg Y2hlY2sgZm9yIGV4cGVjdGVkIGJhY2t0cmFjZSBpbiBtb2R1bGUgY2FsbHMuCgoqIHRlc3QuZWwg KG1vZC10ZXN0LW5vbi1sb2NhbC1leGl0LXNpZ25hbC10ZXN0KTogQ29tcGFyZSBhY3R1YWwKICBi YWNrdHJhY2UgdG8gZXhwZWN0ZWQgYmFja3RyYWNlLgotLS0KIG1vZHVsZXMvbW9kLXRlc3QvdGVz dC5lbCB8IDE2ICsrKysrKysrKysrKysrKy0KIDEgZmlsZSBjaGFuZ2VkLCAxNSBpbnNlcnRpb25z KCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvbW9kdWxlcy9tb2QtdGVzdC90ZXN0LmVs IGIvbW9kdWxlcy9tb2QtdGVzdC90ZXN0LmVsCmluZGV4IDY5YmY5MzMuLmY4YzE2ZDMgMTAwNjQ0 Ci0tLSBhL21vZHVsZXMvbW9kLXRlc3QvdGVzdC5lbAorKysgYi9tb2R1bGVzL21vZC10ZXN0L3Rl c3QuZWwKQEAgLTY0LDcgKzY0LDIxIEBACiA7OwogCiAoZXJ0LWRlZnRlc3QgbW9kLXRlc3Qtbm9u LWxvY2FsLWV4aXQtc2lnbmFsLXRlc3QgKCkKLSAgKHNob3VsZC1lcnJvciAobW9kLXRlc3Qtc2ln bmFsKSkpCisgIChzaG91bGQtZXJyb3IgKG1vZC10ZXN0LXNpZ25hbCkpCisgIChsZXQgKGRlYnVn Z2VyLWFyZ3MgYmFja3RyYWNlKQorICAgIChzaG91bGQtZXJyb3IKKyAgICAgKGxldCAoKGRlYnVn Z2VyIChsYW1iZGEgKCZyZXN0IGFyZ3MpCisgICAgICAgICAgICAgICAgICAgICAgIChzZXRxIGRl YnVnZ2VyLWFyZ3MgYXJncworICAgICAgICAgICAgICAgICAgICAgICAgICAgICBiYWNrdHJhY2Ug KHdpdGgtb3V0cHV0LXRvLXN0cmluZyAoYmFja3RyYWNlKSkpCisgICAgICAgICAgICAgICAgICAg ICAgIChjbC1pbmNmIG51bS1ub25tYWNyby1pbnB1dC1ldmVudHMpKSkKKyAgICAgICAgICAgKGRl YnVnLW9uLXNpZ25hbCB0KSkKKyAgICAgICAobW9kLXRlc3Qtc2lnbmFsKSkpCisgICAgKHNob3Vs ZCAoZXF1YWwgZGVidWdnZXItYXJncyAnKGVycm9yIChlcnJvciAuIDU2KSkpKQorICAgIChzaG91 bGQgKHN0cmluZy1tYXRjaC1wCisgICAgICAgICAgICAgKHJ4IGJvbCAiICBpbnRlcm5hbC0tbW9k dWxlLWNhbGwoIiAoKyBub25sKSA/XCkgP1xuCisgICAgICAgICAgICAgICAgICIgIGFwcGx5KGlu dGVybmFsLS1tb2R1bGUtY2FsbCAiICgrIG5vbmwpID9cKSA/XG4KKyAgICAgICAgICAgICAgICAg IiAgbW9kLXRlc3Qtc2lnbmFsKCkiIGVvbCkKKyAgICAgICAgICAgICBiYWNrdHJhY2UpKSkpCiAK IChlcnQtZGVmdGVzdCBtb2QtdGVzdC1ub24tbG9jYWwtZXhpdC10aHJvdy10ZXN0ICgpCiAgIChz aG91bGQgKGVxdWFsCi0tIAoyLjYuMwoK --001a1144496cb2464805275aabde--