From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: Dynamic loading progress Date: Wed, 11 Nov 2015 13:57:58 +0000 Message-ID: References: <871tc315y3.fsf@lifelogs.com> <83611eqk9w.fsf@gnu.org> <878u6ax7c7.fsf@lifelogs.com> <83k2ptq5t3.fsf@gnu.org> <87h9kxx60e.fsf@lifelogs.com> <877flswse5.fsf@lifelogs.com> <8737wgw7kf.fsf@lifelogs.com> <87io5bv1it.fsf@lifelogs.com> <87egfzuwca.fsf@lifelogs.com> <876118u6f2.fsf@lifelogs.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=047d7bf0d14c52241105244437af X-Trace: ger.gmane.org 1447250344 28423 80.91.229.3 (11 Nov 2015 13:59:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 11 Nov 2015 13:59:04 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 11 14:59:04 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZwVuz-00035H-Pf for ged-emacs-devel@m.gmane.org; Wed, 11 Nov 2015 14:58:34 +0100 Original-Received: from localhost ([::1]:40773 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwVuz-00010H-4H for ged-emacs-devel@m.gmane.org; Wed, 11 Nov 2015 08:58:33 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54475) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwVuc-0000S7-JB for emacs-devel@gnu.org; Wed, 11 Nov 2015 08:58:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZwVub-0000Gm-4R for emacs-devel@gnu.org; Wed, 11 Nov 2015 08:58:10 -0500 Original-Received: from mail-wm0-x22b.google.com ([2a00:1450:400c:c09::22b]:37131) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwVua-0000Ge-OM for emacs-devel@gnu.org; Wed, 11 Nov 2015 08:58:09 -0500 Original-Received: by wmww144 with SMTP id w144so45565098wmw.0 for ; Wed, 11 Nov 2015 05:58:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :content-type; bh=gGz0/sYv+TT4Z08rETlGnWfd8nBVVoE1SzVAQm2wogo=; b=mDgLizCbLaKl0Jg3B+PQ7RdB0GL3MsXSphtIYSWuFde0WdoLaIRS5p7rYoG0p+rSb2 n3wr5imcDu6Dk2mq6qtDyLuWzxqcweRuQHQb5tIBrNRBDtU15PMVH/mlqAMOefLgvuZ8 xHP8+Me0rByH/MBR6KAHbQi9hLCec6YqNI2axRZjdKZZHL2JhtWAv/5sW4kWxt7cNZe4 ukG5UefwfzoJ7W0dIdaSdw9r8D0u+SZMRSnOWC1Mc7LhO9BIvJ3wwARNUOoXz+g0vzvF WWHH5YS2Q29gs5a5aUxvzR1PlsU+er7PeWkzY846LcEr2/0bPMkMVF1Y4JO0GDajAJ83 qoEQ== X-Received: by 10.194.91.164 with SMTP id cf4mr10171591wjb.139.1447250288057; Wed, 11 Nov 2015 05:58:08 -0800 (PST) In-Reply-To: <876118u6f2.fsf@lifelogs.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c09::22b X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:194058 Archived-At: --047d7bf0d14c52241105244437af Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Ted Zlatanov schrieb am Mi., 11. Nov. 2015 um 12:22 Uhr: > On Mon, 09 Nov 2015 16:16:31 +0000 Philipp Stephani > wrote: > > PS> I don't need to sign the papers because my employer (Google) has a > special > PS> agreement with the FSF. Please use my work address phst@google.com an= d > PS> "Copyright Google Inc." for my contributions. I already have a few > patches > PS> in master under that address. > > Thank you. I can see that your existing patches didn't need the > "Copyright Google Inc." in the commit message, so I think we can skip it > here. > > On Mon, 9 Nov 2015 20:58:59 +0100 Aur=C3=A9lien Aptel < > aurelien.aptel+emacs@gmail.com> wrote: > > AA> I've made a clean new branch 'dynamic-modules-clean-1' on top of a > AA> recent master which you should be able to rebase easily. I've split m= y > AA> "working" branch into 6 Changelog-ready commits. I'm the author of th= e > AA> commits but a significant part of the code was also written by Philip > AA> Stefani (big thanks to him). Don't really know how to we can reflect > AA> that since it's all mixed up now. > > AA> It's on github. You can rework the commit messages if you want as I'm > AA> not very good at this. > > Aur=C3=A9lien, it looks great. Thank you for the work. > > I have only two requests before I merge: > > 1) Can you add this header line to the commits that need it (it may > require some checking, unfortunately): > > Co-authored-by: Philipp Stephani > > I *think* that's sufficient. > > 2) Since you're modifying some commits, can you remove the final period > from the first line? It's a suggestion in CONTRIBUTE but not required. > > Otherwise I think it's ready to merge. > > On Tue, 10 Nov 2015 20:07:36 +0000 Philipp Stephani > wrote: > > PS> Thanks! Since the freeze is only days away, can we now start merging > these > PS> changes into the Savannah master? > > Yes, I'll do the merge as soon as (1) above is resolved. Technically the > patch looks good. > > Wonderful, thanks a lot! --047d7bf0d14c52241105244437af Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


Ted Zl= atanov <tzz@lifelogs.com> sch= rieb am Mi., 11. Nov. 2015 um 12:22=C2=A0Uhr:
On Mon, 09 Nov 2015 16:16:31 +0000 Philipp Stephani <p.stephani2@gmail.com> wrote:

PS> I don't need to sign the papers because my employer (Google) has= a special
PS> agreement with the FSF. Please use my work address phst@google.com and
PS> "Copyright Google Inc." for my contributions. I already ha= ve a few patches
PS> in master under that address.

Thank you.=C2=A0 I can see that your existing patches didn't need the "Copyright Google Inc." in the commit message, so I think we can = skip it here.

On Mon, 9 Nov 2015 20:58:59 +0100 Aur=C3=A9lien Aptel <aurelien.aptel+emacs@g= mail.com> wrote:

AA> I've made a clean new branch 'dynamic-modules-clean-1' o= n top of a
AA> recent master which you should be able to rebase easily. I've sp= lit my
AA> "working" branch into 6 Changelog-ready commits. I'm t= he author of the
AA> commits but a significant part of the code was also written by Phili= p
AA> Stefani (big thanks to him). Don't really know how to we can ref= lect
AA> that since it's all mixed up now.

AA> It's on github. You can rework the commit messages if you want a= s I'm
AA> not very good at this.

Aur=C3=A9lien, it looks great.=C2=A0 Thank you for the work.

I have only two requests before I merge:

1) Can you add this header line to the commits that need it (it may
require some checking, unfortunately):

Co-authored-by: Philipp Stephani <phst@google.com>

I *think* that's sufficient.

2) Since you're modifying some commits, can you remove the final period=
from the first line?=C2=A0 It's a suggestion in CONTRIBUTE but not requ= ired.

Otherwise I think it's ready to merge.

On Tue, 10 Nov 2015 20:07:36 +0000 Philipp Stephani <p.stephani2@gmail.com> wrote= :

PS> Thanks! Since the freeze is only days away, can we now start merging= these
PS> changes into the Savannah master?

Yes, I'll do the merge as soon as (1) above is resolved. Technically th= e
patch looks good.


Wonderful, thanks a lot!=C2=A0
--047d7bf0d14c52241105244437af--