From: Philipp Stephani <p.stephani2@gmail.com>
To: Jordon Biondo <jordonbiondo@gmail.com>,
Emacs development discussions <emacs-devel@gnu.org>
Subject: Re: Revisiting `setq-local`s signature
Date: Tue, 31 Jan 2017 18:13:13 +0000 [thread overview]
Message-ID: <CAArVCkRG=0xsHRN=6UMwAm6RNcSGUw3vuXvES-LvOROOOd105w@mail.gmail.com> (raw)
In-Reply-To: <CABB6V6qKOKu3NX+mKg0nHT+=K6Nm95F_DqsRKcnP9NN6RKBt1A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1328 bytes --]
Jordon Biondo <jordonbiondo@gmail.com> schrieb am Mo., 30. Jan. 2017 um
19:39 Uhr:
> A while ago I brought up the inconstant signatures of `setq`,
> `setq-default` and `setq-local`. In short, I want `setq-local` to have the
> same signature as `setq` and `setq-local`. (setq* VAR VAL VAR VAL...)
>
> See thread:
> http://lists.gnu.org/archive/html/emacs-devel/2015-03/msg00448.html
>
> I appreciate Stefan's input back then, but I'd like to revisit the issue,
> get further input, and see if I can change some minds about the issue.
>
> If you believe the variadic signature of `setq` and `setq-default` is not
> ideal, consider that backwards compatibility erases any chance that those
> two functions will lose that feature, and consider the benefits of being
> consistently wrong over being inconsistently right.
>
> Are maintainers and users still opposed to this change? If not I'd be
> happy to update the patch from the previous thread.
>
As a user, I'm still opposed to this change. I don't think consistency is
important enough in this case to justify the "worse" signature. Consistency
is not a goal in itself, but should serve the goal to increase readability
and lower the barriers for new contributors. I don't think that the simpler
signature of setq-local is in any way confusing because of this
inconsistency.
[-- Attachment #2: Type: text/html, Size: 2072 bytes --]
next prev parent reply other threads:[~2017-01-31 18:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-30 18:37 Revisiting `setq-local`s signature Jordon Biondo
2017-01-31 3:47 ` Tino Calancha
2017-01-31 18:13 ` Philipp Stephani [this message]
2017-01-31 18:48 ` Tom Tromey
2017-01-31 18:57 ` Drew Adams
2017-01-31 19:13 ` Jordon Biondo
2017-02-01 5:55 ` Tino Calancha
2017-02-02 3:01 ` John Wiegley
2017-02-02 3:34 ` Eli Zaretskii
2017-02-02 14:28 ` Jordon Biondo
2017-02-02 17:35 ` Eli Zaretskii
2017-02-02 17:43 ` Jordon Biondo
2017-02-02 20:31 ` Eli Zaretskii
2017-02-08 15:59 ` Jordon Biondo
2017-02-10 8:33 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAArVCkRG=0xsHRN=6UMwAm6RNcSGUw3vuXvES-LvOROOOd105w@mail.gmail.com' \
--to=p.stephani2@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=jordonbiondo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).