unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: master 3a6137a 3/4: Extend and overhaul FD_SETSIZE overflow tests.
       [not found] ` <20201230220856.A16E32094D@vcs0.savannah.gnu.org>
@ 2020-12-31  6:22   ` Lars Ingebrigtsen
  2020-12-31 12:18     ` Philipp Stephani
  2020-12-31 11:09   ` Michael Albinus
  1 sibling, 1 reply; 4+ messages in thread
From: Lars Ingebrigtsen @ 2020-12-31  6:22 UTC (permalink / raw)
  To: emacs-devel; +Cc: Philipp Stephani

p.stephani2@gmail.com (Philipp Stephani) writes:

> +            (when (eql (call-process "errno" nil t nil "EMFILE") 0)

4 unexpected results:
   FAILED  process-tests/fd-setsize-no-crash/make-network-process
   FAILED  process-tests/fd-setsize-no-crash/make-pipe-process
   FAILED  process-tests/fd-setsize-no-crash/make-process
   FAILED  process-tests/fd-setsize-no-crash/make-serial-process

This fails on systems without the "errno" executable.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: master 3a6137a 3/4: Extend and overhaul FD_SETSIZE overflow tests.
       [not found] ` <20201230220856.A16E32094D@vcs0.savannah.gnu.org>
  2020-12-31  6:22   ` master 3a6137a 3/4: Extend and overhaul FD_SETSIZE overflow tests Lars Ingebrigtsen
@ 2020-12-31 11:09   ` Michael Albinus
  1 sibling, 0 replies; 4+ messages in thread
From: Michael Albinus @ 2020-12-31 11:09 UTC (permalink / raw)
  To: emacs-devel; +Cc: Philipp Stephani

p.stephani2@gmail.com (Philipp Stephani) writes:

Hi Philipp,

> +(defun process-tests--EMFILE-message ()
> +  "Return the error message for the EMFILE POSIX error.
> +Return nil if that can't be determined."
> +  (when (eq process-tests--EMFILE-message :unknown)
> +    (setq process-tests--EMFILE-message
> +          (with-temp-buffer
> +            (when (eql (call-process "errno" nil t nil "EMFILE") 0)
> +              (goto-char (point-min))
> +              (when (looking-at (rx "EMFILE" (+ blank) (+ digit)
> +                                    (+ blank) (group (+ nonl))))
> +                (match-string-no-properties 1))))))
> +  process-tests--EMFILE-message)

This breaks several tests on emba.gnu.org, see for example
<https://emba.gnu.org/emacs/emacs/-/jobs/9668/raw>.

Best regards, Michael.



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: master 3a6137a 3/4: Extend and overhaul FD_SETSIZE overflow tests.
  2020-12-31  6:22   ` master 3a6137a 3/4: Extend and overhaul FD_SETSIZE overflow tests Lars Ingebrigtsen
@ 2020-12-31 12:18     ` Philipp Stephani
  2021-01-01 10:54       ` Lars Ingebrigtsen
  0 siblings, 1 reply; 4+ messages in thread
From: Philipp Stephani @ 2020-12-31 12:18 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: Philipp Stephani, Emacs developers

Am Do., 31. Dez. 2020 um 07:22 Uhr schrieb Lars Ingebrigtsen <larsi@gnus.org>:
>
> p.stephani2@gmail.com (Philipp Stephani) writes:
>
> > +            (when (eql (call-process "errno" nil t nil "EMFILE") 0)
>
> 4 unexpected results:
>    FAILED  process-tests/fd-setsize-no-crash/make-network-process
>    FAILED  process-tests/fd-setsize-no-crash/make-pipe-process
>    FAILED  process-tests/fd-setsize-no-crash/make-process
>    FAILED  process-tests/fd-setsize-no-crash/make-serial-process
>
> This fails on systems without the "errno" executable.

Thanks, I hopefully fixed this now.



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: master 3a6137a 3/4: Extend and overhaul FD_SETSIZE overflow tests.
  2020-12-31 12:18     ` Philipp Stephani
@ 2021-01-01 10:54       ` Lars Ingebrigtsen
  0 siblings, 0 replies; 4+ messages in thread
From: Lars Ingebrigtsen @ 2021-01-01 10:54 UTC (permalink / raw)
  To: Philipp Stephani; +Cc: Philipp Stephani, Emacs developers

Philipp Stephani <p.stephani2@gmail.com> writes:

> Thanks, I hopefully fixed this now.

Yup; works fine here now.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-01-01 10:54 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20201230220853.25813.42676@vcs0.savannah.gnu.org>
     [not found] ` <20201230220856.A16E32094D@vcs0.savannah.gnu.org>
2020-12-31  6:22   ` master 3a6137a 3/4: Extend and overhaul FD_SETSIZE overflow tests Lars Ingebrigtsen
2020-12-31 12:18     ` Philipp Stephani
2021-01-01 10:54       ` Lars Ingebrigtsen
2020-12-31 11:09   ` Michael Albinus

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).