unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Philipp Stephani <p.stephani2@gmail.com>
To: Emacs developers <emacs-devel@gnu.org>
Subject: Re: Small docstring improvements
Date: Fri, 19 Aug 2016 20:34:58 +0000	[thread overview]
Message-ID: <CAArVCkR6i1+zRmy3wbmwkd-RW=A9BS6zMYbGhQoF9sc+rDUy-g@mail.gmail.com> (raw)
In-Reply-To: <m2twegv9gv.fsf@newartisans.com>

[-- Attachment #1: Type: text/plain, Size: 1279 bytes --]

John Wiegley <jwiegley@gmail.com> schrieb am Fr., 19. Aug. 2016 um
21:34 Uhr:

> >>>>> "PS" == Philipp Stephani <p.stephani2@gmail.com> writes:
>
> PS> +START and END are normally buffer positions specifying the part of the
> PS> +buffer to send to the process.
> PS> +If START is nil, that means to use the entire buffer contents; END is
> PS> +ignored.
>
> I would phrase a little differently:
>
>     +If START and END are both buffer positions, they specify the region
>     +to send to the process.
>     +If START is nil, it means to use the entire buffer contents; END is
>     +ignored.
>
> PS> +If START is a string, then send that string to the process +instead of
> PS> any buffer contents; END is ignored.
>
> This is a horrible abuse. There should be another function
> `call-process-with-string'.
>
> I don't like the way that "START" has three separate meanings, only one of
> which has anything to do with beginning a START of something.
>
>
I've simply copied the docstring from write-region, which has exactly the
same semantics (because call-process-region calls write-region). Like it or
not, these are the semantics, and they are intentional (the code for
call-process-region has explicit branches for these cases), so I think they
deserve to be documented.

[-- Attachment #2: Type: text/html, Size: 1763 bytes --]

  reply	other threads:[~2016-08-19 20:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-19 19:26 Small docstring improvements Philipp Stephani
2016-08-19 19:34 ` John Wiegley
2016-08-19 20:34   ` Philipp Stephani [this message]
2016-08-19 21:12     ` John Wiegley
2016-08-19 22:04       ` Drew Adams
2016-08-20  0:24         ` John Wiegley
2016-08-20  7:10   ` Eli Zaretskii
2016-08-20 23:17     ` John Wiegley
2016-08-19 21:59 ` Dmitry Gutov
2016-08-20  7:08 ` Eli Zaretskii
2016-08-20 13:52   ` Philipp Stephani
2016-08-20 15:34     ` Eli Zaretskii
2016-08-20 15:59       ` Philipp Stephani
2016-08-20 16:11         ` Eli Zaretskii
2016-08-20 18:00           ` Philipp Stephani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAArVCkR6i1+zRmy3wbmwkd-RW=A9BS6zMYbGhQoF9sc+rDUy-g@mail.gmail.com' \
    --to=p.stephani2@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).