From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add new function to test whether a key is present in a hash table. Date: Fri, 19 Apr 2019 19:33:23 +0200 Message-ID: References: <20180215203406.64372-1-phst@google.com> <1a13b319-a308-c42d-507e-50dec2137fc2@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="146435"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Emacs developers To: =?UTF-8?Q?Cl=C3=A9ment_Pit=2DClaudel?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 19 19:33:48 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hHXOV-000bxF-Vb for ged-emacs-devel@m.gmane.org; Fri, 19 Apr 2019 19:33:48 +0200 Original-Received: from localhost ([127.0.0.1]:59380 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHXOU-0002pF-Ni for ged-emacs-devel@m.gmane.org; Fri, 19 Apr 2019 13:33:46 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37979) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHXOP-0002p9-3X for emacs-devel@gnu.org; Fri, 19 Apr 2019 13:33:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hHXON-0005W4-7F for emacs-devel@gnu.org; Fri, 19 Apr 2019 13:33:41 -0400 Original-Received: from mail-ot1-x341.google.com ([2607:f8b0:4864:20::341]:37334) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hHXOL-0005VG-96 for emacs-devel@gnu.org; Fri, 19 Apr 2019 13:33:38 -0400 Original-Received: by mail-ot1-x341.google.com with SMTP id c16so4870197otn.4 for ; Fri, 19 Apr 2019 10:33:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Ci5KKtOL7oyrntE5rflAeMGmAtoCuNVpWzJUmdGabvY=; b=dKg6XYZjsd3TEzWxVdWVpdd2U+ORjw9nEiBilTRwkJrAVeHMNGQIinCo6FhVWlscsG WSyZXNcG2BOATw7zzY+Q08mHkP8tCqv4VQj2mTuG/qBywxJhqOXRY8TfMg1z+b4pHQXb FgufRjEB3R/EBI9GwqFrX8qEnillz8UYMIoGWd45IyKKkPgvJW0aSm15dhmiQwD2DjiH I7xNAgKpGtcRrFzRGIJDJuEDTK7lewTP/xhmUHYjwV1oPO9e6JuD4JGDHG7Osaoz1Q5E J8s9Ahbm/fjACS6sRprbZNa0z3wLxtieli/kWDqRicASj6pjnEnwOr30jp/CgbeWvdfw 3IeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Ci5KKtOL7oyrntE5rflAeMGmAtoCuNVpWzJUmdGabvY=; b=jS8OGqtyNsyKmbYJ2V695GDL6H2TgO0EFQFIchsIdTne4k4/CXCCKau7Z9rrF2WX3W YtQjKh2M8fTK/F/UkkITwRCgb35m+NBz9lsaiW59Zst2perQq5SGsiT4WcbY6OVYjdXQ ZeoBqsyHcTGip/oaXREpiDpttw4dzApwNH5xJLfoFJh9Mw/kRy4pPn5MlYS+xksTTkZd vXjvCfWAGszHrv+IozelzjYV9m8hf01EN+xe6E9ffPhiKO6yzLY5w9SzyoIJUedboEY2 LtnP4/FtE98d9P7KzMO7t/dLMH4hT3XSViHfqJPdUK1wqOWYceaeDR7Avrtj9fdnmogt IFPw== X-Gm-Message-State: APjAAAWoB3dGMCBMUgWQmPeXkOYf3DBqGX/rsmux1qSd9mhEd5G/ZDOX X+gxy1Aczwntr3vZ6i5dCcjLiKPVPNo0K6Dgcq4= X-Google-Smtp-Source: APXvYqxCPc5pj2QeypTiDO2ysVM76BgmaZt2LTYOBrDAgK1LoieC1r5i8dEQFmLN+aP2QVzU6KiqmaB9aW4MTx0b6Es= X-Received: by 2002:a05:6830:15d2:: with SMTP id j18mr2709987otr.37.1555695214035; Fri, 19 Apr 2019 10:33:34 -0700 (PDT) In-Reply-To: <1a13b319-a308-c42d-507e-50dec2137fc2@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::341 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235665 Archived-At: Am Do., 15. Feb. 2018 um 23:05 Uhr schrieb Cl=C3=A9ment Pit-Claudel : > > On 2018-02-15 15:34, Philipp Stephani wrote: > > Such a function is useful because in Emacs Lisp, 'gethash' cannot > > return whether the key is present as in Common Lisp, and using > > 'gethash' alone to test for presence is nontrivial. > > Looks useful to me :) Maybe the function should be called =E2=80=A6-conta= ins-key-p instead of =E2=80=A6-contains-key? It's called ...-contains-p, I think it's clear enough that this tests for key presence and not value presence. Any objections to pushing this one-liner to master?