From: Philipp Stephani <p.stephani2@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: aurelien.aptel+emacs@gmail.com, tzz@lifelogs.com,
dancol@dancol.org, emacs-devel@gnu.org
Subject: Re: Reporting Lisp errors in dynamic modules
Date: Fri, 27 Nov 2015 18:01:54 +0000 [thread overview]
Message-ID: <CAArVCkR3ewXvAxXhCQm4EoTRJYM3ME+eVpbE8pbs4yPJ6P5G8Q@mail.gmail.com> (raw)
In-Reply-To: <83zixzqr32.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1062 bytes --]
Eli Zaretskii <eliz@gnu.org> schrieb am Fr., 27. Nov. 2015 um 18:40 Uhr:
> > From: Philipp Stephani <p.stephani2@gmail.com>
> > Date: Fri, 27 Nov 2015 16:40:23 +0000
> > Cc: aurelien.aptel+emacs@gmail.com, tzz@lifelogs.com, dancol@dancol.org
> >
> > I believe the line with "<subr module-call>" is suboptimal, in that
> it
> > looks alien and includes all kinds of unneeded and weirdly formatted
> > data. AFAIU, the reason is that we deliberately unintern module-call.
> > Should we perhaps reconsider that decision, so that the backtrace is
> > in more familiar form? What exactly are the dangers of having
> > module-call exposed as any other primitive?
> >
> >
> > - Somebody calls it with the wrong type. Right now it doesn't do any type
> > checking, so that would crash/be UB.
>
> We can add checks to countermand that.
>
> > - An existing function outside of Emacs might already be called like
> that.
>
> Not really a problem, IMO.
>
We could rename the function to "internal-module-call" to make it even less
likely to clash.
[-- Attachment #2: Type: text/html, Size: 1721 bytes --]
next prev parent reply other threads:[~2015-11-27 18:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-27 11:07 Reporting Lisp errors in dynamic modules Eli Zaretskii
2015-11-27 11:20 ` Aurélien Aptel
2015-11-27 11:46 ` Eli Zaretskii
2015-11-27 12:49 ` Aurélien Aptel
2015-11-27 12:53 ` David Kastrup
2015-11-27 14:50 ` Eli Zaretskii
2015-11-27 16:40 ` Philipp Stephani
2015-11-27 17:39 ` Eli Zaretskii
2015-11-27 18:01 ` Philipp Stephani [this message]
2015-11-27 18:11 ` Eli Zaretskii
2015-11-27 18:40 ` Philipp Stephani
2015-11-28 12:04 ` Eli Zaretskii
2015-12-03 5:00 ` Stefan Monnier
2015-12-03 11:33 ` Aurélien Aptel
2015-12-03 13:42 ` Ted Zlatanov
2015-12-03 15:37 ` Stefan Monnier
2015-12-07 19:13 ` Philipp Stephani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAArVCkR3ewXvAxXhCQm4EoTRJYM3ME+eVpbE8pbs4yPJ6P5G8Q@mail.gmail.com \
--to=p.stephani2@gmail.com \
--cc=aurelien.aptel+emacs@gmail.com \
--cc=dancol@dancol.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=tzz@lifelogs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).