From: Philipp Stephani <p.stephani2@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 8764544: Treat control characters in JSON strings as invalid
Date: Fri, 29 Sep 2017 20:50:52 +0000 [thread overview]
Message-ID: <CAArVCkR2osUgLWoNpx=DF55PX1iFoSRSZJggrZ-RRVhMqTK3ng@mail.gmail.com> (raw)
In-Reply-To: <jwvo9puldwc.fsf-monnier+emacs@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 830 bytes --]
Stefan Monnier <monnier@iro.umontreal.ca> schrieb am Do., 28. Sep. 2017 um
23:22 Uhr:
> >> >>> - (or (char-after (point)) :json-eof))
> >> >> I wonder why it used :json-eof instead of using nil ?
> >> >> Any idea?
> >> > Not sure--it has been there since json.el was added to Emacs.
> >> Then why use 0 now instead of nil?
> > Because `following-char' returns 0 at EOB. "At the end of the buffer or
> > accessible region, return 0."
>
> But it also returns 0 in other cases. E.g. if you had changed
>
> (or (char-after (point)) :json-eof)
> to
> (char-after)
>
> it would give you nil at EOB (instead of 0).
>
>
Agreed.
I'm wondering what the purpose of `following-char' is. Even in the rare
cases where you want to treat EOB and a following null character
identically it would be cleaner to write (or (char-after) 0).
[-- Attachment #2: Type: text/html, Size: 1254 bytes --]
next prev parent reply other threads:[~2017-09-29 20:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170818000543.9841.93700@vcs0.savannah.gnu.org>
[not found] ` <20170818000544.84B5E2052C@vcs0.savannah.gnu.org>
2017-08-18 7:51 ` [Emacs-diffs] master 8764544: Treat control characters in JSON strings as invalid Stefan Monnier
2017-08-18 14:13 ` Mark Oteiza
2017-08-18 20:24 ` Stefan Monnier
2017-09-28 20:19 ` Philipp Stephani
2017-09-28 21:22 ` Stefan Monnier
2017-09-29 20:50 ` Philipp Stephani [this message]
2017-09-29 20:59 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAArVCkR2osUgLWoNpx=DF55PX1iFoSRSZJggrZ-RRVhMqTK3ng@mail.gmail.com' \
--to=p.stephani2@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).