From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: What's the line length limit in the Emacs codebase? Date: Sat, 26 Dec 2020 12:09:17 +0100 Message-ID: References: <83wnx8pm0e.fsf@gnu.org> <83v9cpn1w5.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9901"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Emacs developers To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Dec 26 12:10:11 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kt7Sd-0002U2-DL for ged-emacs-devel@m.gmane-mx.org; Sat, 26 Dec 2020 12:10:11 +0100 Original-Received: from localhost ([::1]:56790 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kt7Sc-0007Sf-Cm for ged-emacs-devel@m.gmane-mx.org; Sat, 26 Dec 2020 06:10:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57766) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kt7S1-00072n-S6 for emacs-devel@gnu.org; Sat, 26 Dec 2020 06:09:33 -0500 Original-Received: from mail-oi1-x233.google.com ([2607:f8b0:4864:20::233]:46914) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kt7Ry-000093-JK; Sat, 26 Dec 2020 06:09:33 -0500 Original-Received: by mail-oi1-x233.google.com with SMTP id q205so6773960oig.13; Sat, 26 Dec 2020 03:09:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3tpzyMCvaJvkpMmPNr/cvrVVpWrt57q+fIhPWXcekJU=; b=RbhZoF7ccqD2KHsMFSsJiKAlVhiwMg0+9BExjt5/HkmBO0CtXHc+UsIa18tkpjDEw9 6jFDkJVdT+ZyIwrwrmJaa2koLdghWB0G9MkMmD84aKtOJVYMWyYFFpxwxuuyqRYiDEn/ mrNPCzud5FIn8cR3lTYsFl+8a28QQ9cvqpNLIni+a76L12Qs8umUktCpIvA2jn/jZ2MO 9usyC3OenCKAXBWdte5Nuf13f3fk4G+ZtUbsm1Wymj+XBgPqDNO375OBQFwpZhL1DDAO FBOVSOr5npV1wFU0oNFBxRb6GL8cHLcQYFEKkb2syW/NREIyvIfrbP7JXq68L17Hyduk rjnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3tpzyMCvaJvkpMmPNr/cvrVVpWrt57q+fIhPWXcekJU=; b=ZYjgbvoyGS+BzwodlsLf0UQViy9HK5wMzvfXtKIQcLqsQQFcUWzLakB6cpg46kVc4z 9MNkMoYUvCvoLq5RiS8j9a+rT+GMPTF8e1IWe0+yZbb/5dcWSV6V1kc6talzNqWRSnE0 lxhj6MSRF8USrr7r+EoKEc7zwW4LjzhMRIzecXFeXl0sB7D0RYpWr97YFmsZ9sjbVL2P wGH/j7oY21Yn5I8dR1HruU8aA+GzAPHvmG8zR/eeAi+JYQANzHhtvGfxWmHm4F64Q3UX 32JuJnI/aFGbgATzoML1pRpwgwZ8+JwMJ5nbpHUZIcvFLyZyKJz2VnjlWOJOzkgcilt3 7O1g== X-Gm-Message-State: AOAM532T+IXJUVB2iLP/SM3bunYEtiMQfxaqFvWjKNC4+YhtIPBWqXVr cSVFNAvW4+tvaWnsSa8iA9GiNVYPz/Dc/Fy0mzG/Nb6pszA= X-Google-Smtp-Source: ABdhPJxuUt4kTncaK/2hdCefj2cnXDDYrqszSAFqxDu2gAs0d5XK0+R5t5q6RDT9twG3iaaoSSYYgWBec3Ejwcqu6uU= X-Received: by 2002:aca:3b03:: with SMTP id i3mr7113514oia.170.1608980968232; Sat, 26 Dec 2020 03:09:28 -0800 (PST) In-Reply-To: <83v9cpn1w5.fsf@gnu.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::233; envelope-from=p.stephani2@gmail.com; helo=mail-oi1-x233.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:261836 Archived-At: Am Fr., 25. Dez. 2020 um 20:04 Uhr schrieb Eli Zaretskii : > > > From: Philipp Stephani > > Date: Fri, 25 Dec 2020 18:10:50 +0100 > > Cc: Emacs developers > > > > > Where did you see significant deviations from that standard? > > > > Everywhere? When I last counted there were more than 1900 files in the > > codebase that have lines longer than 70 characters. In src/emacs.c > > alone there are over 160 such lines. > > You are counting long strings and lines with long URLs? Is that > reasonable? If you look at emacs.c, you'll see lots of lines that are not long URLs etc., but e.g. comment blocks that could easily be reflowed, and I was wondering why that didn't happen when these comments were introduced. Just to give some context, I became aware of this when editing various parts of the Emacs codebase while having the fill column indicator enabled. I then realized that large parts of the code seem to use an 80-column limit, while others seem to use a 70-column limit, and I was wondering why that's the case.