From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Ignore pending_signals when checking for quits. Date: Sun, 24 Feb 2019 22:51:39 +0100 Message-ID: References: <83y36nl7rl.fsf@gnu.org> <20190211201739.25229-1-phst@google.com> <834l97pv0l.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="266627"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Philipp Stephani , Emacs developers To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 24 22:52:44 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gy1hU-0017Hc-0x for ged-emacs-devel@m.gmane.org; Sun, 24 Feb 2019 22:52:44 +0100 Original-Received: from localhost ([127.0.0.1]:56393 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gy1hT-0003JZ-3n for ged-emacs-devel@m.gmane.org; Sun, 24 Feb 2019 16:52:43 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46388) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gy1gl-0003JU-H5 for emacs-devel@gnu.org; Sun, 24 Feb 2019 16:52:00 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gy1gl-0002Hv-5w for emacs-devel@gnu.org; Sun, 24 Feb 2019 16:51:59 -0500 Original-Received: from mail-ot1-x331.google.com ([2607:f8b0:4864:20::331]:39466) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gy1gi-0002FS-7v; Sun, 24 Feb 2019 16:51:56 -0500 Original-Received: by mail-ot1-x331.google.com with SMTP id n8so6238418otl.6; Sun, 24 Feb 2019 13:51:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jpp8iOEpTEviSVLo7CYzBl9XCkndY7KNceV/cRp0Msg=; b=ZFMMQgNsOuaTGlK8ofxLUlr9a7J5iHKfyISUqgYBangoxf1+IKIRz83ZHse2HDjbfK DcfQs6jECONn2Lt1yamqb3hHmLW3vykwU5F4Ml68f6NRv4bRKbrmR37TqQknuwc6Zk4W nB9KrPQgkJzgp7ZG/XW7RC0rUAxJYsC+Vr6kzJY3RGjsiTM/Ist5HvxC3DYhvjL/2CDp gzm/McE7NBQntX5kt6EtFiKGz53TjvHlIyW8fRYtU3FWIXsUYIgxJPMLyiuGTJOf2HBh 4vpeKGwOTiAPOQLRr098gvbHIVnOOqf1vkewPLRQrUfp4lNQLWCt69x4hvalW3bWjPzn kxQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jpp8iOEpTEviSVLo7CYzBl9XCkndY7KNceV/cRp0Msg=; b=hT2BQTUIhXT/06flnT9DwUKtMg45OPs/ls8xif+ldTZkvLbXZPiUXAeW4XWTK2kQLj IdKHzZ15y3z/m6dRULPlUWA31BZ1jw2JZsqgBlzGrPTHuQOFq2KRWbu957/KyHaMU6VN uGmiXrVvSg8rXbY5ibmZ3qOP2ieXB+BjemouCYT9YUUU8iHHpeOCciAOFsfuMDQpbP3E qfNepUjx/zp+0Z+aerFt0DyI0uGYPaPyXZIpRZkYQNeMdiOqz3aC/W/xJZp3lPYjKfqd nP2/Ei72/GVo0EQPlQv+4ioMOPDPXPv3o/Ki7fGyOegCpbYermnCWsFsnMSrkwaKRzNr oBAQ== X-Gm-Message-State: AHQUAuZMPxR6hjKjsy95yC6LqSFd30q7pfHwBRUzZQn5rxEn8/k4XIJI 0TiCspBuhLkj5ftkCeBxFkTtEqk1BMRIqdUvRUKf3jb2 X-Google-Smtp-Source: AHgI3IalQ+WVpOGKL8hBlQjYQ4GDXKKdCPAy1I4AzdX8DxQ0eQ1keHLTuGxzs/Xypira/3QHf8LZ/7yFo0QyDxOlgIU= X-Received: by 2002:a05:6830:e:: with SMTP id c14mr9276141otp.144.1551045110365; Sun, 24 Feb 2019 13:51:50 -0800 (PST) In-Reply-To: <834l97pv0l.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::331 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233582 Archived-At: Am Mi., 13. Feb. 2019 um 16:29 Uhr schrieb Eli Zaretskii : > > > From: Philipp Stephani > > Cc: Philipp Stephani > > Date: Mon, 11 Feb 2019 21:17:39 +0100 > > > > pending_signals is often set if no quit is pending. This results in > > bugs in module code if the module returns but no quit is actually > > pending. > > > > As a better alternative, add a new process_input environment function > > for Emacs 27. That function processes signals (like maybe_quit). > > Thanks, this LGTM. Thanks, pushed as 72ec233f2a.