From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: What's the line length limit in the Emacs codebase? Date: Fri, 25 Dec 2020 18:11:57 +0100 Message-ID: References: <83wnx8pm0e.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32970"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , Emacs developers To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Dec 25 18:14:08 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ksqfF-0008Rq-Kr for ged-emacs-devel@m.gmane-mx.org; Fri, 25 Dec 2020 18:14:05 +0100 Original-Received: from localhost ([::1]:60730 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ksqfE-0001kh-KW for ged-emacs-devel@m.gmane-mx.org; Fri, 25 Dec 2020 12:14:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44742) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ksqeH-0000uc-QH for emacs-devel@gnu.org; Fri, 25 Dec 2020 12:13:05 -0500 Original-Received: from mail-oo1-xc33.google.com ([2607:f8b0:4864:20::c33]:42688) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ksqdO-0001ld-DC; Fri, 25 Dec 2020 12:13:05 -0500 Original-Received: by mail-oo1-xc33.google.com with SMTP id x203so1000225ooa.9; Fri, 25 Dec 2020 09:12:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=ZZjP7HPCVfgJNH9p4Jl7D2rDjksNFe0iC2fYS0Vvtrc=; b=polil2m3KIKREPyIhex9DZQr083wKsu0e1XFVWLIWMv/UXSuTlhhtkYO5yvqDaH+uG QUx9cIqorWpdpiQXkBVX6bzGiX0Gjc2hF+F1OYwWWyirNvF99f5xh97GTJ6p8X+W+qOY i8St/k/vH8RlejYEfp22k6xKm4hJw4YFmAeQphjau8sd0RVCG8Cfd+esPfFPtFzGG6T5 YFa9dyv0gjsysZM8mVO5PtsYT4+wtN6wGJLaYxYkrIb1oOW+dVPCDHck0ec5gVKZrOsT m+H3IChcWiC7tiDxPbDog26JHAu3EueOAhemkWKiob16jODXZPzPl5khQnNYEJVDsKzq PUYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ZZjP7HPCVfgJNH9p4Jl7D2rDjksNFe0iC2fYS0Vvtrc=; b=M82amnRrHo2mEz3K6gboXBoImEOUmTp48nFSwOWddaOsxARc11A5F5fqZHo25eA4Mk xdzpEVkSSnbFJVZ4hwloK454tGbHJgQw6Z/X699Bqpuy0tFLXRDzJDrhcdn+FgwVSTky ruENq0rrclJGgNpe36ptJbIC/bFYVvUtHzmotBzbVsuwJs9b+zjXtMh0egB+HBtXegUX cbXcLnkr9+l3s7hW4RPVym2VFm6FbiKNBMNGLFWrq8sRZSLJblhp5bTOZbtQ52+ZQdKU 1mDPudF0v1sNnmgG9mZs4Qun6Eg6jCMz9LZgBjUe/e5g5EH0IhPUdm8gMh11H385HsBO PXAw== X-Gm-Message-State: AOAM530VcqhC1zOS/ErbZN6hAF8nke/2IWd01UXN6Ih1OUoWFZVE4Nw5 ABFb7OMpYqpz7aRBFpWw8sv19+AmmgnwtuRUXmwotIfsHWo= X-Google-Smtp-Source: ABdhPJzlwRX4IdbHOf7hhSrVLsxnpjUT/MOZ2Ljhbw6dYCN1FyeEvSbFa4e+a3+GK2ODa+VIPO20Aa+IQulADrRm+ek= X-Received: by 2002:a4a:b082:: with SMTP id k2mr24348041oon.60.1608916328756; Fri, 25 Dec 2020 09:12:08 -0800 (PST) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::c33; envelope-from=p.stephani2@gmail.com; helo=mail-oo1-xc33.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:261753 Archived-At: Am Mi., 23. Dez. 2020 um 17:55 Uhr schrieb Stefan Monnier : > > >> There seem to be conflicting settings for the line length limit in the > >> Emacs codebase: .dir-locals.el sets fill-column to 70, but large areas > >> of the source code (including comments) seem to use 80. Can we pick > >> one value and use it consistently (for new/changed code)? > > > > 70 is it, we just don't necessarily enforce it religously. > > > > Where did you see significant deviations from that standard? > > Indeed. I'd say that we it's a kind of progressive limit: > - it's OK to have all lines =E2=89=A4 70-columns wide > - it's not OK to have most lines >70-columns > - we tolerate reaching the area between 70 and 80 columns every once in > a while, tho. > - =E2=89=A580 columns OTOH should really be rare, limited to the exceptio= nal > cases where the alternative is really worse. > This seems overly complicated, and people are unlikely to follow complicated rules. Let's just pick a number and stick to it consistently.