From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: emacs | Pipeline #8399 has failed for master | ee0e259e Date: Sun, 17 Jan 2021 11:37:02 +0100 Message-ID: References: <5feaf98365b55_3f903d428113941@emba.gnu.org.mail> <87o8ica9xp.fsf@gmx.de> <87pn2s35a2.fsf@gmail.com> <87ft3oa4pz.fsf@gmx.de> <8735zo9ui7.fsf@gmx.de> <87h7nw39gg.fsf@gmail.com> <87im8b3jo6.fsf@gmx.de> <87lfd6cld0.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25699"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Emacs developers To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jan 17 11:37:50 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l15RO-0006ac-4E for ged-emacs-devel@m.gmane-mx.org; Sun, 17 Jan 2021 11:37:50 +0100 Original-Received: from localhost ([::1]:57162 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l15RN-0006e3-2L for ged-emacs-devel@m.gmane-mx.org; Sun, 17 Jan 2021 05:37:49 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60938) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l15Qq-0006Ew-Ob for emacs-devel@gnu.org; Sun, 17 Jan 2021 05:37:16 -0500 Original-Received: from mail-ot1-x332.google.com ([2607:f8b0:4864:20::332]:35016) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l15Qp-0001Ml-4i for emacs-devel@gnu.org; Sun, 17 Jan 2021 05:37:16 -0500 Original-Received: by mail-ot1-x332.google.com with SMTP id 36so1856635otp.2 for ; Sun, 17 Jan 2021 02:37:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FfdZegaoCCMLQb8pi3erVfO1q3/KKoYVNJITfkssMLA=; b=EE8CH3M6eK1K6WTjJBWAjaJAbcSSuiPi6Ry5C9GHJG8mLxBTGPGvXExgAb9bQfTKxP PAF9z9cberHPI6Aamh0ozXwEsHw60lRFfPexO/9v56V9tppOsOiA722LjaRLZCtEDIRg 44vKwIBoClDYvTesBx5R+nGtER3BQv/T2a1i54plYB6GvTBL0/voRvVl+Q1NbBMVb6oW FbNNz31aTBC4rWAP6/SJ6Ck4LfLzBvyJzAmKsrRf4SSiAP/Gjzi7AIwFQCxEOVq6dNgK xFztQUyGd8G/X8H/dsIZ9KLE99KJGEAkH1FGp1wv8eQQycPpu1vD5P3r64LtwOS+S5YQ EN/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FfdZegaoCCMLQb8pi3erVfO1q3/KKoYVNJITfkssMLA=; b=He2oCC+aPB1dAMaj2GBWimKzGfMwdPyiujJsMF2VQ6Q6xSJGrjyvhWMq2rNJ2PzJpN NJR9tJgBTrvfevdUpgmkLZeWeRn0KJhxUeO6fuWCkz2F/f904pbmZz6K5b7G3brXP47u NYCFnhDjdutkT92GqyrJ2uiq0NPLQK+DDFZMJsjn83OHTaX8iShWgjZHQ3x0fR8EwcvF wG2oS8ItBePTzjWMkINxSVLOWN6eg6byV4hegM7uKDzRcHnyIevNg3fTEXgMt0FK5fgs 8y9xjSMmlkh+sBaa2hOtWjyNTuI81xB8jv7sDf3uyvEGgpOW/kZPZ5E6oBZnh8cnVypU Of2Q== X-Gm-Message-State: AOAM532ygoqQaEQLsavCD12GrRsyLPYnvfB1XBFCNDTB3Z3RBNNBKJg8 /wsFNDo8luthgITKjlPfgYT6Xq8dpzt2HgHhSuQ= X-Google-Smtp-Source: ABdhPJyFb+gD1Fa4irgDBB7vqpB78JrJW0cfOj5WPlkXb7qJCWB5tMndSpmoNmc6PxQVC8fV6R5SXvMntb4NexC1PIk= X-Received: by 2002:a9d:4e8d:: with SMTP id v13mr1338752otk.12.1610879833850; Sun, 17 Jan 2021 02:37:13 -0800 (PST) In-Reply-To: <87lfd6cld0.fsf@gmx.de> Received-SPF: pass client-ip=2607:f8b0:4864:20::332; envelope-from=p.stephani2@gmail.com; helo=mail-ot1-x332.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263115 Archived-At: Am Mi., 6. Jan. 2021 um 13:15 Uhr schrieb Michael Albinus : > > Philipp Stephani writes: > > Hi Philipp, > > >> >> process-test-sentinel-wait-function-working-p which is used by > >> >> process-test-sentinel-sit-for looks racy. Just because the process > >> >> sentinel has been called is no guarantee that the process has exited > >> >> and had its process-status set correctly, perhaps it should loop on > >> >> 'process-live-p' > >> > > >> > AFAIK the only correct way to wait for a process to exit is (while > >> > (accept-process-output PROC)). > >> > >> I vaguely remember that Stefan did propose (while (accept-process-output > >> PROC 0)). > > > > I guess that would work as well, but wouldn't it result in a busy > > wait? > > No. If there's no output, or the connection is closed, it shall return nil. > Well, this is also true for (while (accept-process-output PROC)), but > this could block if the process just waits for something to happen. You're right in that (while (accept-process-output PROC 0)) doesn't result in a busy wait, yes. However, since accept-process-output returns nil in that case, it wouldn't wait at all. But these tests (e.g. process-tests-stderr-filter) are clearly intended to wait for process exit; they even contain assertions that the process has exited. I'm still convinced that (while (accept-process-output PROC)) is the only correct way to wait for PROC to finish (see the "Accepting Output" Info node). > (OTOH we have wrapped now the tests with a 60 second timeout; this might > be sufficient.) We should never hit a timeout in these cases. These test processes should exit immediately and never hang. Any timeout indicates a bug either in the tests or in Emacs itself.