From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Ignore pending_signals when checking for quits. Date: Sun, 10 Feb 2019 19:49:39 +0100 Message-ID: References: <20190102212218.74902-1-phst@google.com> <83sgy93kkd.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="26491"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Philipp Stephani , Emacs developers To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 10 19:50:50 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gsuBl-0006mA-Ux for ged-emacs-devel@m.gmane.org; Sun, 10 Feb 2019 19:50:50 +0100 Original-Received: from localhost ([127.0.0.1]:34326 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gsuBk-0007XO-VR for ged-emacs-devel@m.gmane.org; Sun, 10 Feb 2019 13:50:49 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58125) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gsuB2-0007TV-8E for emacs-devel@gnu.org; Sun, 10 Feb 2019 13:50:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gsuB1-0006SE-Gw for emacs-devel@gnu.org; Sun, 10 Feb 2019 13:50:04 -0500 Original-Received: from mail-ot1-x344.google.com ([2607:f8b0:4864:20::344]:42546) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gsuAr-0006Ml-Lp; Sun, 10 Feb 2019 13:49:53 -0500 Original-Received: by mail-ot1-x344.google.com with SMTP id i5so3508172oto.9; Sun, 10 Feb 2019 10:49:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AHi75w7huzdGGBCazB/fnosuRZItwwvWEu07qZwY+Hw=; b=Ot+ZLn8BAan1X7TKlUZCjtDJASx+dUsJ/4oPaX//xLCiOBf8Oq7rIYIyk41FrD8CVe sJX70mz/BDQeIBgYbVqj1/9mSuViculzAnFquFf3oElK26Od+t8hZN0RpJTFbU6nqpoX aDvjzkKTyx4oHZLoDTxJ2RL5Zi4Y3dIXCHDwFoL1X9cAKmhPLgdpT278+L3C8lpDxCMH sw5rWJ8ihtVjQZjx6/vZs12FfKufFiHWqddWXwvYj26pDe740/CY6FROHV86WPGduKlD srqOQDAl+8L74MpoL/2GN/tCyYAl5SCYAexs1kMM7DGwVDheNpj/GFqFYypKBOSbWpcP +O3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AHi75w7huzdGGBCazB/fnosuRZItwwvWEu07qZwY+Hw=; b=EnX2en35HwgwJDBMGmpKmRcWZkPJjeeUZKU+fAK4GRRVWeHhaAv1gVceOiYpxKoPK7 OIUbtfQ9Qw+aO3DoL60hNbll1Bnsu0n1JZvhP+4Us2aPTwB/dmak1HbcbRQzuiQyrl9+ pR6Ppxs8jXqADncUrWLiMnsJioqOvV9yfN74/m1o1NjvNCKgYc0XrqqA5+zrNft2O/6h 8MHkda74psgk+rYmsRggtl+ONfPyerIl7bMkFxk+cmCsBGlYRouKu2BL+vIwJnI0QF4H 8cwcP7esxRqsSUIWPG3jnp3O/axIqzprwd1ihV/Mh52LcikeKt9+a1GIZQM/mHbxme77 ZUng== X-Gm-Message-State: AHQUAuaoh/GvSDMaa8Zs5eDrnuJ3e2gcLqFm5JeGon70i6AhtaZpseWc O9Ewj+boXt4F6WEoWNJRvHQs3GWFUbFrseEskN4j6Q== X-Google-Smtp-Source: AHgI3IYES2pgH30YaowXOaiAVLpptu3oXwyECxAAgakJi7S3DUPwpx2h5qF+smYpyxbB2fblLNVA2l2ODKg/4VhiZOo= X-Received: by 2002:a9d:4687:: with SMTP id z7mr25140551ote.350.1549824589934; Sun, 10 Feb 2019 10:49:49 -0800 (PST) In-Reply-To: <83sgy93kkd.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::344 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233198 Archived-At: Am Do., 3. Jan. 2019 um 15:03 Uhr schrieb Eli Zaretskii : > > > From: Philipp Stephani > > Date: Wed, 2 Jan 2019 22:22:18 +0100 > > Cc: Philipp Stephani > > > > static bool > > module_should_quit (emacs_env *env) > > { > > MODULE_FUNCTION_BEGIN_NO_CATCH (false); > > - return (! NILP (Vquit_flag) && NILP (Vinhibit_quit)) || pending_signals; > > + return QUITP; > > } > > Bother. I see your point regarding the return value when just > pending_signals is set, but disregarding pending_signals doesn't sound > TRT to me, either. It means various Emacs features based on input > detection won't work while the module code runs, even if the module > tries to be nice and does call module_should_quit. For example, > while-no-input and atimers won't work, and Emacs will generally be > much less responsive to user input. > > So maybe we should indeed return true only if QUITP says so, but we > should also call process_pending_signals from module_should_quit, when > pending_signals is non-zero? Wouldn't that mean that Emacs could do something (e.g. process events)? That wouldn't match the naming and intention of should_quit: By its name, it should only query information and not change any state.