unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Philipp Stephani <p.stephani2@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Philipp Stephani <phst@google.com>,
	Emacs developers <emacs-devel@gnu.org>
Subject: Re: [PATCH] Add a new user option 'ido-big-directories'.
Date: Wed, 17 Apr 2019 20:30:55 +0200	[thread overview]
Message-ID: <CAArVCkQTYbN3VfBAbo-3jWuGp0=oRfME9+bZMMuRJGR7ueYSFw@mail.gmail.com> (raw)
In-Reply-To: <835zrjmlbj.fsf@gnu.org>

Am Fr., 12. Apr. 2019 um 14:59 Uhr schrieb Eli Zaretskii <eliz@gnu.org>:
>
> > From: Philipp Stephani <p.stephani2@gmail.com>
> > Date: Fri, 12 Apr 2019 14:23:01 +0200
> > Cc: Philipp Stephani <phst@google.com>
> >
> > This provides an alternative to 'ido-max-directory-size', for
> > directories that are statically known to be too big for Ido
> > completion.
>
> Thanks.
>
> > +** Ido
> > +*** New user option 'ido-big-directories' to mark certain directory
> > +patterns as big.
>
> This doesn't say what is a "pattern" and what is the meaning of "big"
> in this context.  Could that be at least hinted at?
>
> > +(defcustom ido-big-directories nil
> > +  "Additional directories that should be considered big.
> > +Ido will ignore directories matching any of these regular
> > +expressions."
>
> The doc string should explicitly say what is the form of the value.
> Also, since the elements of the sequence are regular expressions, the
> first sentence should mention that, or at least say they are strings.

Thanks, I'll send a new patch.



  reply	other threads:[~2019-04-17 18:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-12 12:23 [PATCH] Add a new user option 'ido-big-directories' Philipp Stephani
2019-04-12 12:58 ` Eli Zaretskii
2019-04-17 18:30   ` Philipp Stephani [this message]
2019-04-17 18:31     ` Philipp Stephani
2019-04-18 14:40       ` Eli Zaretskii
2019-04-19  8:35         ` Philipp Stephani
2019-04-17 18:58 ` Óscar Fuentes
2019-04-19  9:10   ` Philipp Stephani
2019-04-19 12:23     ` Óscar Fuentes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAArVCkQTYbN3VfBAbo-3jWuGp0=oRfME9+bZMMuRJGR7ueYSFw@mail.gmail.com' \
    --to=p.stephani2@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=phst@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).