From mboxrd@z Thu Jan 1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Philipp Stephani
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH] Ignore pending_signals when checking for quits.
Date: Wed, 7 Aug 2019 18:22:13 +0200
Message-ID:
References: <83y36nl7rl.fsf@gnu.org> <20190211201739.25229-1-phst@google.com>
<834l97pv0l.fsf@gnu.org>
<83y345bvk6.fsf@gnu.org>
<83r29mt1ja.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
logging-data="140630"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: Philipp Stephani , Emacs developers
To: Eli Zaretskii
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 07 18:22:49 2019
Return-path:
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.89)
(envelope-from )
id 1hvOi7-000aRy-4T
for ged-emacs-devel@m.gmane.org; Wed, 07 Aug 2019 18:22:47 +0200
Original-Received: from localhost ([::1]:43348 helo=lists1p.gnu.org)
by lists.gnu.org with esmtp (Exim 4.86_2)
(envelope-from )
id 1hvOi5-0007ng-OG
for ged-emacs-devel@m.gmane.org; Wed, 07 Aug 2019 12:22:45 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41073)
by lists.gnu.org with esmtp (Exim 4.86_2)
(envelope-from ) id 1hvOhp-0007nL-Bc
for emacs-devel@gnu.org; Wed, 07 Aug 2019 12:22:30 -0400
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
(envelope-from ) id 1hvOho-0003wu-8h
for emacs-devel@gnu.org; Wed, 07 Aug 2019 12:22:29 -0400
Original-Received: from mail-ot1-x342.google.com ([2607:f8b0:4864:20::342]:37033)
by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
(Exim 4.71) (envelope-from )
id 1hvOhm-0003te-EI; Wed, 07 Aug 2019 12:22:26 -0400
Original-Received: by mail-ot1-x342.google.com with SMTP id s20so41102066otp.4;
Wed, 07 Aug 2019 09:22:25 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=mime-version:references:in-reply-to:from:date:message-id:subject:to
:cc; bh=bFfX6j4zCx2FPIeN9HcEneqaUIQtx+hC68TguYtLmkM=;
b=TUn4uNwMBsQTKURoyn/QNd2klNIZlpRwXNm1aCUwj8QuXIYgQ6TNYA54gakfgAn8eU
uiaFbmj33qaybrg02nyWXymPY/Zv3X1Pl2NpLQUxBU3bs21SQmaQGl2VZM2GEElKdurv
yYnAROULnlIHrDTebpAgUHFXBch5Ri9U/cg8fIwnKCjdX+6bfgkTGto8NbR/o6yrmQMw
MXFNO6UFZT8itxYehMtHa1ChEGxTGFLExVHc7G6SqSHxeNYCD7zVRcU9WpjhrrQ4XWX6
9Jo1ewcgsqDkfJaFUsvk+ka0qGDF92er/tmT3R9Ztmf/pTMyTVFFWAe+2las0ZYOEjwa
MrBg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=bFfX6j4zCx2FPIeN9HcEneqaUIQtx+hC68TguYtLmkM=;
b=Wd0GSyMQcuxCUMCJeeJoLEIPTyfHEj8M8HB0XyDCsaY1h30D2ClY9F/EayNkRtJ3jg
sdDVEmoGepbwMxAKmY9IxvEUunxR7NnxFZ89Pr41HYsF+pwHjtG54eIhdPemgQJGjvuy
58lt7xusCLFXSCnkP0oNpJ8lxeCOWP3giAHj0x8Nc2xd9LrpHrxdQaOFxx9HxDSJpFwg
rBtMQcT86vnGMl5KeYRjuwZwGoUVdBDmnoPI9PL/w4lgZfjeaEkqTVP+gwPcy6CcFcSF
mGO6itCj8zzGfx0yGBJLdPwYMsk6Cs6Xt8ocuIYlGMBZ26qJ3CBFaIct7oSqjVRRIDia
jQuA==
X-Gm-Message-State: APjAAAVtenPF0fFaFKEQNsDsKNhfaRVQUZM5347wDfG5GlE+kqD/Lv8C
1VMWFh+7vaAoUrc1A5fyGQNzjsayMsTDkbVfRUNCApp4M9Y=
X-Google-Smtp-Source: APXvYqx8y8D10YiiMV2g6MCTqjqyXnfHJQWoSkzrH08Qnr7c/pePVIPCO+DQw2eaT/KYMKGTcYkhILXFI5p0bD7kMJQ=
X-Received: by 2002:a9d:6c17:: with SMTP id f23mr7787517otq.174.1565194944773;
Wed, 07 Aug 2019 09:22:24 -0700 (PDT)
In-Reply-To: <83r29mt1ja.fsf@gnu.org>
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
recognized.
X-Received-From: 2607:f8b0:4864:20::342
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions."
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel"
Xref: news.gmane.org gmane.emacs.devel:239231
Archived-At:
Am So., 28. Apr. 2019 um 20:42 Uhr schrieb Eli Zaretskii :
>
> > From: Philipp Stephani
> > Date: Sun, 28 Apr 2019 20:19:42 +0200
> > Cc: Emacs developers , Philipp Stephani
> >
> > > > Question: Would it be OK to backport the first part (using QUITP in
> > > > module_should_quit) to Emacs 26.3?
> > >
> > > Please show the part that you suggest to backport, I don't think I
> > > understand what that is.
> >
> > The initial patch, i.e.
> >
> > --- a/src/emacs-module.c
> > +++ b/src/emacs-module.c
> > @@ -671,13 +671,13 @@ module_vec_size (emacs_env *env, emacs_value vec)
> > return ASIZE (lvec);
> > }
> >
> > -/* This function should return true if and only if maybe_quit would do
> > - anything. */
> > +/* This function should return true if and only if maybe_quit would
> > + quit. */
> > static bool
> > module_should_quit (emacs_env *env)
> > {
> > MODULE_FUNCTION_BEGIN_NO_CATCH (false);
> > - return (! NILP (Vquit_flag) && NILP (Vinhibit_quit)) || pending_signals;
> > + return QUITP;
> > }
>
> If you don't mind breaking compatibility in a minor release, I'm okay
> with backporting this.
Done (commit b83f83ccd4).