From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Ignore pending_signals when checking for quits. Date: Fri, 19 Apr 2019 21:06:48 +0200 Message-ID: References: <83y36nl7rl.fsf@gnu.org> <20190211201739.25229-1-phst@google.com> <834l97pv0l.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="85432"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Philipp Stephani , Emacs developers To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 19 21:17:22 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hHZ0j-000M0u-7l for ged-emacs-devel@m.gmane.org; Fri, 19 Apr 2019 21:17:21 +0200 Original-Received: from localhost ([127.0.0.1]:60325 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHZ0i-0008Mk-6w for ged-emacs-devel@m.gmane.org; Fri, 19 Apr 2019 15:17:20 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58442) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHZ0O-00089n-QE for emacs-devel@gnu.org; Fri, 19 Apr 2019 15:17:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hHYqo-0004H4-3A for emacs-devel@gnu.org; Fri, 19 Apr 2019 15:07:06 -0400 Original-Received: from mail-ot1-x336.google.com ([2607:f8b0:4864:20::336]:33355) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hHYqi-0004Am-My; Fri, 19 Apr 2019 15:07:00 -0400 Original-Received: by mail-ot1-x336.google.com with SMTP id j10so5063434otq.0; Fri, 19 Apr 2019 12:07:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6+zB0yQ5jF9NrlQM57KGw+zuAfegRQ+Ka2VEpQJ35nE=; b=uE1qkr+kyXQIJ05doKQqXaAkLuAa8+KrPcIpUOqzl+qa+SQXksoCnE+C75urG1jpPy GGT7L1cOB8ZqESdDHVv60fUWuIymWoRNP5nQd/y4FsAsk42z3l9jPabtn2Ldb4R/0ZO8 C6c9zrx7G/fCmjsZrpkoYgh4ai70fPvHotEJx8Q8DZNQmm4MI6+inINQ29pJw9tyikrL lrea7zVSSm+eQMuv3KY7ATrjgFasy3mJqOcTqZD2Xb6LpdRYaqlNNbQdiF/hGWEpEMJd Cbukf6oOwqFU2t7PktSraxh+ZqaB2MlcsNlnm3/tdclYeiYOgQDDmO4AzOGd/W2zpvZr fcVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6+zB0yQ5jF9NrlQM57KGw+zuAfegRQ+Ka2VEpQJ35nE=; b=MjHvkTg2+n5YQ1cmHttmJo9j2F1xgWb/w+23B5FGmsChDKWUJ1BtQVHJSz+EqTb+bC 1V6/B8Qbjt58wKE3uTvMlvyx2kRx9/XKqPXdt4tC6Wy+lS/9bWX+Gg6BI9/FmZotMKR6 4apJbGARrzpyLQmWS/hckXoar1ZpFhs03u8i2yPsiTrpnHezbMjtOQ0z0pGxNxUqMpoY tH90GOdQ7KKeW++5O8/yH85hfw1zVfEWgKrSOP922JPQbyvK/uOLFNUSc61hAMq+z14C pge0vcA3f0k60YuQUlHhNemjLlNd/TVNDzmHjtKmvx4weERBEtjQ/LT83333znV8fnRD WOKA== X-Gm-Message-State: APjAAAVb1YwgsYhCrqQowOsneBncCy0uBz/VEq0AjXstc8QMyLk9BXHf 2zLM3pJIeAv2y/I9d6M3wnKV6LxMtasnopVoHju+N/Ml X-Google-Smtp-Source: APXvYqy5iCPWvNmE/SB4E3Sm/gDXGW4+PLMNA1A1fte3Sa1fIQJ4tMlhLjN3Rr4hR8ZGJhkupNoTScZpgMMalrAMDXk= X-Received: by 2002:a9d:6a43:: with SMTP id h3mr3127430otn.270.1555700819418; Fri, 19 Apr 2019 12:06:59 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::336 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235669 Archived-At: Am So., 24. Feb. 2019 um 22:51 Uhr schrieb Philipp Stephani : > > Am Mi., 13. Feb. 2019 um 16:29 Uhr schrieb Eli Zaretskii : > > > > > From: Philipp Stephani > > > Cc: Philipp Stephani > > > Date: Mon, 11 Feb 2019 21:17:39 +0100 > > > > > > pending_signals is often set if no quit is pending. This results in > > > bugs in module code if the module returns but no quit is actually > > > pending. > > > > > > As a better alternative, add a new process_input environment function > > > for Emacs 27. That function processes signals (like maybe_quit). > > > > Thanks, this LGTM. > > Thanks, pushed as 72ec233f2a. Question: Would it be OK to backport the first part (using QUITP in module_should_quit) to Emacs 26.3? Right now should_quit behaves erratically: it occasionally quits, but in other instances doesn't because pending_signals has been reset in the meantime.