From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: Cherrypicking commit e08de2bae2a8e91c0245259dfcbfdca1d191a119 onto emacs-26 Date: Tue, 25 Dec 2018 17:02:27 +0100 Message-ID: References: <83zi39p38o.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1545753645 24551 195.159.176.226 (25 Dec 2018 16:00:45 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 25 Dec 2018 16:00:45 +0000 (UTC) Cc: Emacs developers To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 25 17:00:41 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gbp8K-0006I2-BY for ged-emacs-devel@m.gmane.org; Tue, 25 Dec 2018 17:00:40 +0100 Original-Received: from localhost ([127.0.0.1]:41885 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gbpAQ-0007WU-Tb for ged-emacs-devel@m.gmane.org; Tue, 25 Dec 2018 11:02:50 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:52969) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gbpAI-0007WO-7z for emacs-devel@gnu.org; Tue, 25 Dec 2018 11:02:43 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gbpAH-0004n8-8X for emacs-devel@gnu.org; Tue, 25 Dec 2018 11:02:42 -0500 Original-Received: from mail-ot1-x335.google.com ([2607:f8b0:4864:20::335]:40817) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gbpAG-0004m9-2S; Tue, 25 Dec 2018 11:02:40 -0500 Original-Received: by mail-ot1-x335.google.com with SMTP id s5so12593606oth.7; Tue, 25 Dec 2018 08:02:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=qTKh50UJuFiwnCudvhL+XoV/XAMmcY/uYT6PPmK2o/s=; b=BCD0WqzjHWPDcH+3ko+uoWwkKfPWTUGzvcDExxodQqcD3dh7j6rIAXcwOs6P13yf8W FAzLn44+74qZzVUr9u/a3YnlF+xDuDdsExSPteInWVieeJ/MgmVLeOTf55CuAme0hiHJ yJzu0rGMdirM2CSFcsQpST7ELOfR1fsTJzavxLtppMBEkeoAs7NgFs85iPelZVvEPBrr Ke2sOIHB5C00pQU50pA2hZNzEeX7lyEVjESRneQmX2q4yQ7fpo9vgxezN9o1RWp7dB8u 3hJhoLaH3IhaQlZLIYrAeuEBfE8wS5iXibp194vgMvNGUjLZmqoyV9h278McoSHnbo2K NCMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=qTKh50UJuFiwnCudvhL+XoV/XAMmcY/uYT6PPmK2o/s=; b=WHS+CIJhoYv1jcmN62qlgLufPvJ6mLlBwlxaGav86s6UoeXt7Em+d47CHrzpRhT4T9 gzJWBD6VE1xw76vXbu39gg78kYmEInNxgf/vUzEdKeHf73R3CklNlgxMCeWbU2Fbi9FS w6ONj0vBDakEuMdq4LvLpKAN2dPEE4kUiovR0N7YPP3NTblHYfTqLv9iuiaxnarFqEAx X/AdDtsF5G8Pu8of5u16SfCMyCoaH0R40J52bSnDmH3meYl71Lu5GuKICTY4KuTyOUhy AAFGllBOI4xeNlkGs3S4GQIyvjQKAURCA/r9JK7z+E2TzlwoCnvB0WGtX458XWDjXV2x OL+Q== X-Gm-Message-State: AJcUukcw68yj5zt/wkdQ6pWe1UyZPM71Y4bDy1Wl4muIlnb2g0oSkkHm KGnPOKngnsdx5CfKFWhsJmSKuyZSREeQL6iczFkHG5t0 X-Google-Smtp-Source: ALg8bN628yz5OKxOvovbUk5wU09oLYiDxdFQ0zB6GL7P6j4I++ou42CPuafQc6jNwwpFdolqMrQL5wFuybu3x96udzk= X-Received: by 2002:a9d:60cf:: with SMTP id b15mr11059638otk.144.1545753759127; Tue, 25 Dec 2018 08:02:39 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::335 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231980 Archived-At: Am Do., 15. M=C3=A4rz 2018 um 20:37 Uhr schrieb Philipp Stephani : > > > > Eli Zaretskii schrieb am Do., 15. M=C3=A4rz 2018 um 20:07 = Uhr: >> >> > From: Philipp Stephani >> > Date: Thu, 15 Mar 2018 18:34:27 +0000 >> > >> > would it be OK to cherrypick commit e08de2bae2a8e91c0245259dfcbfdca1d1= 91a119 onto the release >> > branch? It fixes a bug that makes filenotify watches essentially unusa= ble with quoted filenames, and is very >> > short and localized. >> >> How can anything related to quoted file name be urgent to fix? > > > Quoted filenames are a core Emacs function that is prominently documented= , see e.g. https://www.gnu.org/software/emacs/manual/html_node/emacs/Quoted= -File-Names.html. They are also the only reliable method for external scrip= ts and libraries to ensure that Emacs doesn't mangle a local filename in un= predictable ways. Therefore it's very important that quoted filenames are b= ugfree. > Perhaps even more importantly, that commit fixes a regression: > emacs -Q -batch -l filenotify --eval=3D"(file-notify-rm-watch (file-notif= y-add-watch \"/:/tmp/\" '(change) 'ignore))" > works in master and Emacs 25.2, but not with the release branch. Is it OK to cherrypick commit e08de2bae2a8e91c0245259dfcbfdca1d191a119 for Emacs 26.2? Thanks!