unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Philipp Stephani <p.stephani2@gmail.com>
To: Paul Eggert <eggert@cs.ucla.edu>, Emacs developers <emacs-devel@gnu.org>
Subject: 27bb4de72b * Port cleanup attribute to Oracle Studio 12.5
Date: Wed, 14 Jun 2017 10:29:49 +0000	[thread overview]
Message-ID: <CAArVCkQ4rWXA=WPjZ5X6VtKQH-TFSeU-XX0VY5X=+SQSXGBLgw@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 298 bytes --]

Hi,

the commit message says "The C compiler should check the cleanup attribute
in the next line anyway." But that's not the case: unknown attributes are
silently ignored, at least in Clang. The verify(__has_attribute(cleanup))
or equivalent is absolutely required here. Can we revert that commit?

[-- Attachment #2: Type: text/html, Size: 358 bytes --]

             reply	other threads:[~2017-06-14 10:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-14 10:29 Philipp Stephani [this message]
2017-06-14 18:25 ` 27bb4de72b * Port cleanup attribute to Oracle Studio 12.5 Paul Eggert
2017-06-15 12:54   ` Philipp Stephani
2017-06-15 18:46     ` Paul Eggert
2017-06-15 19:20       ` Philipp Stephani
2017-06-15 20:33         ` Paul Eggert
2017-06-16 16:34           ` Philipp Stephani
2017-06-16  3:19         ` Richard Stallman
2017-06-20 19:18           ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAArVCkQ4rWXA=WPjZ5X6VtKQH-TFSeU-XX0VY5X=+SQSXGBLgw@mail.gmail.com' \
    --to=p.stephani2@gmail.com \
    --cc=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).